From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gKRIBrAnS2DnKAAA0tVLHw (envelope-from ) for ; Fri, 12 Mar 2021 08:34:56 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qN0JArAnS2AzYwAAB5/wlQ (envelope-from ) for ; Fri, 12 Mar 2021 08:34:56 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A9F68B0EF for ; Fri, 12 Mar 2021 09:34:55 +0100 (CET) Received: from localhost ([::1]:60240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKdG2-0005zG-ON for larch@yhetil.org; Fri, 12 Mar 2021 03:34:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKdEl-0005LB-TR for guix-devel@gnu.org; Fri, 12 Mar 2021 03:33:36 -0500 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:50850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKdEh-0008UD-9t; Fri, 12 Mar 2021 03:33:34 -0500 Received: by mail-pj1-x1035.google.com with SMTP id gb6so4816184pjb.0; Fri, 12 Mar 2021 00:33:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WwPCDFeyQaWozYtNKUj1/sV2nbWS9zAcT5orVWv84HA=; b=F4c+E2smGkRGSk/nYWwkbctrrr3LCa+dBbwXQdI+KQDHdpYRpWnwOH73s4XoWJJPLW bTyq3yn9OjTskYmIMkLscJv6YP5SnFTig2zSbGpCPLERVmHSz4NgcC5X+Agc+GjdQnpb wt2x2G633xygCXuVcH7agzzVW2X+i29zuUs/fE4cUmU4yOkmtrdXfADDAyepBNO990Et itNR2eUWpQgTyY2wy+T3kRFmcS5COCjYLxkHww8tB8Id3Vxuy4drCPXHuqBflCOpDhYZ bdoWbqO2Xk0ZtUVjdcNIs1xiBE+8YQBoWWYB7WgNHMKYDii6SU6bXY0DvGDY4FTsc/CM eqZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=WwPCDFeyQaWozYtNKUj1/sV2nbWS9zAcT5orVWv84HA=; b=skHEmzZjUymN/l+XfBQTEiYB9PPIabEZVLJh9/WWG1C/0kHGRjn0V5X8FJR8eH17X2 LZ++UUi8VzV419bh1KXJYvkbCRYSabsRJEbmbBoLOe886PtQmhBHkUJKPgBj5AVu+mXY a9rK69QjPljT8DWJI5x2yEqaZRI/S8zPb3kgt76FXw44xpb2rvECtHbYVl6h34mQ45IQ dUzsOCCppts4BPcRX3JiRfcSnHl/gDnctoQR6h1Q47o4WyMnv3aU4Uu9o+kq/FIuAdAS /Kz983xG6+2zILUyMZJihUfhvYMaqPyOd5tacpdV3WtOwlUjaEzDw6ZA6DE/5uGHmUBa qHcw== X-Gm-Message-State: AOAM5302Kt4fhbVLWnYhgCQTrrCzFB5kElS9EyC9MCX/n4IK3CngQDAx KnT8ysQkTVfCKNhLeraTBnen4J/y783Dnw== X-Google-Smtp-Source: ABdhPJzDTtn2QonhMScDsMLabBFxlV5ndD/G5UVosR4JLuF6H4K1l+4pcX6rk8M154ejsjAZNnR+ZQ== X-Received: by 2002:a17:90a:bb8d:: with SMTP id v13mr13357304pjr.12.1615538004099; Fri, 12 Mar 2021 00:33:24 -0800 (PST) Received: from garuda-lan (c-24-18-44-142.hsd1.wa.comcast.net. [24.18.44.142]) by smtp.gmail.com with ESMTPSA id u7sm4423049pfh.150.2021.03.12.00.33.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 00:33:22 -0800 (PST) From: Chris Marusich To: Efraim Flashner , =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: Release on April 18th? References: <87im6042fr.fsf@gmail.com> <86sg53cf58.fsf@gmail.com> <87a6ra3w39.fsf@gmail.com> Date: Fri, 12 Mar 2021 00:33:18 -0800 In-Reply-To: (Efraim Flashner's message of "Thu, 11 Mar 2021 15:30:21 +0200") Message-ID: <87h7lgzs8h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=cmmarusich@gmail.com; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615538095; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WwPCDFeyQaWozYtNKUj1/sV2nbWS9zAcT5orVWv84HA=; b=C42MFIt/4QeAN8vadTsRMtBM7EB6tplNcIoB8PqpGmkXFINfZBve2yPWo1Ma1Vt33uxxcN q6IYcKmlzije52TA7i0KLpeI22BKnM+s08dsB4dIvWYBUHMAjgX7D32u/imdJhmQhHCgjX cPERqyHdXzKtOJuUdD0MNr72NhkPjk1A/sjoOyp9aI8Q2moX+9I+bD9C4s3/U8Jvd31hNN OHr5ykdvZ4n6KJFI+UA6ZeyQ4Y6Vo8AhbTaAAkt8v4B0NcARqSWyiztRvvpnaRVg3KDyvZ iBFjE9Sdh8kq/4FAh+Fy6oaxfzmF4J1AhBJQcpw8x679S6mlxL5eSUStZj8INg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615538095; a=rsa-sha256; cv=none; b=t/zgqX+7Ys9G7lOlGNWwGPdUAXYoXaAL4Z2uxp63KlYGFTdLX24oScKo987kxBV+7tbF3I Mf953dD4oMAYj9RbBaMIFYI3k5dcLNHOSuu35dJWki3iKiQZuozwV8MZmgGRoHWiiQVZdL P8m7SPoHoVfSiXhH73Hke2xCAZK0MzfeLkWVHki4fYg0tBzM3+uYdxVLw79sq6qR9iQ9U3 3cd9XGx5Klb4YaSyNUSU5ipnGV4F3QWid36oacEtRWmG1SCuvhkixvGoblYbEkdaGYDtIx 3urGRaspVlYVf6qC29jAeUI/sg7QXRp25ZQ1Y9tZbElvNMLy0Ew/l6xg4wVbBg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=F4c+E2sm; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: 0.11 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=F4c+E2sm; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: A9F68B0EF X-Spam-Score: 0.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: NE10Txn75Q4k --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Efraim and Ludo, Efraim Flashner writes: > My plan was absolutely to merge master into core-updates after and then > integrate all the changes into their affected packages. I'd also make > sure to bump gcc to 8 (assuming we don't go straight to 9). Sounds good. If we can get powerpc64le-linux working on master, I'd be very happy. We can simultaneously try that while still working on wip-ppc64le (based on core-updates). I tried out the wip-ppc64le-for-master branch. I can build it manually on my Debian ppc64le system, but "make check" fails. There are two test failures. The first test failure is tests/syscalls.scm. It seems that Ludo's recently added mount procedure (7e9d9f2 syscalls: Add 'mounts' and the record type.) does not work on my system. In fact, it does not work on my Debian ppc64le system, nor does it work on my x86_64 Fedora system. In both cases, the code makes the incorrect assumption that the type and source are located in columns 8 and 9, like so: =2D-8<---------------cut here---------------start------------->8--- (define (mounts) "Return the list of mounts ( records) visible in the namespace of = the current process." (define (string->device-number str) (match (string-split str #\:) (((=3D string->number major) (=3D string->number minor)) (+ (* major 256) minor)))) (call-with-input-file "/proc/self/mountinfo" (lambda (port) (let loop ((result '())) (let ((line (read-line port))) (if (eof-object? line) (reverse result) (match (string-tokenize line) ((id parent-id major:minor root mount-point options _ _ type source _ ...) (let ((devno (string->device-number major:minor))) (loop (cons (%mount (octal-decode source) (octal-decode mount-point) devno type options) result))))))))))) =2D-8<---------------cut here---------------end--------------->8--- However, on my systems, the correct columns are 9 and 10. Here's the first few lines of output from Fedora: =2D-8<---------------cut here---------------start------------->8--- $ cat /proc/self/mountinfo=20 22 97 0:21 / /sys rw,nosuid,nodev,noexec,relatime shared:2 - sysfs sysfs rw 23 97 0:5 / /proc rw,nosuid,nodev,noexec,relatime shared:24 - proc proc rw 24 97 0:6 / /dev rw,nosuid shared:20 - devtmpfs devtmpfs rw,size=3D3923828k= ,nr_inodes=3D980957,mode=3D755 ... =2D-8<---------------cut here---------------end--------------->8--- And here it is from Debian: =2D-8<---------------cut here---------------start------------->8--- 22 28 0:20 / /sys rw,nosuid,nodev,noexec,relatime shared:7 - sysfs sysfs rw 23 28 0:21 / /proc rw,nosuid,nodev,noexec,relatime shared:11 - proc proc rw 24 28 0:5 / /dev rw,nosuid,noexec,relatime shared:2 - devtmpfs udev rw,size= =3D15625664k,nr_inodes=3D244151,mode=3D755 ... =2D-8<---------------cut here---------------end--------------->8--- On these systems, the 7th column is an optional field, like "shared:7". The proc man page has this to say about column 7: (7) optional fields: zero or more fields of the form "tag[:value]" So presumably there can be even more than just one optional field. In any case, Leo Le Bouter kindly checked his own x86_64 system, where he observed different output: =2D-8<---------------cut here---------------start------------->8--- $ cat /proc/self/mountinfo=20 23 27 0:21 / /proc rw,relatime - proc none rw 24 27 0:5 / /dev rw,relatime - devtmpfs none rw,size=3D7972408k,nr_inodes= =3D1993102,mode=3D755 25 27 0:22 / /sys rw,relatime - sysfs none rw =2D-8<---------------cut here---------------end--------------->8--- As you can see, in this case there is no optional column, so the mount procedure works fine on Leo's system. But it fails on mine. Ludo, do you have an opinion on how to fix this? It seems like we can't assume the number of columns will always be the same, so I guess we'll have to somehow ignore the optional columns more intelligently, if we want to keep using string-tokenize to do this. The second test failure is tests/pack.scm. There are two contributing factors to this test failure. The first contributing factor was commit 8f52ea2 on wip-ppc64le-for-master. It fixes an issue that is not present on master, and for that reason it actually causes a problem if it's included. I have removed it from the branch in Savannah; please update your local copy. The second contributing factor is this bug: https://issues.guix.gnu.org/47018 However, we can work around it by simply not running guix-daemon when running the test. When guix builds guix, it'll be done in the build environment, so these problematic tests will probably be skipped. Finally, I tried running make guix-binary.powerpc64le-linux.tar.xz just to see how far it would get, anyway. I was quickly greeted with this failure when building glibc-intermediate: =2D-8<---------------cut here---------------start------------->8--- glibc-2.31/wctype/wctrans_l.c glibc-2.31/wctype/wctype.c glibc-2.31/wctype/wctype.h glibc-2.31/wctype/wctype_l.c phase `unpack' succeeded after 2.4 seconds starting phase `apply-patch' Backtrace: In ice-9/boot-9.scm: 160: 14 [catch #t # ...] In unknown file: ?: 13 [apply-smob/1 #] In ice-9/boot-9.scm: 66: 12 [call-with-prompt prompt0 ...] In ice-9/eval.scm: 432: 11 [eval # #] In ice-9/boot-9.scm: 2412: 10 [save-module-excursion #] 4089: 9 [#] 1734: 8 [%start-stack load-stack ...] 1739: 7 [#] In unknown file: ?: 6 [primitive-load "/gnu/store/kvwc9b9ga1sl4l6fyi3z182570rbsk2i-glibc-= intermediate-2.31-guile-builder"] In ice-9/eval.scm: 387: 5 [eval # ()] In ice-9/boot-9.scm: 160: 4 [catch srfi-34 ...] In srfi/srfi-1.scm: 827: 3 [every1 # ...] In guix/build/gnu-build-system.scm: 847: 2 [# #] In guix/build/utils.scm: 652: 1 [invoke "patch" "--force" "-p1" "-i" #f] In unknown file: ?: 0 [system* "patch" "--force" "-p1" "-i" #f] ERROR: In procedure system*: ERROR: Wrong type (expecting string): #f =2D-8<---------------cut here---------------end--------------->8--- Something about the way in which we are searching for the patch is off, but I don't have time just now to investigate. Efraim, if you can figure it out, that'd be nice, but I'll look into it more tomorrow. It's probably something simple and related to commit 2712703. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmBLJ04ACgkQ3UCaFdgi Rp03KA/+NnRRiZ4UJ+newVqp+M2kHNMh8XYMO6q7TXNihzzQmiVxmSrtyU8nOjQ1 JAGWVfeNGgGKEoowurNKKrbbXwuLW9GTBpGwq9kHuQ3pEDqibcoXLLBiNUgBhuZp uaH8X74a9w0y7l0iYSn6RJYoXIB9qwK1/YJ+hFeTTGEOf/NQAUDQcYK8ocADTncb 9r1n7XLoQ17IrAgAH83PlsVr0xIEha/TBV3lcSj94MgS8WLootd/PcqX+whxdEkJ pLKL+W7nYLXVpN+jN+fLT1V7qr7HLcrx0ayoR8SVhypm7hGb9Sf9ZlzQ9oeop220 746qOExSY/huqwcRMvFlNYXEuAJTf8AGPYhv0wSx+MzwdImo8MUIKookhgwyWCna tWY7zeqaJUu4MJo/JXdmyelaqJK+bW5S5GCfZ6gE1JxE9vY9RlDeHgAeEH8F9syK fhkF830dJ0INs6/bmkots2oDpaq4gtFX3GktbA2wDdS9B23KuacU+yx6JRbYk9LF 25vFxVFOf9nMnIGefghDJ+tMWqzQWrZd4KlielMxNCzr7UIkUzaA/7NteIFBqBaj tLjSHZlcgCL+RqDunGbusHuYGke0jNe+i9YrWdNcLINlDP+aLdPqStnGH7MeCbFv CbKKEv11BjvFzfpW6+eA3bjEW1wc39sGA2zs198/UOTHocrlAeM= =evNF -----END PGP SIGNATURE----- --=-=-=--