From: Mark H Weaver <mhw@netris.org>
To: Simon Tournier <zimon.toutoune@gmail.com>,
Tobias Geerinckx-Rice <me@tobias.gr>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: The package/inherit trap
Date: Sun, 06 Aug 2023 19:10:21 -0400 [thread overview]
Message-ID: <87h6pbojgn.fsf@netris.org> (raw)
In-Reply-To: <86v8jb8vby.fsf@gmail.com>
Simon Tournier <zimon.toutoune@gmail.com> writes:
> Hi Tobias,
>
> On Tue, 07 Mar 2023 at 22:11, Tobias Geerinckx-Rice <me@tobias.gr> wrote:
>
>> However, merely documenting something is not enough when we have the
>> chance to fix misleading naming, as we do here. It would be nice to
>> have, but orthogonal.
>
> I would not say it is orthogonal because renaming would not have been
> enough, at least for me, in order to get the difference with ’inherit’.
>
> For sure, it is a real trap. :-) For instance,
>
> $ git log --grep='package/inherit' --oneline | grep use
> 5f83dd03a2 gnu: kodi/wayland: Do not use package/inherit.
> 6ecf88a6a1 gnu: poppler-next: Don't use 'package/inherit'.
> 5a5b729d66 gnu: abseil-cpp: Don't use 'package/inherit'.
> dbcf2b61b1 gnu: Fix erroneous uses of 'package/inherit'.
> 2f97a666a5 gnu: python-urllib3: Don't use 'package/inherit' on replacement package.
> 4163b6d855 gnu: avahi: Don't use package/inherit.
>
> and in the light of this discussion, 5f83dd03a2 seems incorrect, no?
I agree that commit 5f83dd03a2 is incorrect. 'kodi/wayland' is quite
clearly a case where 'package/inherit' should be used.
Mark
next prev parent reply other threads:[~2023-08-06 23:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230221130600.18932-1-sharlatanus@gmail.com>
[not found] ` <20230226004406.6215-1-sharlatanus@gmail.com>
[not found] ` <87ilfmhkuh.fsf_-_@gnu.org>
[not found] ` <87lekijcwi.fsf@gmail.com>
[not found] ` <87v8jixg6u.fsf@gnu.org>
[not found] ` <CAJ3okZ1oYVdW6R0x3u-zOGnCoSHa+RmB2w7cwsdwnpKzyXYaww@mail.gmail.com>
[not found] ` <87o7p94yqk.fsf@gmail.com>
2023-03-03 19:21 ` The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) Tobias Geerinckx-Rice
2023-03-04 3:44 ` The package/inherit trap Maxim Cournoyer
2023-03-07 11:46 ` The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) Simon Tournier
2023-03-07 16:43 ` The package/inherit trap Maxim Cournoyer
2023-03-07 17:46 ` Simon Tournier
2023-03-07 22:11 ` Tobias Geerinckx-Rice
2023-03-08 9:07 ` Simon Tournier
2023-07-31 20:17 ` John Kehayias
2023-08-06 23:10 ` Mark H Weaver [this message]
2023-08-07 14:41 ` Maxim Cournoyer
2023-08-10 20:40 ` Mark H Weaver
2023-08-10 21:27 ` Mark H Weaver
2023-09-02 18:46 ` Maxim Cournoyer
2023-08-07 0:00 ` The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) (
2023-08-07 6:29 ` Attila Lendvai
2023-08-07 14:43 ` The package/inherit trap Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6pbojgn.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=me@tobias.gr \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).