From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YP3WAre8+GTF6AAA9RJhRA:P1 (envelope-from ) for ; Wed, 06 Sep 2023 19:53:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YP3WAre8+GTF6AAA9RJhRA (envelope-from ) for ; Wed, 06 Sep 2023 19:53:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 84A3E51005 for ; Wed, 6 Sep 2023 19:53:58 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=b4ENT3PU; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694022839; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hNyaRUDARFGi2TlLrQwPinu9trvDXDXmb5ombS331ho=; b=NlSrq3/wesS5i8AWmx+zc9Gd2JXZyRO9xIqJijUMIQ90Teh6fiiQgcKjlXa8ryORL1oP6o 9mSiax47k4GhVAR4hKZvbLqbCmEpGsBSr+Y8q7/x2HoABr32zqeOZLap3I9xzNCgnMg6Ze cq47bWCLpgYl6WE4t495u3s8BUYryMZU6yXG/9/tXn4P1kP+hGupC44XVmCUtTjiP3EY07 T6G8AcHYFcqVWWYg7+z9FVfZE93dXX4tRp45GepBjUo+O3i0l0MKZH58m6ugWG/VpQqeB/ DDk0czNTNWFphoAK94Kazg81cmGsKWNRO5LyxBKViyIjtd9HXYOF2+oIZxSjqA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694022839; a=rsa-sha256; cv=none; b=HnFTQjqIPEgY9do/5ZJW894QxvzfZNKR5jhKLJ+6nLleobg1psT1D6RDRM3XGRQ9dwz9WM +8cnrauE8IoPA8CowWS+PsozCsqKWBgv/bH9+32k7JWSUHUt4OyLZu7hj/D1ky9OB/cs7/ QpeqApQTAPrzQGNItLpsIyahzaQC6I7gM4uzz+IHFlBdL6a9ZM6RZusIUbmlEq4tJZO7/L 8U0Bxv8dWEDIM7ATpHSIbgkATcSkqK5VFBWgPTa/r+k/gM2vyjjL/ObpoH0hr4U/FQF9/F +tEKHCmwedUZff96Cu2MOLcn6D6Qc6Bbg06VhT+MndnJQ/sw2UfV5TBTxmmpOQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=b4ENT3PU; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdwiB-00067E-Hr; Wed, 06 Sep 2023 13:53:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdwi9-000675-4U for guix-devel@gnu.org; Wed, 06 Sep 2023 13:53:06 -0400 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdwi6-0001Rx-Bh for guix-devel@gnu.org; Wed, 06 Sep 2023 13:53:04 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id E8E3F1AD15; Wed, 6 Sep 2023 10:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1694022772; bh=3sdeUQyvBLeWlexuaoLlksdt9ewBxkPx2S87rvDUYTQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=b4ENT3PU6phKKeF+dMEbDXS6X0aJvepRgnG/WZUXU+x8XndGAj1y4/gzBncDU05UG G7hPpXc7x7xSdsEMeKKtght6rVWAlKVAjNYPRaokFwEybZkCQG2r9LQu0UFtlaYY58 J/uq1ieG69lluiSkimWPdwa52WOmgZX2OOLbEPgxV3aYTGMJkxgXzmw590JGJ5S9zG ChC8YDwprMZJzIU2BGGleDJv7Q9KdX7t2Sa38lTfDANxu7gobv5BWOlECfBO9o56w/ RBvp/fA1oLe5rSgv36dP74isfmeFiH/gm/pOvlbogDvIvtzj1fQ6enyhTYokz5ceV4 MEDxCbIEaRc9Q== From: Vagrant Cascadian To: Liliana Marie Prikler , brian , "(" Cc: Katherine Cox-Buday , Simon Tournier , Maxim Cournoyer , Saku Laesvuori , Attila Lendvai , Andreas Enge , guix-devel@gnu.org Subject: Re: How can we decrease the cognitive overhead for contributors? In-Reply-To: <67115f26712acbb1d83b71f4418c682a5e9762a4.camel@gmail.com> References: <20230827135726.y33t55w4cvq6zsvb@X-kone> <874jkift8v.fsf@gmail.com> <867cp4sj7k.fsf@gmail.com> <38242808-2f06-4674-3842-aea1a5378d05@gmail.com> <87a5u0o3z2.fsf@disroot.org> <87sf7s9oi9.fsf@spork.org> <67115f26712acbb1d83b71f4418c682a5e9762a4.camel@gmail.com> Date: Wed, 06 Sep 2023 10:52:45 -0700 Message-ID: <87h6o7mbo2.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=2600:3c01:e000:267:0:a171:de7:c; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -10.43 X-Spam-Score: -10.43 X-Migadu-Queue-Id: 84A3E51005 X-TUID: nCTmSOLL4VIx --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2023-09-06, Liliana Marie Prikler wrote: > Am Dienstag, dem 05.09.2023 um 19:41 -0400 schrieb brian >> =E2=80=98* foo/bar.scm new-package (inputs): add input=E2=80=99 >>=20 >> stuff. I literally can never remember this format, no matter how many >> times I do it. I'm reasonably sure square brackes go in there some >> where. It can take me quite a while to put together all that stuff, >> even with magit's help. > It's=20 > > * file (variable)[field]{do you need 4 levels?} Honestly, not knowing the difference between a variable and field and selector... this comment is of little help to me. I always get tripped up with phases, modify-phases, etc. as there seem to be potentially four or more levels deep in some common code patterns... for example, a recent commit mentioning phases: commit c14c25b4fb625c2a5b9512618b3eb17ff15f7e71 gnu: go-github-com-tdewolff-minify-v2: Regenerate hash. * gnu/packages/golang.scm (go-github-com-tdewolff-minify-v2)[#:phases]:= Add phase 'regenerate-hash. ... diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 44953d6111..3c486c4121 100644 =2D-- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -3685,11 +3685,24 @@ (define-public go-github-com-tdewolff-minify-v2 "0h006wpfkl0ls0skqxblwcanrhmphgq5q0ii26l2ayh7s99cgmy3")))) (build-system go-build-system) (arguments =2D (list #:import-path "github.com/tdewolff/minify/v2")) + (list #:import-path "github.com/tdewolff/minify/v2" + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'regenerate-hash ... Why is it not more like: * gnu/packages/golang.scm (go-github-com-tdewolff-minify-v2)[arguments][phases][modify-phases]: Add 'regenerate-hash. Honestly, that *seems* ridiculous to me, but I do not understand *why* based on the comment above or other patterns I have observed in the wild. My inclination would be: (go-github-com-tdewolff-minify-v2)[arguments]: Add phase 'regenerate-ha= sh. What goes in the square brackets? How many levels deep? Do I put something in the prose of the comment or in square brackets? For me, all this is only from observing many commits, submitting a few patches, getting some good feedback, but really at the end of the day I am just cargo-culting... I have been submitting patches, and even pushing commits to guix for several years now, and it is still quite unclear to me. I can wing it just fine, and am able to submit imperfect patches and have patience for reviews and suggestions and have the resources to respond (at least, most of the time)... I can see how really not wanting to iterate with N back-and-forth discussions in review could hinder someone with a less flexible schedule, especially if there are no other significant changes to the patch... it could get demotivating. It is obviously tricky, as sometimes people need back-and-forth discussion to learn... though maybe they would rather focus their limited energy learning how to program, a new language (guile), or just learning how guix works in practice. For some people, they might just not have the time or emotional energy and just prefer to keep their changes in their local branch so they can move on to the next thing that actually is motivating their work, tinkering, play, etc. or move on to something else entirely which is more rewarding, such as gardening... This is not to say there is no value in the current commit message format norms. Obviously some people have described the value it has for them... One value may be contextually dependent and sometimes at odds with other values. live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZPi8bQAKCRDcUY/If5cW qqPKAQC6KpUl19YFdvYoCD69NpayzHOg4Hgmc9zpYjzdyIoilAD9HYLhWenkTnA2 dhEJCXfhWCnwor+t1uMJkw1yD0GEOgM= =/OMD -----END PGP SIGNATURE----- --=-=-=--