From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GGWdFz+v+WTi8AAAG6o9tA:P1 (envelope-from ) for ; Thu, 07 Sep 2023 13:08:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GGWdFz+v+WTi8AAAG6o9tA (envelope-from ) for ; Thu, 07 Sep 2023 13:08:47 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 50F8045433 for ; Thu, 7 Sep 2023 13:08:47 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694084927; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=ekFhXudKvneUeaJvNR23vJEiMQVYvnmwJcw1a+Yihcg=; b=EXLLDR4EAH3gSYNs2mT4NgsE/guDP7BxgGB0d78fAFxGxU2xROWfY+PA6lp3TjBCX6Q+hY DscCD57ZxBxLamoyNXcX3KXnmZJxyWzlEW0dN273x89Z8Bb6kNlvykAmxIkknLQG2IzEwM YVTM9rg0s2L+njBId1crT4ElBnK6SHUlBI6dXw9riMFE6skd7o3h7XMMIIWQ8zvHrebtJ8 JzkBHPr6xKTwFVxAqAPWQBOpYU6lxjYWeCgCR1Niq8UdKgKpcn0DxmpvNDRXPxWmO8LbLn EPLzAzt0Rp3VvX4grm/6TSIpvdP95+SmfrPanhnezLKKu/bOPiq9Aa4UpcxNSw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694084927; a=rsa-sha256; cv=none; b=BWyVL3FHIpHc7dzqwzTPl4LSWqkzjLaRDzhBAv5YrKWnQGfCVO57Gh3zdHS5YJWPeAwYPA 0Ki1P7WEyYUgKswnCYxOayTZBxTmT+EcV7lOvtRQ/2MQ8SkHQLk1M+Emq8XTKM2h9xPwnI dfIElTdziMTsb5rL2EXwHWcDa7ls1MxcWZpJq4kWKvit1lmnGAp0k88jewxt7Aw0VbX9vD 0AuAHQTfPNwTeXdsR/YNhywUicwox7vwLSM+uGnCbgXMJG/wXAsgYB2MYlTs6C1jSF3pa2 dr3Cv7CQDJdV+WF6pwLAThagwprR7w35NBJrbi57e2kONvqb/ZNguhvwVUokhA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeCru-0002Mu-GR; Thu, 07 Sep 2023 07:08:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeCrs-0002MJ-Vu for guix-devel@gnu.org; Thu, 07 Sep 2023 07:08:12 -0400 Received: from ns13.heimat.it ([46.4.214.66]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeCrn-0004NR-Jo for guix-devel@gnu.org; Thu, 07 Sep 2023 07:08:09 -0400 Received: from localhost (ip6-localhost [127.0.0.1]) by ns13.heimat.it (Postfix) with ESMTP id 6FD6F30085C; Thu, 7 Sep 2023 11:08:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at ns13.heimat.it Received: from ns13.heimat.it ([127.0.0.1]) by localhost (ns13.heimat.it [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VA7h5kIdB-nI; Thu, 7 Sep 2023 11:08:01 +0000 (UTC) Received: from bourrache.mug.xelera.it (unknown [93.56.171.217]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ns13.heimat.it (Postfix) with ESMTPSA id CF54A30080B; Thu, 7 Sep 2023 11:08:01 +0000 (UTC) Received: from roquette.mug.biscuolo.net (roquette [10.38.2.14]) by bourrache.mug.xelera.it (Postfix) with SMTP id 6701B298D1FE; Thu, 7 Sep 2023 13:08:01 +0200 (CEST) Received: (nullmailer pid 4142 invoked by uid 1000); Thu, 07 Sep 2023 11:08:00 -0000 From: Giovanni Biscuolo To: Simon Tournier Cc: guix-devel@gnu.org, Maxim Cournoyer Subject: Re: [workflow] Automatically close bug report when a patch is committed In-Reply-To: <86o7ien856.fsf@gmail.com> Organization: Xelera.eu References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <86o7ien856.fsf@gmail.com> Date: Thu, 07 Sep 2023 13:08:00 +0200 Message-ID: <87h6o6fdgv.fsf@xelera.eu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=46.4.214.66; envelope-from=g@xelera.eu; helo=ns13.heimat.it X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 50F8045433 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -8.33 X-Spam-Score: -8.33 X-TUID: ljvfjZCjc6BZ --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Simon, Simon Tournier writes: > On Wed, 06 Sep 2023 at 12:14, Maxim Cournoyer = wrote: > >>> Let's avoid manual gardening as much as possible! :-) >> >> I like the idea! > > I think that automatizing is not trivial. Sadly. If we "restrict" the automation to "close the bugs that are listed in the commit message" do you think it's doable? [...] > The potential issue is the number of false-positive; In the context given above, the only way to have a false positive is that the committer give a wrong bug number, right? > closing and the submission is not applied. I don't understand: what do you mean by "submission"? By design: =2D-8<---------------cut here---------------start------------->8--- The post-receive hook runs after the entire process is completed and can be= used to update other services or notify users. =2D-8<---------------cut here---------------end--------------->8--- (https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks) In this case the "other service update" is "close bug " and is guaranteed to be done after the commit is applied. > Maybe patchwork already running (I think) could help, trying to > regularly rebase the branch dedicated to the submission on the top of > master, then if all is fine, somehow the two heads from the master > branch and the dedicated branch should match, and it would indicate the > patches are included and it is safe to close. More or less. :-) I'm lost :-D > That=E2=80=99s said, I always find annoying to loose the track between th= e Git > history and the discussion that happened in the tracker. Sometimes, > rational of some details of the implementation had been discussed in the > tracker and it is impossible to find then back. Therefore, I would be > in favor to add =E2=80=99Close #1234=E2=80=99 in the commit message, say = the first one > from the series tracked by #1234. Doing so, it would ease automatic > management of guix-patches. However, it would add again some burden on > committer shoulder. I completely agree that (often, seldom?) we miss traceability if we do not link a commit with a bug report (when present) and vice versa (when a bug report is resolved by a series of commit) > Similarly, we are already adding in the commit message something like > =E2=80=99Fixes =E2=80=99. Is this an informal convention or is this documented somewhere? > And that could be used for closing. Yes, we can use al list of keywords for closing (Closes, Close, Fix, Fixes, etc.), but for the bug report I'd use only a number, the URL really does not matter > Again, the concern is about false-positive; closing when it should not > be. Modulo a programming error in the script, the only way would be to write the wrong bug number after the "keyword" and IMO this is similar write the wrong bug number in the "To:" field when closing a bug via email. > Well, I think that automatizing is not trivial. :-) Not trivial but automatable, IMO :-D Thanks! Gio' =2D-=20 Giovanni Biscuolo Xelera IT Infrastructures --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJABAEBCgAqFiEERcxjuFJYydVfNLI5030Op87MORIFAmT5rxAMHGdAeGVsZXJh LmV1AAoJENN9DqfOzDkSldcP/2Vxb/d4qdWLwacqhl8VFzYlwX1JdmLRcTM5VMBH ZjdXVmvaxzIJrU1z3e6Q1KDGNrkoHg6p/yBb0eUrEpa66ECu5Sw/VB1Yc5IjdHoa cjwaEieIu6vrr/eAJvLA1D+5BKTOGDaWoXNh0OmHAUGv5MqK8Mtzi2Pu3XydGr+7 yP7ziCJDe7RBiGOV/9028izEzp55VWxVicx6StYvIOlaqlPEJqv3KJ3hltDl+cQE 9JJP39UElJ8cK3DMNd9Q/bK20qieWh91f0nKW+iUla/fl9DPrbC7O7zVYEDVu/N0 qmMEFq3SMZbty1dVug2V3ApCzfoQF9yz2a9lAhbZ9V0QyW+2B7k62OhE8tnJbhpk 4mRiJMvctyGeGoYrCgCtaI0KNoW91uc1SVIApPPvGyDmTu85FG1Y+NE2r24hW0Hy Ctm9nIA+d3KtHivcV+L7MLa2Gc93gvZn45iayeyE2UQy+RuPjPIsY906IOO2ykTK 2oZ3T7y4DX94L9OZzHn1Qz+IaLiYbhBVjTNags07T042NE+nZLcWjrEXIAFcEAph qvnh5DjBoG7kwduXVMP+tuSQJFVuUimdvQV2QrGA+vIxleu6eJM9HalBLzMbNXVG eERJaD3sFk0dtlCQKQIIDyF7/p9gNFaHeaZqkM+rxcXyE8ouzEHIg0GS+pMbF5Ih dF9M =VLll -----END PGP SIGNATURE----- --=-=-=--