From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id KDhXJSbVAWWQmAAA9RJhRA:P1 (envelope-from ) for ; Wed, 13 Sep 2023 17:28:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KDhXJSbVAWWQmAAA9RJhRA (envelope-from ) for ; Wed, 13 Sep 2023 17:28:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 30A354426F for ; Wed, 13 Sep 2023 17:28:38 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=RFuk5DQH; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694618918; a=rsa-sha256; cv=none; b=bSqf6KTBVl0322L/SnhBT5X3hLG2HLQvxgw9t0roLw/WCsohMesEV4VaNeiptcat/prHRh DdCZaS0gczI3pQ0Kuzv2YCbBzAnMJvexapAqeUKJpHkqCAnx7pLxHA4Uh2LJlH/pe6SM6j Qz+1+jr/2wA84uTOJCRTHcwiF3fwSLVM80reC2+467TvrPvVXddqOaombObJ5nP79lbkGj 0zUXxy63ExOaKKigvTrVa6wT9JvBYwfEsLo1uDzrTKoTY3SH6GnNJ89FJ9TdMXeaaA0ZdQ N89s8TNz1SC2nhQfZwvExPG74lKcKlFpp22ZFedAmqROo84vbZ5DETeWSAerXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694618918; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=dkxapJJQRZYBdrCgtfl7v3R1SJbXf7RvEp2ymzEsozk=; b=YeM8n19elB76lJ6g+/m1DK7nrHqe9VDTwAKtfpVs/fXm6B3vbG6hC4ry46JPEbPwGXWadx 89nb5/7+2d7atRWHADpx7FUhefk2ICzDMtI3tQbBDS/GCJMG7LuR4FGC67IyVWinv3CO0J eOeL2vqG9sn5VedyNGsKRH40FyMBQ97mm0Q30DbK7yxVmlQ3D2fyzsECHuZ6o3jIEtK/5B stK83PqPRmE6MnaSDQ61XG8gUaXcw9WjotzftkgBOCXzcvTDYWR5pYgfZYPX9TkZlpamxd Q/sBjCvH9HScNgl/RipiRJfauy9/KB9JeDIh4J9hA9wWErqD08Y0FpabbPQ7Ag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=RFuk5DQH; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgRmU-0000KC-RR; Wed, 13 Sep 2023 11:27:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgRmS-0000JQ-M9 for guix-devel@gnu.org; Wed, 13 Sep 2023 11:27:52 -0400 Received: from mail-qv1-xf2c.google.com ([2607:f8b0:4864:20::f2c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgRmQ-00026o-3B; Wed, 13 Sep 2023 11:27:52 -0400 Received: by mail-qv1-xf2c.google.com with SMTP id 6a1803df08f44-64914f08c65so42793306d6.1; Wed, 13 Sep 2023 08:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694618867; x=1695223667; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=dkxapJJQRZYBdrCgtfl7v3R1SJbXf7RvEp2ymzEsozk=; b=RFuk5DQHo4d64QxYMxGS87Kmh8NiH4xTLBlgby+/qghni1kT6dQDGTnPT/itAcYBn5 JqBiFPnP27oXAn0RX6uGWMGXeEXBJYKFTA13iqSC3e2T2Ydlc0jHWopeStKFYm+sJaT/ 8ldG5JJ15qq+DaY0CgnQt6k4SBvzDSiT1YfuJGJOUH44A4PvpvM4vfDUT5/7whsxRYcX bLaBw7vVdourWT3xaf5zD/r5L6SenUYp3+rOoFsQ8Yi8D38c5YYXWCC3/PKyh3I4JmHr 6whjxojIzVVvattmWPAuviYJJ18MzNW7ttaeEQmxyD7352GmtoxBqNvc6p7wtAMThw0m QjEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694618867; x=1695223667; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dkxapJJQRZYBdrCgtfl7v3R1SJbXf7RvEp2ymzEsozk=; b=FYXXKzj0SZ0ixHDESnKeEN0bnJg1qKeDXCYls3f5912MNbnGvLkUfnelQNrH67YJrz J4FPXwkyjoEe9I4RjfQEm2itdO1J1MdGOBcjI89RhfW5w3cgyUS2TtyVzQnOhXYsm2n8 4kmGSVXwpdNduuXHvrLJWNraIaRjGRl2LvVQ2dxTnGs8ddRR4lnYhPZaaVPGWH1Tt83H crpwDNAEk/vBWR5c5GeOjwfOw4ozMh+mHt5pP47gjpx3OGT3kMGWW1kl4BC7ISDiVk4C oijvKKwIpmvo9sX86H9xVHw/ivUCfaP4RccHfLsYnvigDjWkP4iTO4EP+N2jtEXzIl6/ WXSw== X-Gm-Message-State: AOJu0YywBvLSkc3hhPi0gPvoRsV1mn+qZHHGym6asVTUtRs/ITp/6WHD /n6nxm0GInYtQJAw7+S4+MfidfpxQM0= X-Google-Smtp-Source: AGHT+IFq5a1sjhzifXfBtwyniverLNrN99LNOD9XTxFcXkDUWUYaTcmKoLcx74YbMKCWiStxegFq6Q== X-Received: by 2002:a05:6214:29cc:b0:64f:91c2:8440 with SMTP id gh12-20020a05621429cc00b0064f91c28440mr2248095qvb.59.1694618867255; Wed, 13 Sep 2023 08:27:47 -0700 (PDT) Received: from hurd (dsl-149-165.b2b2c.ca. [66.158.149.165]) by smtp.gmail.com with ESMTPSA id y8-20020a0ce048000000b0063d0159e1f6sm4445073qvk.109.2023.09.13.08.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 08:27:46 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Cc: Giovanni Biscuolo , Vagrant Cascadian , guix-devel@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8?= =?utf-8?Q?s?= Subject: Re: [workflow] Automatically close bug report when a patch is committed References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <87jzt2feq6.fsf@xelera.eu> <87y1hikln6.fsf@wireframe> <2d93b48dfd381c55ff706394ff7226133f5e014a.camel@gmail.com> <87pm2pces0.fsf@xelera.eu> <87bke8wo96.fsf@gmail.com> <929b035f6f4aca0793d9f8a6454b673b2a7069c1.camel@gmail.com> <87zg1sv3vt.fsf@gmail.com> <6929416953b2939445a5247b014142ea8bb521d9.camel@gmail.com> Date: Wed, 13 Sep 2023 11:27:45 -0400 In-Reply-To: <6929416953b2939445a5247b014142ea8bb521d9.camel@gmail.com> (Liliana Marie Prikler's message of "Tue, 12 Sep 2023 19:03:20 +0200") Message-ID: <87h6nyw0su.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f2c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.05 X-Spam-Score: -5.05 X-Migadu-Queue-Id: 30A354426F X-Migadu-Scanner: mx2.migadu.com X-TUID: s0zV3QFC8Z1a Hi Liliana, Liliana Marie Prikler writes: > Hi Maxim, > > Am Montag, dem 11.09.2023 um 16:41 -0400 schrieb Maxim Cournoyer: >> [...] >> Perhaps both approach[es] could be combined.=C2=A0 I still see value in a >> general scheme to automate closing applied series that linger on in >> Debbugs. >>=20 >> [0]=C2=A0 >> https://lists.gnu.org/archive/html/guix-devel/2023-09/msg00138.html >>=20 >> Change-Ids would also add the benefit that any commit found in Git >> could easily be traced back to their submission on the guix-patches >> or guix trackers or vice-versa (git log --grep=3D'Change-Id=3DXXXX'), as >> noted by Giovanni. > The thing is, we're discussing the same basic workflow (which you lay > out below), just different kinds of metadata that we'd have to attach > to our commits. IIUC ChangeIds need to actually be carried around by > the committers as they e.g. rewrite patches (rebasing, squashing, what > have you), and they're basically opaque hashes so I don't see the > benefit to the reader. (I think you might be arguing that the benefit > is uniqueness, but I'm not sure if I ought to buy that.) Correct; the Change-Ids must be preserved when rebasing ((*if* they were already published -- otherwise it doesn't matter)), and for the human reader they're mostly noise. Since it can be automated though, from the day it's added all the commits would have one and they would become a valuable unique key to cross-reference between what's in master and what was reviewed in guix-patches, for example. > Meanwhile "Fixes: [whatever notation]" also needs to carried around, > sure, but at the same time provides semantics by pointing to a (known) > bug report. Now again, I personally prefer cool URLs here, but that's > a bike we can shed however we want. That's nice, and as I wrote in my previous reply to Giovanni, I think both schemes have their place. >> The process could go like this: >>=20 >> 1. commits of a series pushed to master >> 2. Savannah sends datagram to a remote machine to trigger the >> post-commit job, with the newly pushed commits 'Change-Id' values (a >> list of them). >> 3. The remote machine runs something like 'mumi close-issues [change- >> id-1 change-id-2 ...]' > Yeah, I think we basically agree on the 1 and 2 here, but I don't think > we have to really implement 3. IMHO we could do something simpler for > all parties by just carrying the bug number around (in whichever form), > which we do for some of our pre-ChangeLog explanations already. For just closing cross-referenced bugs, I agree. For closing forgotten, already merged issues on guix-patches we'd need the Change-Id and a tool able to map Change-Ids -> issue number (mumi is in the best place to do so). It's been a hard discussion to follow, but I think we're coming to some understanding that we are discussing two different schemes that could be both implemented to provide different benefits, right? --=20 Thanks, Maxim