From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8NoDImaCIWV8PgEAauVa8A:P1 (envelope-from ) for ; Sat, 07 Oct 2023 18:08:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8NoDImaCIWV8PgEAauVa8A (envelope-from ) for ; Sat, 07 Oct 2023 18:08:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5D19F410CE for ; Sat, 7 Oct 2023 18:08:06 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iEUIC3aA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696694886; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+ab0MWzWcyiltKKnGVFtPW3qSjhmMH4+caY+ToxP98U=; b=lLP6pa73f87mC/fY9E7xtM7bul/Wx1ZthZtuhLaPszjEeIC7cW3zX8qjUfUUpHSLs+TGzK Zgvmt6NCwA+u64U0VmpVpMURbv7HzU/sn0YqVHcTKUsyvYCUhmmrHKcqpPTrxzWQjLcZgq Ajv4oassi8NhvrYBeUkSsLlvw68OIbXhFJAe/xYyBIX87uG7B20fjmj2xUzz2bjsN4nJ4l irVQLNOuD/ej2xE3aL+pS/8Ch5AtBbZ1bcmHHx5IO1R/QMziWpZkE4x3yBCX5plKuU35Lt DD+UrBUdhOeSfWLnDxF+njmsAc9b5XMOrEqkn1d289kaS10J0UK4Ki8ayWe9Mg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iEUIC3aA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696694886; a=rsa-sha256; cv=none; b=BxD20V3IaA0uBUa7MtHAb039hWwof2JoFa0YGT/lS+p7LClb+1ildkCIRIz5HlgofslOM5 4qJQHLI6wm0Yb7hHemXcWRc67ULHmBhlotsYVhipIkjlANl6YKvx8qicxu4H/jpxHBpMUk c0f7oU7tW3vI/57l0IYRAPEieWVYwCXCOGFGgXRT4iENdPRza96Y/qCw1zdlVLV7EggXiu 5O9xb5VD1Zlnn7jRvTzJklWZLbkkpcxIhT8LqOpMf919bmNZEYWUHvumrkvayKZl1ogrMB 1E1Od7G95zwF0hwrNER+DNPwk2++gpJd1F6FoTfpN3LrDBsGkMFe/HfHxYBDzQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qp9qH-0004V6-FL; Sat, 07 Oct 2023 12:07:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qp9qG-0004UU-Dv for guix-devel@gnu.org; Sat, 07 Oct 2023 12:07:48 -0400 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qp9qE-0002bQ-Va for guix-devel@gnu.org; Sat, 07 Oct 2023 12:07:48 -0400 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6c6504c9ac5so2137126a34.0 for ; Sat, 07 Oct 2023 09:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696694865; x=1697299665; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+ab0MWzWcyiltKKnGVFtPW3qSjhmMH4+caY+ToxP98U=; b=iEUIC3aAo0UR5sdI6JCDh8BKOAu9tLHlrMm2LPlXZSzhR1rdLOl5XxPqCdVmfSusfM AmRj33KHW1aOpsg1URBJjYt0CxwxICVtbR6InnSBKxeDTSnrTAAGlhIV81lz7R0HiJ3T m4axAulURbwy5OScWCDdGVmjap4WU6rPyImzKIwQWDkC/1RDsdyrVfcORZYC1LKu+aJh kdcB0YlfuR3ksV/cBI601VUpuWTS7eRqL2el8Bq9MB5nLa9s/J2vVEg94CPs7yoqB34M u91w2dJ8BFzzoFP539HpzGBa44Ahz/PTIBJOigkiFIGL4CcOMeW02d6KiZeUslfrOMG5 K58g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696694865; x=1697299665; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+ab0MWzWcyiltKKnGVFtPW3qSjhmMH4+caY+ToxP98U=; b=te6nOTCxzt8TW4nRkZblGwa2jYJH/h+VctbSTf3s+lLVH8wunqLsiLS3Hxm4laN6IA KthechGGskOwVMA51Rz3GqqknQKgsfWj6mso6reeyEiC21kl6QzyG0/nkDm4MDIxK3/H 2Fyjxf/hXof3j1c6nCvzqkenkqJCqOOY6k74N2Mnx7EQK/X0drQHHQEAob0IIWXJz9mQ 2jDQ5/K8e73UW9nbGBYi+IY+6EJPDArpuIE1Y7kKJdTd2OA1axyONzsdbJAayVBs8wEK Q8uRh/tJ0sQBgmBpwjqVDQey5myNNUIpuqHyBvjNlYCyK9+OeOvxqrlPVnbMG/1KrhzX o/Jw== X-Gm-Message-State: AOJu0YyO4lryFQ5v5/Hu6oeZvnFQNy8LGh5zQsDvdysU7VQMOm3Oo4FD 9axXz1wnCmk8UjEDw+bBv0ZoCNo90gE= X-Google-Smtp-Source: AGHT+IG38VhnH3rulQlBJqlwhG9XHkNt9+hcCo2b9VGI7SMhGVkx+pIKA61V+tM0YkiqpRtbvSKLhA== X-Received: by 2002:a05:6870:b48c:b0:1d0:f067:bf23 with SMTP id y12-20020a056870b48c00b001d0f067bf23mr13369615oap.25.1696694865555; Sat, 07 Oct 2023 09:07:45 -0700 (PDT) Received: from hurd (dsl-158-21.b2b2c.ca. [66.158.158.21]) by smtp.gmail.com with ESMTPSA id u19-20020a0cf1d3000000b0064f57d3100asm2267062qvl.102.2023.10.07.09.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 09:07:45 -0700 (PDT) From: Maxim Cournoyer To: Munyoki Kilyungi Cc: jgart , guix-devel@gnu.org Subject: Re: IDEA: missing-tests-pypi-error? condition In-Reply-To: <87jzrzyevp.fsf@saitama.mail-host-address-is-not-set> (Munyoki Kilyungi's message of "Fri, 06 Oct 2023 18:00:58 +0300") References: <41cf39960ed499205b21e677c872a29f@dismail.de> <87v8bkxgl3.fsf@saitama.mail-host-address-is-not-set> <87o7hbkind.fsf@gmail.com> <87jzrzyevp.fsf@saitama.mail-host-address-is-not-set> Date: Sat, 07 Oct 2023 12:07:44 -0400 Message-ID: <87h6n2iffz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::32f; envelope-from=maxim.cournoyer@gmail.com; helo=mail-ot1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.47 X-Spam-Score: -9.47 X-Migadu-Queue-Id: 5D19F410CE X-Migadu-Scanner: mx2.migadu.com X-TUID: bSr4KB0Z8Egj Hi, Munyoki Kilyungi writes: > Hi Maxim! > > Maxim Cournoyer > aliandika: > >> Hi, >> >> Munyoki Kilyungi writes: >> >>> "jgart" aliandika: >>> >>>> Hi Guixers, >>>> >>>> I was recently reviewing a patch by a contributor and was discussing the notion of preferring upstream to PyPI when tests are missing on PyPI. >>>> >>> What's the policy on this. Shouldn't we prefer >>> upstream over PyPI? Sometimes, PyPI versions lag >>> behind upstream versions. >> >> There's no written policy about it at this time, but I think it's common >> knowledge in Guix that we try hard to: >> >> 1. Unbundle dependencies (that one is documented) >> 2. Run test suites (that one isn't) >> >> We could hint at this globally in the contributing section, and perhaps >> expound with more specific details in the Python Modules contributing >> section, mentioning that when the PyPI source archive lacks tests, >> fetching from the git repository should be preferred. >> >> Another thing we could do is default to fetch from git for the Python >> importer. >> > Thanks for this info. I'm dedicating an hour of > my day from work to try to contrib to the > eco-system with Jgarte's help. What's, if I may > naively ask, the process for documenting this > knowledge? I can take a stub at trying to > document this and asking for reviews. That's a pretty cool workplace you've got :-). The process would be the same as for authoring any other changes to Guix. You'll want to 'make doc/guix.info' to test your changes (or just 'make'), and you can review the new work with 'info doc/guix.info'. 'info Texinfo' can be used as a handy reference for the Texinfo specifics. -- Thanks, Maxim