unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Felix Lechner via "Development of GNU Guix and the GNU System distribution." <guix-devel@gnu.org>
To: guix-devel@gnu.org
Subject: Type of 'os' in gnu/system.scm
Date: Mon, 11 Dec 2023 16:19:59 -0800	[thread overview]
Message-ID: <87h6kob7bk.fsf@lease-up.com> (raw)

Hi,

Looking at this definition in gnu/system.scm [1] I am trying to figure
out what 'os' is:

  (define* (operating-system-kernel-arguments
            os root-device #:key (version %boot-parameters-version))
    "Return all the kernel arguments, including the ones not specified directly
  by the user.  VERSION should match that of the target <boot-parameters> record
  object that will contain the kernel parameters."
    (append (bootable-kernel-arguments os root-device version)
            (operating-system-user-kernel-arguments os)))

The same file also contains a record definition for <operating-system>
so it seemed reasonable to assume that 'os' referred to such a
record. In fact, the second procedure inside the 'append' above,
operating-system-user-kernel-arguments, is one of the accessors [2]
(even though the name does not match the field).

In the first procedure bootable-kernel-arguments [3] however, 'os'
(which is called 'system' there) is used like a string, although inside
a gexp:

  (define* (bootable-kernel-arguments system root-device version)
    "Return a list of kernel arguments (gexps) to boot SYSTEM from ROOT-DEVICE.
  VERSION is the target version of the boot-parameters record."
    ;; If the version is newer than 0, we use the new style initrd parameter
    ;; names, otherwise we use the legacy ones.  This is to maintain backward
    ;; compatibility when producing bootloader configurations for older
    ;; generations.
    (define version>0? (> version 0))
    (list (string-append (if version>0? "root=" "--root=")
                         ;; Note: Always use the DCE format because that's what
                         ;; (gnu build linux-boot) expects for the 'root'
                         ;; kernel command-line option.
                         (file-system-device->string root-device
                                                     #:uuid-type 'dce))
          #~(string-append (if #$version>0? "gnu.system=" "--system=") #$system)
          #~(string-append (if #$version>0? "gnu.load=" "--load=")
                           #$system "/boot")))

I know objects in the store become paths when unquoted via '#$'. Does
that also work for Guix records declared via define-record-type* [4]
(please note the asterisk)? Thanks!

Kind regards
Felix

[1] https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/system.scm#n319
[2] https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/system.scm#n231
[3] https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/system.scm#n207
[4] https://git.savannah.gnu.org/cgit/guix.git/tree/guix/records.scm#n282


             reply	other threads:[~2023-12-12  0:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12  0:19 Felix Lechner via Development of GNU Guix and the GNU System distribution. [this message]
2023-12-12  7:44 ` Type of 'os' in gnu/system.scm Saku Laesvuori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6kob7bk.fsf@lease-up.com \
    --to=guix-devel@gnu.org \
    --cc=felix.lechner@lease-up.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).