From: "Ludovic Courtès" <ludo@gnu.org>
To: Felix Lechner <felix.lechner@lease-up.com>
Cc: Attila Lendvai <attila@lendvai.name>, Maya <maya@zenmaya.xyz>,
guix-devel@gnu.org
Subject: Re: Shepherd calendar event bug
Date: Wed, 21 Aug 2024 19:30:53 +0200 [thread overview]
Message-ID: <87h6bdrdf6.fsf@gnu.org> (raw)
In-Reply-To: <871q2o9t8d.fsf@lease-up.com> (Felix Lechner's message of "Fri, 16 Aug 2024 12:13:06 -0700")
Hi,
Felix Lechner <felix.lechner@lease-up.com> skribis:
> It would be the first Sunday in each month.
Oh right. Now fixed!
https://git.savannah.gnu.org/cgit/shepherd.git/commit/?h=devel&id=71ef394a38f1d78eada901cb4c111c7b2be84ab5
(Along with related issues.)
> Also, here are some brief code questions, if you would be so kind to
> entertain them:
>
> Why are the ranges for minutes here [1] 0..60 instead of 0..59, and 0..7
> for days-of-week instead of 0..6, please? Even if the intervals were to
> exclude an end point [2] they seem inconsistent with 1..12 for the
> months or 1..31 for days-of-month. Also, should the interval for the
> hours be 0..23 instead of 0..60?
> [1] https://git.savannah.gnu.org/cgit/shepherd.git/tree/modules/shepherd/service/timer.scm?h=devel#n440
This code describes a count and a minimum value, rather than an actual
range: 60 minutes and starting from 0, 12 months and starting from 1,
etc.
Thanks for your feedback!
Ludo’.
next prev parent reply other threads:[~2024-08-21 17:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 13:27 Debugging failing shepherd startup maya
2024-06-21 20:32 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-06-27 13:07 ` Ludovic Courtès
2024-06-27 17:22 ` Maya
2024-06-28 15:17 ` Reproducer for " Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-06-28 16:43 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-07-02 13:03 ` Attila Lendvai
2024-07-02 13:11 ` Attila Lendvai
2024-08-12 22:43 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-08-13 13:46 ` Shepherd calendar event bug Ludovic Courtès
2024-08-16 19:13 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-08-21 17:30 ` Ludovic Courtès [this message]
2024-08-23 16:38 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-09-16 13:27 ` Reproducer for failing shepherd startup Attila Lendvai
2024-09-17 1:11 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6bdrdf6.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=attila@lendvai.name \
--cc=felix.lechner@lease-up.com \
--cc=guix-devel@gnu.org \
--cc=maya@zenmaya.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).