unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Bodertz <bodertz@gmail.com>
To: guix-devel@gnu.org
Subject: Re: How to remove output from inherited package?
Date: Thu, 26 Dec 2024 21:52:42 -0700	[thread overview]
Message-ID: <87h66p917p.fsf@gmail.com> (raw)
In-Reply-To: 87jzblevc0.fsf@envs.net

宋文武 via "Development of GNU Guix and the GNU System distribution."
<guix-devel@gnu.org> writes:

> I think you should not reuse phases from transmisison, the error came
> from '#$phases', which has reference to 'gui' output.  so:
>
>   ...
>   (inherit transmission)
>   (name "transmission-qt")
>   (outputs '("out")
>   (arguments
>     (list ...))   ; instead of 'substitute-keyword-arguments'
>   ...

Hmm, you appear to be right, but I don't understand why, as I removed
the tests that referenced the :gui output: 'move-gui, 'glib-or-gtk-wrap,
and 'wrap-program.

Do you understand it?  Did I miss one?

When I try to build without using any of the inherited phases, a test
fails (the transmission package included a phase to remove that test),
so for now I'm building without tests:

    (define-public transmission-qt-without-arguments
      (package
        (inherit transmission)
        (outputs '("out"))
        (name "transmission-qt-without-arguments")
        (arguments
         (list))
        (inputs (modify-inputs (package-inputs transmission)
                  (delete "gtkmm")
                  (append qtbase qttools qtsvg)))))


    ~ guix build transmission-qt-without-arguments --without-tests=transmission-qt-without-arguments
    successfully built /gnu/store/i78ffafvchfn886b17s5vdwjqs387f98-transmission-qt-without-arguments-4.0.6.drv

Will I have to manually add back the phase that deals with removing that
test?  I was hoping to avoid that sort of thing by inheriting from
transmission in the first place...

Thanks.



  reply	other threads:[~2024-12-27  4:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26  3:10 How to remove output from inherited package? Bodertz
2024-12-27  2:03 ` 宋文武 via Development of GNU Guix and the GNU System distribution.
2024-12-27  4:52   ` Bodertz [this message]
2024-12-27  6:55     ` Bodertz
2024-12-27  7:34     ` 宋文武 via Development of GNU Guix and the GNU System distribution.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h66p917p.fsf@gmail.com \
    --to=bodertz@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).