From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Problem with (patches) Date: Sat, 12 Apr 2014 11:57:29 +0200 Message-ID: <87fvli50qe.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYugq-0005Aq-Nn for Guix-devel@gnu.org; Sat, 12 Apr 2014 05:57:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYugm-0005KN-8a for Guix-devel@gnu.org; Sat, 12 Apr 2014 05:57:36 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:53124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYugl-0005Jo-Rz for Guix-devel@gnu.org; Sat, 12 Apr 2014 05:57:32 -0400 In-Reply-To: (Manolis Ragkousis's message of "Fri, 11 Apr 2014 23:50:33 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Manolis Ragkousis Cc: Guix-devel@gnu.org --=-=-= Content-Type: text/plain Manolis Ragkousis skribis: > In this part of my code >> (source (origin >> (method git-fetch) >> (uri (git-reference >> (url "git://git.savannah.gnu.org/hurd/hurd") >> (commit "e77f00db5097d741f27c74c03d194a233f648615"))) >> (sha256 >> (base32 >> "010q5wy88gaw4qfv2vl9pxfma9px8gs6v03ahqksq420v003b6r1")) >> (patches (list (search-patch "minimal-hurd.patch"))))) > > as long as I have (patches..) in there I get the error here > > http://paste.lisp.org/display/142007/raw (Please always put things inline.) --8<---------------cut here---------------start------------->8--- 549: 5 [expand-input # # # ...] 512: 4 [cache # "x86_64-linux" #] 602: 3 [thunk] 320: 2 [patch-and-repack # # # ...] In ice-9/boot-9.scm: 357: 1 [string-every # #f 0 #] In unknown file: ?: 0 [string-length #f] --8<---------------cut here---------------end--------------->8--- I believe this is fixed with: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/packages.scm b/guix/packages.scm index 812d6bb..fa93cee 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -317,7 +317,8 @@ IMPORTED-MODULES specify modules to use/import for use by SNIPPET." (define (numeric-extension? file-name) ;; Return true if FILE-NAME ends with digits. - (string-every char-set:hex-digit (file-extension file-name))) + (and=> (file-extension file-name) + (string-every char-set:hex-digit <>))) (define (tarxz-name file-name) ;; Return a '.tar.xz' file name based on FILE-NAME. --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Can you confirm? In addition, you may want to add a =E2=80=98file-name=E2=80=99 field, so th= at the checkout has a name more descriptive than =E2=80=98git-checkout=E2=80=99, a= s is done for libwebsockets: (package (name "libwebsockets") (version "1.2") (source (origin ;; The project does not publish tarballs, so we have to take ;; things from Git. (method git-fetch) (uri (git-reference (url "git://git.libwebsockets.org/libwebsockets") (commit (string-append "v" version "-chrome26-firefox18")))) (sha256 (base32 "1293hbz8qj4p27m1qjf8dn97r10xjyiwdpq491m87zi025s558cl")) (file-name (string-append name "-" version)))) ;; <--- here HTH! Ludo=E2=80=99. --=-=-=--