From: ludo@gnu.org (Ludovic Courtès)
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>
Subject: Re: [PATCH] gnu: Add xboing
Date: Mon, 13 Oct 2014 15:54:50 +0200 [thread overview]
Message-ID: <87fvescbx1.fsf@gnu.org> (raw)
In-Reply-To: <20141013124302.GA11097@jocasta.intra> (John Darrington's message of "Mon, 13 Oct 2014 14:43:03 +0200")
John Darrington <john@darrington.wattle.id.au> skribis:
> On Mon, Oct 13, 2014 at 02:27:48PM +0200, Ludovic Court??s wrote:
> John Darrington <jmd@gnu.org> skribis:
>
> > * gnu/packages/games.scm (xboing): New variable.
>
> [...]
>
> > + (inputs `(("libx11" ,libx11)
> > + ("libxext" ,libxext)
> > + ("libxpm" ,libxpm)))
> > + (native-inputs `(("imake" ,imake)
> > + ("inetutils" ,inetutils)
> > + ("makedepend" ,makedepend)))
>
> Please align opening parenthesis and use only spaces, no tabs (for Emacs
> 23 and later, .dir-locals.el normally sets it up.)
>
> This was formatted by emacs using indent-region. Shouldn't that do the job?
> loading .dir-locals.el results in an error for me.
Emacs 23+ loads it automatically. Otherwise, drop:
(setq indent-tabs-mode nil)
somewhere in ~/.emacs.
> > + (license x11-style)))
>
> ???x11-style??? is a procedure, so it should be:
>
> (x11-style URI [COMMENT])
>
> Make sure it???s not really ???x11??? or ???expat???.
>
> It is neither of those, although similar. The trouble is, I don't think that
> there is a URI for the license. It is contained in the tarball.
See other uses: it’s fine to use file://COPYING, say, as the URI to the
license, if the only copy is within the tarball.
Also, it’s even better if you can add a comment above saying what’s
different from the X11 license text.
Thanks,
Ludo’.
next prev parent reply other threads:[~2014-10-13 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 10:37 [PATCH] gnu: Add xboing John Darrington
2014-10-13 12:27 ` Ludovic Courtès
2014-10-13 12:43 ` John Darrington
2014-10-13 13:54 ` Ludovic Courtès [this message]
2014-10-13 14:54 ` John Darrington
2014-10-13 15:25 ` Ludovic Courtès
2014-10-13 19:18 ` John Darrington
2014-10-13 21:32 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvescbx1.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
--cc=john@darrington.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).