unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ninja.
Date: Fri, 09 Jan 2015 15:34:25 +0100	[thread overview]
Message-ID: <87fvbk3tvy.fsf@gnu.org> (raw)
In-Reply-To: <1420810817-23613-1-git-send-email-iyzsong@gmail.com> ("宋文武"'s message of "Fri, 9 Jan 2015 21:40:17 +0800")

宋文武 <iyzsong@gmail.com> skribis:

> * gnu/packages/ninja.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +          'check
> +          (lambda _
> +            (and (zero? (system "./configure.py"))
> +                 (zero? (system "./ninja ninja_test"))
> +                 ;; SubprocessTest.InterruptChild fail when using 'system*'.
> +                 ;; SubprocessTest.SetWithLots was skipped.
> +                 ;; XXX: Raise [ulimit -n] well above 1025 to make this test go.

Does it mean that the test is currently failing?

> +                 (zero? (system (string-append
> +                                 "./ninja_test "
> +                                 "--gtest_filter="
> +                                 "-SubprocessTest.SetWithLots")))))

Please use ‘system*’ (with separate arguments) rather than ‘system’.
The latter runs “/bin/sh -c ...” whereas the former runs the program
directly.

Thanks,
Ludo’.

  reply	other threads:[~2015-01-09 14:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 13:40 [PATCH] gnu: Add ninja 宋文武
2015-01-09 14:34 ` Ludovic Courtès [this message]
2015-01-10 11:07   ` 宋文武
2015-01-10 13:46     ` Ludovic Courtès
2015-01-11  3:07       ` 宋文武
2015-01-11 10:53         ` Ludovic Courtès
2015-01-11 11:28           ` 宋文武
2015-01-12  9:53             ` Ludovic Courtès
2015-01-14  0:31   ` Mark H Weaver
2015-01-15 11:15     ` 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvbk3tvy.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).