From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add most debian patches to nvi. Date: Thu, 22 Jan 2015 21:52:10 +0100 Message-ID: <87fvb2zgg5.fsf@gnu.org> References: <54BFBAED.3090502@gmail.com> <54BFBB39.5030200@gmail.com> <873874w508.fsf@gnu.org> <54BFC4FF.5030006@gmail.com> <87r3umby1w.fsf@gnu.org> <54C127C3.9070705@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEOjg-000285-Fp for guix-devel@gnu.org; Thu, 22 Jan 2015 15:52:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEOjc-0002OA-7x for guix-devel@gnu.org; Thu, 22 Jan 2015 15:52:16 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:51785) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEOjc-0002O6-0p for guix-devel@gnu.org; Thu, 22 Jan 2015 15:52:12 -0500 In-Reply-To: <54C127C3.9070705@gmail.com> (Marek Benc's message of "Thu, 22 Jan 2015 17:39:31 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Marek Benc Cc: guix-devel@gnu.org Marek Benc skribis: > On 01/22/2015 05:05 PM, Ludovic Court=C3=A8s wrote: >> Marek Benc skribis: >> >>> On 01/21/2015 04:03 PM, Ludovic Court=C3=A8s wrote: >>>> I agree with Andreas: there are 20 patches, and that level of patching >>>> goes beyond our mission, IMO. >>>> >>>> I would rather leave it as is if it=E2=80=99s usable, or remove it, or= point to >>>> a new upstream if there is one. >>> In that case, I think at least two of the patches should be allowed to >>> get in, the ones about the Berkely db library, since it's spewing out >>> errors without them. (but the editor itself works) >> You mean there are run-time errors without nvi-db4.patch? What kind? > > I mistyped, it's only warnings, the editor seems to work okay. In > particular, > the warnings look like this: > > BDB0635 DB_CREATE must be specified to create databases. > BDB0511 page sizes must be a power-of-2 OK. >> The second patch is about page sizes apparently. Do you know what the >> deal is? > > nvi seems to store the data of files in Berkely DB database objects, > and when > setting up a database for a file, it determines a page size to fit the fi= le > into 15 pages or less, using a page size of at least 1K and at most 10K. > > The way it does the calculation, I quote: > psize =3D ((sb.st_size / 15) + 1023) / 1024; > if (psize > 10) > psize =3D 10; > if (psize =3D=3D 0) > psize =3D 1; > psize *=3D 1024; > > makes psize hold a variable that's a multiple of 1024, but not necessaril= ya > power of two (for example, 3072). This didn't use to be a problem > before, but > nowadays, BDB requires pages to be powers of two, and so the modified > code, I Oh, OK. Could you quote the warnings and fold these explanations at the top of the patches? And then we=E2=80=99ll be all set. Thanks for the explanation, Ludo=E2=80=99.