From: 宋文武 <iyzsong@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0.
Date: Wed, 22 Apr 2015 10:03:36 +0800 [thread overview]
Message-ID: <87fv7sc41z.fsf@gmail.com> (raw)
In-Reply-To: <87a8y119dj.fsf@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> Note: this series should go to a ‘glib’ branch, which we’ll get Hydra to
> build.
>
> 宋文武 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/glib.scm (gobject-introspection): Update to 1.44.0.
>> [source]: Use mirror://gnome.
>> [arguments]<#:phases>: Remove.
>> * gnu/packages/patches/gobject-introspection-cc.patch: Rewrite to
>> set os.environ['CC'] in 'giscanner/__init__.py'.
>
> I don’t know exactly what happened but something broke since the
> original patch went in. The intent was described at
> <https://lists.gnu.org/archive/html/guix-devel/2013-11/msg00127.html>.
>
>> +Use gcc as the default C compiler if CC is not set.
>> +
>> +
>> +--- gobject-introspection-1.44.0.orig/giscanner/__init__.py 2014-08-04 22:37:07.000000000 +0800
>> ++++ gobject-introspection-1.44.0/giscanner/__init__.py 2015-04-20 17:30:26.507697234 +0800
>> +@@ -22,3 +22,5 @@
>> + builddir = os.environ.get('UNINSTALLED_INTROSPECTION_BUILDDIR')
>> + if builddir is not None:
>> + __path__.append(os.path.join(builddir, 'giscanner'))
>> ++if not 'CC' in os.environ:
>> ++ os.environ['CC'] = 'gcc'
>
> Is it OK if $CC is set for all the child processes of giscanner?
IIUC, this didn't set $CC for child processes, just update the
os.environ dict (not the env table in unix way) for the python process.
>
> Assuming there’s no issue in this area, that looks good to me. And
> there’s a whole bunch of CC=gcc that you can remove afterwards. :-)
Yes.
>
> Thanks!
>
> Ludo’.
next prev parent reply other threads:[~2015-04-22 2:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 10:11 [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0 宋文武
2015-04-20 10:11 ` [PATCH 2/7] gnu: itstool: Update to 2.0.2 宋文武
2015-04-20 10:11 ` [PATCH 3/7] gnu: dbus-glib: Update to 0.104 宋文武
2015-04-20 10:11 ` [PATCH 4/7] gnu: libsigc++: Update to 2.4.1 宋文武
2015-04-20 10:11 ` [PATCH 5/7] gnu: glibmm: Update to 2.44.0 宋文武
2015-04-20 10:12 ` [PATCH 6/7] gnu: python-pygobject: Update to 3.16.1 宋文武
2015-04-20 10:12 ` [PATCH 7/7] gnu: poppler: Update to 0.32.0 宋文武
2015-04-21 21:04 ` [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0 Ludovic Courtès
2015-04-22 2:03 ` 宋文武 [this message]
2015-04-21 21:05 ` Ludovic Courtès
2015-04-21 21:15 ` Andreas Enge
2015-04-21 22:18 ` Mark H Weaver
2015-04-22 2:06 ` 宋文武
2015-04-22 12:06 ` Andreas Enge
2015-04-22 15:03 ` Mark H Weaver
2015-04-22 15:54 ` Andreas Enge
2015-04-22 21:00 ` Ludovic Courtès
2015-04-22 21:23 ` Mark H Weaver
2015-04-24 22:22 ` Mark H Weaver
2015-04-25 9:00 ` Mark H Weaver
2015-04-25 18:41 ` Andreas Enge
2015-04-26 0:00 ` 宋文武
2015-04-26 9:36 ` Andreas Enge
2015-04-26 14:07 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv7sc41z.fsf@gmail.com \
--to=iyzsong@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).