From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Add libiberty. Date: Mon, 29 Jun 2015 10:33:18 +0200 Message-ID: <87fv5ark1d.fsf@gnu.org> References: <871tgxzdji.fsf@elephly.net> <87y4j4xkw5.fsf@gnu.org> <87lhf4xgxg.fsf@elephly.net> <87d20ftwbz.fsf@gnu.org> <87h9prxc48.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9UVK-0001cE-SS for guix-devel@gnu.org; Mon, 29 Jun 2015 04:33:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9UVF-00019r-PY for guix-devel@gnu.org; Mon, 29 Jun 2015 04:33:26 -0400 In-Reply-To: <87h9prxc48.fsf@elephly.net> (Ricardo Wurmus's message of "Mon, 29 Jun 2015 08:27:51 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: Guix-devel Ricardo Wurmus skribis: >>>>> +(define-public libiberty >>>>> + (make-libiberty gcc)) >>>> >>>> s/gcc/gcc-4.8/ if 4.8 is the last package installing it. >>> >>> I wanted to provide a default libiberty package for the default =E2=80= =9Cgcc=E2=80=9D. >>> Otherwise any change to the default GCC version would require packages >>> to update their libiberty input. >>> >>> GCC 4.8 actually installs libiberty somewhere in the =E2=80=9Clib=E2=80= =9D output of >>> gcc-4.8, but GCC 4.9 does not, nor does GCC 5.1. Is there a problem >>> with =E2=80=9Clibiberty=E2=80=9D as defined above, following whatever G= CC version is set >>> as the default? >> >> Oh you mean that 4.9 and 5.1 install it as well, just not in the =E2=80= =9Clib=E2=80=9D >> output, right? > > No, I mean that although 4.9 and 5.1 include the sources of libiberty > neither of them install it as a library in *any* of their outputs. > > With 4.8 a package depending on libiberty could add > > ("gcc" ,gcc-4.8 "lib") > > as an input, but with 4.9 and 5.1 there does not seem to be any way to > get libiberty but to explicitly install it. This is what the new > =E2=80=9Clibiberty=E2=80=9D package is supposed to do. OK. > Following the GCC version automatically dependent on whatever value the > variable "gcc" has is just a bonus to simplify upgrades to the default > version of GCC (as the recent move from 4.8 to 4.9). I don=E2=80=99t get it. If we use =E2=80=98gcc=E2=80=99 instead of =E2=80= =98gcc-4.8=E2=80=99, it doesn=E2=80=99t work, because =E2=80=98gcc=E2=80=99 is currently an alias for =E2=80=98gcc-4.9=E2= =80=99. This is why I suggested using =E2=80=98gcc-4.8=E2=80=99 explicitly: We know= it=E2=80=99s the last version that installs libiberty. Thanks, Ludo=E2=80=99.