From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 4/4] gnu: git: Add inputs for send-email.
Date: Mon, 29 Jun 2015 13:56:51 +0200
Message-ID: <87fv5aohh8.fsf@gnu.org>
References: <1435459147-5159-1-git-send-email-ericbavier@openmailbox.org>
	<1435459147-5159-5-git-send-email-ericbavier@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32879)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z9XgU-0006X2-83
	for guix-devel@gnu.org; Mon, 29 Jun 2015 07:57:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z9XgO-0002jR-J3
	for guix-devel@gnu.org; Mon, 29 Jun 2015 07:57:10 -0400
In-Reply-To: <1435459147-5159-5-git-send-email-ericbavier@openmailbox.org>
	(ericbavier@openmailbox.org's message of "Sat, 27 Jun 2015 21:39:07
	-0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>

ericbavier@openmailbox.org skribis:

> From: Eric Bavier <bavier@member.fsf.org>
>
> * gnu/packages/version-control.scm (git)[inputs]: Add
>   perl-authen-sasl, perl-net-smtp-ssl, and perl-io-socket-ssl.
>   [arguments]: Add #:modules argument with srfi-1.  In 'split phase,
>   wrap git-send-email.

[...]

> +      #:modules ((guix build gnu-build-system)
> +                 (guix build utils)
> +                 (srfi srfi-1))

Use %gnu-build-system-modules instead of listing modules explicitly.

> +              ;; Tell 'git-send-email' where perl modules are.
> +              (wrap-program (string-append out "/libexec/git-core/git-se=
nd-email")

It would be best to add a =E2=80=9Csend-email=E2=80=9D output specifically =
for that, so
we keep the size of the closure of =E2=80=9Cout=E2=80=9D under control (2 M=
iB is still
10% of the size of =E2=80=9Cout=E2=80=9D.)

> +                `("PERL5LIB" ":" prefix
> +                  ,(map (lambda (o) (string-append o "/lib/perl5/site_pe=
rl"))
> +                        (delete-duplicates
> +                         (list
> +                          ,@(append-map
> +                             (lambda (p)
> +                               (let ((name (package-name p)))
> +                                 `((assoc-ref inputs ,name)
> +                                   ,@(map (match-lambda
> +                                            ((label (? package? _) . _)
> +                                             `(assoc-ref inputs
> +                                                         ,(string-append=
 name "/" label))))
> +                                          (package-transitive-propagated=
-inputs p)))))
> +                             `(,perl-authen-sasl
> +                               ,perl-net-smtp-ssl
> +                               ,perl-io-socket-ssl)))))))

Could you move the part of ,@ to a top-level procedure?

Thanks,
Ludo=E2=80=99.