From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH 21/43] gnu: ghc-transformers-compat: New variables.
Date: Tue, 20 Oct 2015 16:12:03 +0200
Message-ID: <87fv154ojw.fsf@denknerd.org>
References: <1444911697-15515-1-git-send-email-paul@denknerd.org>
	<1444911697-15515-21-git-send-email-paul@denknerd.org>
	<20151019093712.1eee5f41@openmailbox.org>
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37956)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXeF-000366-2e
	for guix-devel@gnu.org; Tue, 20 Oct 2015 10:12:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXeA-0005Wh-C9
	for guix-devel@gnu.org; Tue, 20 Oct 2015 10:12:19 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:38625 helo=mx-out03.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXeA-0005WK-4U
	for guix-devel@gnu.org; Tue, 20 Oct 2015 10:12:14 -0400
In-reply-to: <20151019093712.1eee5f41@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org


On 2015-10-19 at 16:37, quoth Eric Bavier:
>> +  (package
>> +    (name "ghc-exceptions")
>> .....
>> +    (inputs
>> +     `(("ghc-quickcheck" ,ghc-quickcheck)))
>
> Is this still required even with '#:tests? #f'?

Turns out it's not.  Fixed.

>> +    (description
>> +     "Extensible optionally-pure exceptions")
>
> This is a fragment.  In general, I notice that the formatting style
> varies a bit accross packages.  Could you make sure that formatting, at
> least within gnu/packages/haskell.scm is mostly consistent?

Fixed in this package, will look at the rest before pushing.

>> +  (package
>> +    (name "ghc-temporary")
>> .....
>> +    (synopsis "Portable temporary file and directory support for Windows and
>> +Unix, based on code from Cabal")
>> +    (description "The functions for creating temporary files and directories
>> +in the base library are quite limited. The unixutils package contains some
>> +good ones, but they aren't portable to Windows. This library just repackages
>> +the Cabal implementations of its own temporary file and folder functions so
>> +that you can use them without linking against Cabal or depending on it being
>> +installed.")
>> +    (license bsd-3)))
>
> Again, we don't really need to mantion portability aspects.

Fixed.

>> +  (package
>> +    (name "ghc-silently")
>> +    (arguments `(#:tests? #f))  ;; circular dependency with nanospec
>> +    (inputs
>> +     `(("ghc-temporary" ,ghc-temporary)))
>
> Is this required with '#:tests? #f', and if so, does it need to be
> propagated?

You're right, it seems it was only necessary for the tests.  Removed
entirely.

>> +    (description
>> +     "Prevent or capture writing to stdout and other handles.")
>
> Could you expand this so it's not a fragment?

Done.