From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] gnu: Add tilda.
Date: Sun, 15 Nov 2015 21:28:12 +0100
Message-ID: <87fv07t3c3.fsf@gnu.org>
References: <1447150040-10401-1-git-send-email-efraim@flashner.co.il>
	<1447150040-10401-3-git-send-email-efraim@flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53570)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zy3uN-0006IS-Pc
	for guix-devel@gnu.org; Sun, 15 Nov 2015 15:28:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zy3uJ-00029J-OJ
	for guix-devel@gnu.org; Sun, 15 Nov 2015 15:28:19 -0500
In-Reply-To: <1447150040-10401-3-git-send-email-efraim@flashner.co.il> (Efraim
	Flashner's message of "Tue, 10 Nov 2015 12:07:20 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/packages/terminals.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Not sure if it warrants a new file, but I don=E2=80=99t have a better idea.

[...]

> +     `(#:phases (modify-phases %standard-phases
> +                 (add-after 'patch-source-shebangs 'autogen

I think it should be =E2=80=98add-before=E2=80=99 so that the shebangs in g=
enerated
files are patched.

> +                  (lambda _       ; tries to run ./configure

Rather: =E2=80=9CAvoid running ./configure.=E2=80=9D

> +                   (substitute* "autogen.sh" (("^.*\\$srcdir/configure.*=
") ""))

Newline after "autogen.sh".

> +       ("vte" ,vte-0.36))) ; try in 1.3 to use vte-0.38 or higher

Add =E2=80=9CXXX=E2=80=9D or =E2=80=9CTODO=E2=80=9D to make it more visible.

> +    (synopsis "Gtk based drop down terminal")

=E2=80=9CGTK+-based drop-down terminal emulator=E2=80=9D maybe?

> +    (description "Tilda is a terminal emulator similar to normal termina=
ls like
> +gnome-terminal (GNOME) or Konsole (KDE), with the difference that it dro=
ps down
> +from the edge of a screen when a certain configurable hotkey is pressed.=
  This
> +is similar to the build-in consoles in games such as Quake or Half-life.=
  Tilda

Rather: =E2=80=9Csimilar to the built-in consoles in some applications.=E2=
=80=9D

Could you send an updated patch?

Thanks!

Ludo=E2=80=99.