Re: [PATCH 2/2] gnu: Add tilda.

[ludo@gnu.org (Ludovic Courtès)]

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/packages/terminals.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Not sure if it warrants a new file, but I don’t have a better idea.

[...]

> +     `(#:phases (modify-phases %standard-phases
> +                 (add-after 'patch-source-shebangs 'autogen

I think it should be ‘add-before’ so that the shebangs in generated
files are patched.

> +                  (lambda _       ; tries to run ./configure

Rather: “Avoid running ./configure.”

> +                   (substitute* "autogen.sh" (("^.*\\$srcdir/configure.*") ""))

Newline after "autogen.sh".

> +       ("vte" ,vte-0.36))) ; try in 1.3 to use vte-0.38 or higher

Add “XXX” or “TODO” to make it more visible.

> +    (synopsis "Gtk based drop down terminal")

“GTK+-based drop-down terminal emulator” maybe?

> +    (description "Tilda is a terminal emulator similar to normal terminals like
> +gnome-terminal (GNOME) or Konsole (KDE), with the difference that it drops down
> +from the edge of a screen when a certain configurable hotkey is pressed.  This
> +is similar to the build-in consoles in games such as Quake or Half-life.  Tilda

Rather: “similar to the built-in consoles in some applications.”

Could you send an updated patch?

Thanks!

Ludo’.