From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Fix XFCE shutdown/reboot via menu.
Date: Sat, 21 Nov 2015 21:37:46 +0100 [thread overview]
Message-ID: <87fuzz5bs5.fsf@gnu.org> (raw)
In-Reply-To: <87vb8vqolg.fsf@elephly.net> (Ricardo Wurmus's message of "Sat, 21 Nov 2015 17:55:23 +0100")
Ricardo Wurmus <rekado@elephly.net> skribis:
> in the XFCE panel there is an item called “Action Buttons” offering
> screen locking, log out, switch user, shutdown and reboot. Shutdown and
> reboot do not work at the moment.
>
> I investigated a little and came up with a configuration in which these
> two features do work.
\o/
> First I had to patch our xfce-session package. Upower is checked for at
> configure time and needed for shutdown and reboot. Polkit’s “pkexec” is
> required to run the shutdown helper.
>
> The helper contains a bunch of hardcoded paths to /sbin/shutdown, which
> are replaced in a build phase — not in a snippet because eventually we
> should also fix the paths to pm-{suspend,hibernate}, which would be
> provided by an input that is currently not present(?).
The ‘run’ function in xfsm-shutdown-helper/main.c runs these programs
with:
result = g_spawn_sync (NULL, argv, envp,
G_SPAWN_SEARCH_PATH | G_SPAWN_STDOUT_TO_DEV_NULL |
G_SPAWN_STDERR_TO_DEV_NULL,
NULL, NULL, NULL, NULL, &status, &err);
I’m guessing G_SPAWN_SEARCH_PATH means that the program is searched for
in $PATH, in which case writing ‘halt’ would be enough (it would be
found in /run/setuid-programs.)
> I also needed to change my system configuration to add “pkexec” to the
> list of setuid programs:
>
> (setuid-programs (cons #~(string-append #$polkit "/bin/pkexec")
> %setuid-programs))
>
> Maybe this should just be added to %setuid-programs?
I think polkit-service-type should extend setuid-service-type to add
that program.
> Is it okay to use /run/setuid-programs/pkexec in the shutdown helper or
> should this rather be a reference to the polkit input?
The code that spawns pkexec looks like this:
command = g_strdup_printf ("pkexec " XFSM_SHUTDOWN_HELPER_CMD " --%s", action);
ret = g_spawn_command_line_sync (command, NULL, NULL, &exit_status, error);
I think this can be left unchanged, as long as we provide pkexec in
$PATH (which is the case if it’s in /run/setuid-programs.)
Thanks for looking into it!
Ludo’.
next prev parent reply other threads:[~2015-11-21 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 16:55 [PATCH] Fix XFCE shutdown/reboot via menu Ricardo Wurmus
2015-11-21 20:37 ` Ludovic Courtès [this message]
2015-11-21 21:06 ` Ricardo Wurmus
2015-11-24 20:40 ` Ludovic Courtès
2015-11-25 17:46 ` Ricardo Wurmus
2015-11-28 14:14 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuzz5bs5.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).