From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: [PATCH] gnu: Add docopt. Date: Thu, 03 Dec 2015 18:17:42 -0500 Message-ID: <87fuzjf7ft.fsf@kyleam.com> References: <1449123849-13644-1-git-send-email-kyle@kyleam.com> <20151203193129.GA22316@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4d8K-0001O0-S5 for guix-devel@gnu.org; Thu, 03 Dec 2015 18:17:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4d8H-0003QS-G6 for guix-devel@gnu.org; Thu, 03 Dec 2015 18:17:52 -0500 Received: from pb-smtp0.int.icgroup.com ([208.72.237.35]:61379 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4d8H-0003QD-9T for guix-devel@gnu.org; Thu, 03 Dec 2015 18:17:49 -0500 In-Reply-To: <20151203193129.GA22316@jasmine> (Leo Famulari's message of "Thu, 3 Dec 2015 14:31:29 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel Leo Famulari writes: > On Thu, Dec 03, 2015 at 01:24:09AM -0500, Kyle Meyer wrote: >> * gnu/packages/python.scm (python-docopt, python2-docopt): New >> variables. > > Have you tested the software provided by this patch to make sure it > works? I'm not sure how to test it since it's just a library. Yes, I've been using the py3 version locally for a while and haven't noticed any issues. I didn't test the py2 version. >> + (arguments '(#:tests? #f)) ; Tests are not included in the PyPI release. > > Are there tests in any other releases? If not, I would change the > comment to "No test suite", just to make it more clear. If yes, we > should probably package that release while asking upstream to include > the tests in the PyPi release. There's a test file in the GitHub repo. I'll open a PR adding it to the source distribution and change the package definition to use the GitHub source for now. Thanks for the feedback. I'll send an update. [I also just realized that I put docopt rather than python-docopt in the commit subject.] -- Kyle