From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Update glade. Date: Fri, 15 Jan 2016 21:30:25 +0100 Message-ID: <87fuxyegbi.fsf@gnu.org> References: <87lh7s3247.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKB0z-0006Cz-Un for guix-devel@gnu.org; Fri, 15 Jan 2016 15:30:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aKB0v-0002Rz-5d for guix-devel@gnu.org; Fri, 15 Jan 2016 15:30:33 -0500 In-Reply-To: <87lh7s3247.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 14 Jan 2016 11:08:08 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: Guix-devel Ricardo Wurmus skribis: > This makes it possible to build =E2=80=9Cgnunet-gtk=E2=80=9D with the lat= est version of > GTK+. I chose to disable the three tests, because they require an X > server with libGL support for software rendering. I couldn=E2=80=99t get= this > to work even after adding =E2=80=9Cxorg-server=E2=80=9D and =E2=80=9Cmesa= =E2=80=9D, and starting Xvfb > before tests. OK. > From 48a7ac38ee0f5554c844a503d5ed232a5816eb07 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Thu, 14 Jan 2016 11:03:49 +0100 > Subject: [PATCH] gnu: glade: Update to 3.18.5. > > * gnu/packages/gnome.scm (glade): Update to 3.18.5. > [arguments]: Disable tests; add "fix-docbook" phase. > [inputs]: Replace "gtk+-2" with "gtk+". > [native-inputs]: Add "itstool", "libxslt", "docbook-xml", "docbook-xsl"; > replace "python" with "python-2". [...] > + (add-before 'configure 'fix-docbook > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "man/Makefile.in" > + (("http://docbook.sourceforge.net/release/xsl/current/man= pages/docbook.xsl") > + (string-append (assoc-ref inputs "docbook-xsl") > + "/xml/xsl/docbook-xsl-" > + ,(package-version docbook-xsl) > + "/manpages/docbook.xsl"))) > + (setenv "XML_CATALOG_FILES" > + (string-append (assoc-ref inputs "docbook-xml") > + "/xml/dtd/docbook/catalog.xml")) I=E2=80=99m surprised that this is needed: since libxml2 is an input, and s= ince libxml2 defines XML_CATALOG_FILES as its search path, XML_CATALOG_FILES should automatically be set, no? Otherwise LGTM, thanks! I agree with Efraim that switching to GTK+ 3.x is good idea. Ludo=E2=80=99.