* Re: 03/03: build: Do not remake doc/guix.1.
[not found] ` <E1agKv1-0007kV-Tm@vcs.savannah.gnu.org>
@ 2016-03-17 22:11 ` Mathieu Lirzin
2016-03-18 21:09 ` Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Lirzin @ 2016-03-17 22:11 UTC (permalink / raw)
To: Eric Bavier; +Cc: guix-devel
Hello Eric,
Eric Bavier <bavier@member.fsf.org> writes:
> bavier pushed a commit to branch master
> in repository guix.
>
> commit 97966e6d65bd3d450f12c7bb41af5f9eafd35a60
> Author: Eric Bavier <bavier@member.fsf.org>
> Date: Wed Mar 16 12:53:55 2016 -0500
>
> build: Do not remake doc/guix.1.
>
> * doc.am (doc/guix.1): Do not depend on $(sub_commands_mans) which will
> always appear out-of-date.
> ---
Can you explain more extensively what was the issue? I don't understand
why $(sub_commands_mans) always appeared out-of-date.
> diff --git a/doc.am b/doc.am
> index 127029c..a1eabad 100644
> --- a/doc.am
> +++ b/doc.am
> @@ -129,8 +129,12 @@ HELP2MANFLAGS = --source=GNU --info-page=$(PACKAGE_TARNAME)
>
> # Note: Do not depend on 'scripts/guix' since that would trigger a rebuild
> # even for people building from a tarball.
> -doc/guix.1: $(sub_commands_mans)
> - -$(AM_V_HELP2MAN)$(gen_man) --output="$@" `basename "$@" .1`
> +doc/guix.1: scripts/guix.in $(GOBJECTS)
> + -@case '$?' in \
> + *$<*) $(AM_V_P) && set -x || echo " HELP2MAN $@"; \
> + $(gen_man) --output="$@" "guix";; \
> + *) : ;; \
> + esac
Thanks.
--
Mathieu Lirzin
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: 03/03: build: Do not remake doc/guix.1.
2016-03-17 22:11 ` 03/03: build: Do not remake doc/guix.1 Mathieu Lirzin
@ 2016-03-18 21:09 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2016-03-18 21:09 UTC (permalink / raw)
To: Mathieu Lirzin; +Cc: guix-devel, Eric Bavier
Mathieu Lirzin <mthl@gnu.org> skribis:
> Eric Bavier <bavier@member.fsf.org> writes:
>
>> bavier pushed a commit to branch master
>> in repository guix.
>>
>> commit 97966e6d65bd3d450f12c7bb41af5f9eafd35a60
>> Author: Eric Bavier <bavier@member.fsf.org>
>> Date: Wed Mar 16 12:53:55 2016 -0500
>>
>> build: Do not remake doc/guix.1.
>>
>> * doc.am (doc/guix.1): Do not depend on $(sub_commands_mans) which will
>> always appear out-of-date.
>> ---
>
> Can you explain more extensively what was the issue? I don't understand
> why $(sub_commands_mans) always appeared out-of-date.
The problem was that doc/guix.1 would always be remade, as could be
witnessed when running ‘make distcheck’.
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-18 21:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160316233159.29712.78586@vcs.savannah.gnu.org>
[not found] ` <E1agKv1-0007kV-Tm@vcs.savannah.gnu.org>
2016-03-17 22:11 ` 03/03: build: Do not remake doc/guix.1 Mathieu Lirzin
2016-03-18 21:09 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).