From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add gnu-maintain and gnu-standards.
Date: Fri, 25 Mar 2016 11:18:20 +0100
Message-ID: <87fuvesvwz.fsf@gnu.org>
References: <87a8lokhs3.fsf@drakenvlieg.flower>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53692)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ajOpE-0003Mz-Qi
	for guix-devel@gnu.org; Fri, 25 Mar 2016 06:18:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ajOpA-0004Ne-MT
	for guix-devel@gnu.org; Fri, 25 Mar 2016 06:18:40 -0400
In-Reply-To: <87a8lokhs3.fsf@drakenvlieg.flower> (Jan Nieuwenhuizen's message
	of "Wed, 23 Mar 2016 22:26:20 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org

Jan Nieuwenhuizen <janneke@gnu.org> skribis:

> From 914756aa6c8893ce68f57dab575ed67f4d5ae560 Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <janneke@gnu.org>
> Date: Wed, 23 Mar 2016 22:18:46 +0100
> Subject: [PATCH] gnu: Add gnu-maintain and gnu-standards.
>
> * gnu/packages/gnu-doc.scm: New file.

Please add it to gnu-system.am as well.

The =E2=80=98miscfiles=E2=80=99 package should probably go to the same modu=
le (in a
separate commit.)

> +    (source (origin
> +              (method url-fetch)
> +              (uri "http://www.gnu.org/prep/maintain/maintain.texi.tar.g=
z")

This is an unversioned URL where the file occasionally gets updated in
place, so it=E2=80=99s unsuitable.

I think this one should instead be taken from
:pserver:anonymous@cvs.savannah.gnu.org:/sources/gnustandards using
(guix cvs-download).

> +(define-public gnu-standards
> +  (package
> +    (name "gnu-standards")
> +    (version "2015-04-23")
> +    (source (origin
> +              (method url-fetch)
> +              (uri "http://www.gnu.org/prep/standards/standards.texi.tar=
.gz")
> +              (sha256
> +               (base32
> +                "1rdyqk6d5bgrpmlnb8r65qif1h604jz1g7v3szh24cqga3mgi9py"))=
))

Likewise.

> +    (description "The GNU Coding Standards were written by Richard Stall=
man and other GNU Project volunteers.  Their purpose is to make the GNU sys=
tem clean, consistent, and easy to install.")

Please shrink the line, as suggested by =E2=80=98guix lint=E2=80=99.

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.