From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Connman Date: Tue, 26 Apr 2016 00:04:21 +0200 Message-ID: <87fuu99wgq.fsf@gnu.org> References: <20160420224145.GA8585@debian-netbook> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auocF-00010w-Cb for guix-devel@gnu.org; Mon, 25 Apr 2016 18:04:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auocC-0000tO-7O for guix-devel@gnu.org; Mon, 25 Apr 2016 18:04:27 -0400 In-Reply-To: <20160420224145.GA8585@debian-netbook> (Efraim Flashner's message of "Thu, 21 Apr 2016 01:41:45 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel@gnu.org Efraim Flashner skribis: > I think I've finally gotten connman working, with a service. I haven't > added an entry to doc/guix.texi yet, and for some reason when I started > the patch I stuck it in wicd.scm. I've also attached the OS config I > used while testing. Neat! > From efe1f20ecb23fc4ba2da647152c9f2a2e96293be Mon Sep 17 00:00:00 2001 > From: Efraim Flashner > Date: Thu, 19 Apr 2016 17:25:41 +0200 > Subject: [PATCH 1/2] gnu: Add connman. > > * gnu/packages/wicd.scm (connman): New variable. I think it should go in some other file, possibly connman.scm=E2=80=94whate= ver you deem appropriate, but probably not wicd.scm. :-) > +(define-public connman > + (package > + (name "connman") > + (version "1.32") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://www.kernel.org/pub/linux/network/co= nnman/" Use mirror://kernel.org/=E2=80=A6 > + (string-append > + "--with-dbusconfdir=3D" (assoc-ref %outputs "out") "/etc") > + (string-append > + "--with-dbusdatadir=3D" (assoc-ref %outputs "out") "/share= ")))) I suppose this populates $out/etc/dbus-1 and $out/share/dbus-1, which is where our D-Bus service looks for its XML thingies? > + (synopsis "Connection Manager daemon") =E2=80=9CConnection management daemon=E2=80=9D > + (description "The Linux Connection Manager project provides a daemon= for s/The Linux Connection Manager project/Connman/ > +managing Internet connections within embedded devices running the Linux > +operating system. s/within =E2=80=A6 system// > + (license gpl2))) v2-only? > From 2e99131f5b455ceb7c70c33eb4c89134caa755bb Mon Sep 17 00:00:00 2001 > From: Efraim Flashner > Date: Thu, 19 Apr 2016 22:10:11 +0200 > Subject: [PATCH 2/2] services: Add connman-service. > > * gnu/services/networking.scm (connman-service): New procedure. > (connman-service-type, %connman-activation): New variables. > (connman-shepherd-service): New procedure. [...] > +(define %connman-activation > + ;; Activation gexp for Connman. > + #~(begin > + (use-modules (guix build utils)) > + (mkdir-p "/etc/connman/") Is an empty /etc/connman really needed? > +(define* (connman-service #:key (connman connman)) > + "Return a service that runs Connman, a network connection manager. Th= is s/Connman/@uref{http://=E2=80=A6, Connman}/ > +service adds the @var{connman} package to the global profile, providing > +several the @command{connmanctl} command to interact with the daemon and > +configure networking." Could you add this documentation to guix.texi? Otherwise LGTM! How does Connman compare to Wicd, and to NetworkManager? Thank you! Ludo=E2=80=99.