From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 2/3] gnu: Add wcslib Date: Tue, 13 Sep 2016 11:10:57 +0300 Message-ID: <87fup4b4oe.fsf@gmail.com> References: <1472584872-19300-1-git-send-email-jmd@gnu.org> <1472584872-19300-2-git-send-email-jmd@gnu.org> <874m61fngt.fsf@gmail.com> <8737l58c6r.fsf@gmail.com> <20160912154006.GA6648@jocasta.intra> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjip4-0004MP-9e for guix-devel@gnu.org; Tue, 13 Sep 2016 04:12:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjip0-0006Ft-2E for guix-devel@gnu.org; Tue, 13 Sep 2016 04:12:05 -0400 In-Reply-To: <20160912154006.GA6648@jocasta.intra> (John Darrington's message of "Mon, 12 Sep 2016 17:40:06 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org, John Darrington John Darrington (2016-09-12 17:40 +0200) wrote: > On Mon, Sep 12, 2016 at 04:44:44PM +0300, Alex Kost wrote: > > I've noticed that you didn't fix these things (long line and #t after > substitute*). Could please do it next time :-) > > The same for 'cfitsio' package. > > Done. > > If this is important why doesn't guix build and/or guix lint check for it? "guix lint" can't check if a phase should end with #t or not, it's up to you check if it is needed. The thing is: if a phase fails, it should return false value, and if it succeeds, it should return non-false value. A returned value of 'substitute*' is unspecified, so here you should add #t to the end of the phase. It works without it, but I would say it happens "by chance" because # is considered to be non-false, but we shouldn't rely on it, so adding #t to such phases is the right thing. As for the long line, it is 89 chars long, while "guix lint" reports about exceeding 90 chars (see 'report-long-line' in (guix scripts lint) module). BTW I think this is too loose, I would limit it to 80. But your line could be easily shorten, as I wrote at , so instead of the current long line: (uri (string-append "ftp://ftp.atnf.csiro.au/pub/software/wcslib/" name "-" version ".tar.bz2")) it could be: (uri (string-append "ftp://ftp.atnf.csiro.au/pub/software/wcslib/" name "-" version ".tar.bz2")) which fits any screen and thus is more readable I think. I just felt a bit of a letdown that you ignored my comments and didn't send a message why. -- Alex