* [PATCH] gnu: Add sunxi-tools.
@ 2016-09-29 11:02 Danny Milosavljevic
2016-10-02 1:54 ` Leo Famulari
0 siblings, 1 reply; 12+ messages in thread
From: Danny Milosavljevic @ 2016-09-29 11:02 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
* gnu/packages/admin.scm (sunxi-tools): New variable.
---
gnu/packages/admin.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-sunxi-tools.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-sunxi-tools.patch", Size: 1420 bytes --]
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 6981242..ae2408b 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -1846,3 +1846,31 @@ Kerberos and Heimdal and FAST is supported with recent MIT Kerberos.")
(license license:gpl1+)))
;;http://archives.eyrie.org/software/kerberos/pam-krb5-4.7.tar.xz
+
+(define-public sunxi-tools
+ (package
+ (name "sunxi-tools")
+ (version "1.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/linux-sunxi/"
+ "sunxi-tools/archive/v" version ".tar.gz"))
+ (sha256
+ (base32 "1iazm28gws1i8sls3gxwc5p108n56ags287zmh1rpvkn2k1az81a"))))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
+ `(("libusb" ,libusb)))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; no tests exist
+ #:make-flags (list (string-append "PREFIX="
+ (assoc-ref %outputs "out")))
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure))))
+ (home-page "https://github.com/linux-sunxi/sunxi-tools")
+ (synopsis "Tools to help manage Allwinner A10 devices")
+ (description "This package contains tools for Allwinner A10 devices (for FEX, FEL USB, PIO, NAND, JTAG, RAM)")
+ (license license:gpl2+)))
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] gnu: Add sunxi-tools.
2016-09-29 11:02 [PATCH] gnu: Add sunxi-tools Danny Milosavljevic
@ 2016-10-02 1:54 ` Leo Famulari
2016-10-02 9:54 ` Danny Milosavljevic
0 siblings, 1 reply; 12+ messages in thread
From: Leo Famulari @ 2016-10-02 1:54 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: guix-devel
On Thu, Sep 29, 2016 at 01:02:04PM +0200, Danny Milosavljevic wrote:
>
> * gnu/packages/admin.scm (sunxi-tools): New variable.
What's the story with the 'bin/' [0] directory? I'm not familiar with
these file types.
The tarball includes:
bin/fel-pio.bin
bin/fel-pio.nm
bin/fel-sdboot.sunxi
bin/jtag-loop.sunxi
bin/ramboot.scr
bin/ramboot.uboot-sh
[0]
https://github.com/linux-sunxi/sunxi-tools/tree/master/bin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] gnu: Add sunxi-tools.
2016-10-02 1:54 ` Leo Famulari
@ 2016-10-02 9:54 ` Danny Milosavljevic
2016-10-02 9:57 ` Vincent Legoll
2016-10-02 9:58 ` [PATCH v2] " Danny Milosavljevic
0 siblings, 2 replies; 12+ messages in thread
From: Danny Milosavljevic @ 2016-10-02 9:54 UTC (permalink / raw)
To: Leo Famulari; +Cc: guix-devel
Hi Leo,
On Sat, 1 Oct 2016 21:54:41 -0400
Leo Famulari <leo@famulari.name> wrote:
> On Thu, Sep 29, 2016 at 01:02:04PM +0200, Danny Milosavljevic wrote:
> >
> > * gnu/packages/admin.scm (sunxi-tools): New variable.
>
> What's the story with the 'bin/' [0] directory? I'm not familiar with
> these file types.
According to https://github.com/linux-sunxi/sunxi-tools/tree/master/bin they added these in order to avoid cross compilation...
http://linux-sunxi.org/Sunxi-tools describes what they are.
They don't seem to be installed in the first place - so I'd just remove them.
bin/fel-pio.bin : ARM binary to be put on the SD card on the target
bin/fel-pio.nm : symbols
bin/fel-sdboot.sunxi : ARM binary to be put on the SD card on the target
bin/jtag-loop.sunxi : ARM binary to be put on the SD card on the target
bin/ramboot.scr : a u-boot configuration binary (created by mkimage) for the target
bin/ramboot.uboot-sh : not actually a binary; for the target
There are also build instructions how to build those contained in the source code as comment at the top, for example in https://github.com/linux-sunxi/sunxi-tools/blob/master/fel-pio.c which is included. I don't think a normal user needs those (and I never needed those). I'd just omit them.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] gnu: Add sunxi-tools.
2016-10-02 9:54 ` Danny Milosavljevic
@ 2016-10-02 9:57 ` Vincent Legoll
2016-10-02 10:01 ` Danny Milosavljevic
2016-10-02 9:58 ` [PATCH v2] " Danny Milosavljevic
1 sibling, 1 reply; 12+ messages in thread
From: Vincent Legoll @ 2016-10-02 9:57 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: guix-devel
Hello,
> There are also build instructions how to build those contained
> in the source code as comment at the top, for example in which
> is included. I don't think a normal user needs those (and I never
> needed those). I'd just omit them.
Maybe just add a quick note in the package description telling
those are missing, to avoid people wondering
--
Vincent Legoll
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] gnu: Add sunxi-tools.
2016-10-02 9:57 ` Vincent Legoll
@ 2016-10-02 10:01 ` Danny Milosavljevic
0 siblings, 0 replies; 12+ messages in thread
From: Danny Milosavljevic @ 2016-10-02 10:01 UTC (permalink / raw)
To: Vincent Legoll; +Cc: guix-devel
Hi,
On Sun, 2 Oct 2016 11:57:38 +0200
Vincent Legoll <vincent.legoll@gmail.com> wrote:
> Maybe just add a quick note in the package description telling
> those are missing, to avoid people wondering
To be clear: these were not installed in the first place. They are (debug) images you can put on an SD card to boot the target with. Then you can use FEL mode to send the actual stuff you want to run over USB.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] gnu: Add sunxi-tools.
2016-10-02 9:54 ` Danny Milosavljevic
2016-10-02 9:57 ` Vincent Legoll
@ 2016-10-02 9:58 ` Danny Milosavljevic
2016-10-04 9:19 ` Ludovic Courtès
1 sibling, 1 reply; 12+ messages in thread
From: Danny Milosavljevic @ 2016-10-02 9:58 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
* gnu/packages/admin.scm (sunxi-tools): New variable.
---
gnu/packages/admin.scm | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-sunxi-tools.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-sunxi-tools.patch", Size: 1563 bytes --]
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 6981242..06c552f 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -1846,3 +1846,35 @@ Kerberos and Heimdal and FAST is supported with recent MIT Kerberos.")
(license license:gpl1+)))
;;http://archives.eyrie.org/software/kerberos/pam-krb5-4.7.tar.xz
+
+(define-public sunxi-tools
+ (package
+ (name "sunxi-tools")
+ (version "1.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/linux-sunxi/"
+ "sunxi-tools/archive/v" version ".tar.gz"))
+ (sha256
+ (base32 "1iazm28gws1i8sls3gxwc5p108n56ags287zmh1rpvkn2k1az81a"))
+ (modules '((guix build utils)))
+ (snippet
+ ;; Source is included anyway.
+ '(delete-file-recursively "bin"))))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
+ `(("libusb" ,libusb)))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; no tests exist
+ #:make-flags (list (string-append "PREFIX="
+ (assoc-ref %outputs "out")))
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure))))
+ (home-page "https://github.com/linux-sunxi/sunxi-tools")
+ (synopsis "Tools to help manage Allwinner A10 devices")
+ (description "This package contains tools for Allwinner A10 devices (for FEX, FEL USB, PIO, NAND, JTAG, RAM)")
+ (license license:gpl2+)))
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v2] gnu: Add sunxi-tools.
2016-10-02 9:58 ` [PATCH v2] " Danny Milosavljevic
@ 2016-10-04 9:19 ` Ludovic Courtès
2016-10-04 10:07 ` Danny Milosavljevic
0 siblings, 1 reply; 12+ messages in thread
From: Ludovic Courtès @ 2016-10-04 9:19 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: guix-devel
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * gnu/packages/admin.scm (sunxi-tools): New variable.
> ---
> gnu/packages/admin.scm | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 6981242..06c552f 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -1846,3 +1846,35 @@ Kerberos and Heimdal and FAST is supported with recent MIT Kerberos.")
> (license license:gpl1+)))
>
> ;;http://archives.eyrie.org/software/kerberos/pam-krb5-4.7.tar.xz
> +
> +(define-public sunxi-tools
> + (package
> + (name "sunxi-tools")
> + (version "1.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/linux-sunxi/"
> + "sunxi-tools/archive/v" version ".tar.gz"))
> + (sha256
> + (base32 "1iazm28gws1i8sls3gxwc5p108n56ags287zmh1rpvkn2k1az81a"))
> + (modules '((guix build utils)))
> + (snippet
> + ;; Source is included anyway.
> + '(delete-file-recursively "bin"))))
The comment should rather be “Remove binaries contained in the tarball.”
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (inputs
> + `(("libusb" ,libusb)))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f ; no tests exist
> + #:make-flags (list (string-append "PREFIX="
> + (assoc-ref %outputs "out")))
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure))))
> + (home-page "https://github.com/linux-sunxi/sunxi-tools")
> + (synopsis "Tools to help manage Allwinner A10 devices")
> + (description "This package contains tools for Allwinner A10 devices (for FEX, FEL USB, PIO, NAND, JTAG, RAM)")
I don’t understand this description. Since “Tools”, “manage”, and
“devices” could mean anything, could you add qualifiers to give more
context, like:
“Frobbing tools for Allwinner A10 foobar devices”
and similarly expound the description (with a period at the end of the
sentence)?
Based on that, we might device that admin.scm is not the best fit for
this package. Maybe flashing-tools.scm?
Could you send an updated patch?
Thanks in advance!
Ludo’.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2] gnu: Add sunxi-tools.
2016-10-04 9:19 ` Ludovic Courtès
@ 2016-10-04 10:07 ` Danny Milosavljevic
2016-10-04 13:15 ` Ludovic Courtès
0 siblings, 1 reply; 12+ messages in thread
From: Danny Milosavljevic @ 2016-10-04 10:07 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
> I don’t understand this description. Since “Tools”, “manage”, and
> “devices” could mean anything, could you add qualifiers to give more
> context, like:
>
> “Frobbing tools for Allwinner A10 foobar devices”
>
> and similarly expound the description (with a period at the end of the
> sentence)?
>
> Based on that, we might device that admin.scm is not the best fit for
> this package. Maybe flashing-tools.scm?
The tools included are:
- sunxi-fexc, bin2fex, fex2bin: Compile a textual description of a board (.fex) to a binary representation (.bin). Like Devicetree - if a vendor doesn't know Devicetree exists and therefore doesn't use it. [can be used on target and host]
- sunxi-fel: Puts an Allwinner A10 device into FEL mode which makes it register as a special USB device (rather than USB host). You can then connect it to another computer and flash it from there (kinda like Arduino or other Atmels). [only makes sense to be used on host]
- sunxi-nand-part: Partitions NAND flash. [only makes sense to be used on target since it uses ioctls specific to the NAND kernel driver]
- sunxi-bootinfo: Reads out boot0 and boot1 information. These are the bootloaders before U-Boot. [can be used on target and host - since it requires an image file]
- sunxi-pio: Sets GPIO and oscillates a GPIO in order to be able to find it [only makes sense to be used on target - since it uses /dev/mem]
So how about this description:
(description "This package contains tools for Allwinner A10 devices:
- sunxi-fexc, bin2fex, fex2bin: Compile a textual description of a board (.fex) to a binary representation (.bin).
- sunxi-fel: Puts a Allwinner A10 device into FEL mode which makes it register as a special USB device (rather than USB host). You can then connect it to another computer and flash it from there.
- sunxi-nand-part: Partitions NAND flash.
- sunxi-bootinfo: Reads out boot0 and boot1 information. These are the bootloaders before U-Boot.
- sunxi-pio: Sets GPIO and oscillates a GPIO in order to be able to find it.
")
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2] gnu: Add sunxi-tools.
2016-10-04 10:07 ` Danny Milosavljevic
@ 2016-10-04 13:15 ` Ludovic Courtès
2016-10-04 14:38 ` Vincent Legoll
2016-10-05 3:03 ` [PATCH v3] " Danny Milosavljevic
0 siblings, 2 replies; 12+ messages in thread
From: Ludovic Courtès @ 2016-10-04 13:15 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: guix-devel
Danny Milosavljevic <dannym@scratchpost.org> skribis:
>> I don’t understand this description. Since “Tools”, “manage”, and
>> “devices” could mean anything, could you add qualifiers to give more
>> context, like:
>>
>> “Frobbing tools for Allwinner A10 foobar devices”
>>
>> and similarly expound the description (with a period at the end of the
>> sentence)?
>>
>> Based on that, we might device that admin.scm is not the best fit for
>> this package. Maybe flashing-tools.scm?
>
> The tools included are:
I’m not asking that you explain it to me personally ;-), but rather that
the description conveys a message that makes sense both for the domain
expert and the passerby.
https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html
> So how about this description:
>
> (description "This package contains tools for Allwinner A10 devices:
> - sunxi-fexc, bin2fex, fex2bin: Compile a textual description of a board (.fex) to a binary representation (.bin).
> - sunxi-fel: Puts a Allwinner A10 device into FEL mode which makes it register as a special USB device (rather than USB host). You can then connect it to another computer and flash it from there.
> - sunxi-nand-part: Partitions NAND flash.
> - sunxi-bootinfo: Reads out boot0 and boot1 information. These are the bootloaders before U-Boot.
> - sunxi-pio: Sets GPIO and oscillates a GPIO in order to be able to find it.
> ")
Sure. Make sure to use @enumerate/@item for the list, and @command for
the command names.
This still doesn’t address the synopsis issue as I wrote above. What
about this synopsis:
Hardware management tools for Allwinner A10 single-board computers
?
Please send a patch the addresses this and I’ll happily apply it!
Ludo’.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] gnu: Add sunxi-tools.
2016-10-04 13:15 ` Ludovic Courtès
@ 2016-10-04 14:38 ` Vincent Legoll
2016-10-05 3:03 ` [PATCH v3] " Danny Milosavljevic
1 sibling, 0 replies; 12+ messages in thread
From: Vincent Legoll @ 2016-10-04 14:38 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Hello,
On Tue, Oct 4, 2016 at 3:15 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> This still doesn’t address the synopsis issue as I wrote above. What
> about this synopsis:
>
> Hardware management tools for Allwinner A10 single-board computers
>
> ?
LGTM, but are those only for A10 ? I used some fex2bin/bin2fex on AW
H3 I think...
--
Vincent Legoll
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3] gnu: Add sunxi-tools.
2016-10-04 13:15 ` Ludovic Courtès
2016-10-04 14:38 ` Vincent Legoll
@ 2016-10-05 3:03 ` Danny Milosavljevic
2016-10-05 16:51 ` Ludovic Courtès
1 sibling, 1 reply; 12+ messages in thread
From: Danny Milosavljevic @ 2016-10-05 3:03 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
* gnu/packages/admin.scm (sunxi-tools): New variable.
---
gnu/packages/admin.scm | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 56 insertions(+)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-sunxi-tools.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-sunxi-tools.patch", Size: 2842 bytes --]
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 4fcc05a..c5e67b0 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -1865,3 +1865,59 @@ Kerberos and Heimdal and FAST is supported with recent MIT Kerberos.")
(license license:gpl1+)))
;;http://archives.eyrie.org/software/kerberos/pam-krb5-4.7.tar.xz
+
+(define-public sunxi-tools
+ (package
+ (name "sunxi-tools")
+ (version "1.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/linux-sunxi/"
+ "sunxi-tools/archive/v" version ".tar.gz"))
+ (sha256
+ (base32 "1iazm28gws1i8sls3gxwc5p108n56ags287zmh1rpvkn2k1az81a"))
+ (modules '((guix build utils)))
+ (snippet
+ ;; Remove binaries contained in the tarball which are only for the
+ ;; target and can be regenerated anyway.
+ '(delete-file-recursively "bin"))))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
+ `(("libusb" ,libusb)))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; no tests exist
+ #:make-flags (list (string-append "PREFIX="
+ (assoc-ref %outputs "out"))
+ "TARGET_TOOLS=sunxi-pio sunxi-meminfo"
+ "CROSS_COMPILE=")
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'fix-Makefile
+ (lambda _
+ (substitute* "Makefile"
+ ;; Upstream adds Makefile and config.h as dependencies
+ ;; of all their tools which means $^ would pass them to gcc.
+ ;; gcc won't know what to do with a Makefile.
+ (("-o [$][@] [$]\\^") "-o $@ meminfo.c"))
+ #t))
+ (delete 'configure))))
+ (home-page "https://github.com/linux-sunxi/sunxi-tools")
+ (synopsis "Hardware management tools for Allwinner computers")
+ (description "This package contains tools for Allwinner devices:
+@enumerate
+@item @command{sunxi-fexc}, @command{bin2fex}, @command{fex2bin}: Compile
+a textual description of a board (.fex) to a binary representation (.bin).
+@item @command{sunxi-fel}: Puts an Allwinner device into FEL mode which
+makes it register as a special USB device (rather than USB host).
+You can then connect it to another computer and flash it from there.
+@item @command{sunxi-nand-part}: Partitions NAND flash.
+@item @command{sunxi-bootinfo}: Reads out boot0 and boot1 (Allwinner
+bootloader) parameters.
+@item @command{sunxi-pio}: Sets GPIO parameters and oscillates a GPIO
+in order to be able to find it.
+@item @command{sunxi-meminfo}: Prints memory bus settings.
+@end enumerate")
+ (license license:gpl2+)))
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v3] gnu: Add sunxi-tools.
2016-10-05 3:03 ` [PATCH v3] " Danny Milosavljevic
@ 2016-10-05 16:51 ` Ludovic Courtès
0 siblings, 0 replies; 12+ messages in thread
From: Ludovic Courtès @ 2016-10-05 16:51 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: guix-devel
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * gnu/packages/admin.scm (sunxi-tools): New variable.
> ---
> gnu/packages/admin.scm | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 56 insertions(+)
Pushed, thanks!
In the future, could you please avoid the option of ‘git send-email’
that makes the patch body a MIME attachment? TIA. :-)
Ludo’.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-10-05 16:51 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-29 11:02 [PATCH] gnu: Add sunxi-tools Danny Milosavljevic
2016-10-02 1:54 ` Leo Famulari
2016-10-02 9:54 ` Danny Milosavljevic
2016-10-02 9:57 ` Vincent Legoll
2016-10-02 10:01 ` Danny Milosavljevic
2016-10-02 9:58 ` [PATCH v2] " Danny Milosavljevic
2016-10-04 9:19 ` Ludovic Courtès
2016-10-04 10:07 ` Danny Milosavljevic
2016-10-04 13:15 ` Ludovic Courtès
2016-10-04 14:38 ` Vincent Legoll
2016-10-05 3:03 ` [PATCH v3] " Danny Milosavljevic
2016-10-05 16:51 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).