From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Display diffs between generations. Date: Thu, 20 Oct 2016 14:36:52 +0200 Message-ID: <87funrci3f.fsf@gnu.org> References: <87eg59izmw.fsf@gnu.org> <87d1kry22u.fsf@gnu.org> <87inuj5r5v.fsf@gnu.org> <87y43ck6dz.fsf@gnu.org> <87a8frq0n5.fsf@gnu.org> <87lgz78v4d.fsf@gnu.org> <87eg3ogd5l.fsf@gnu.org> <87r37nxshp.fsf@gnu.org> <8760opeskj.fsf@gnu.org> <87wph43x8x.fsf@gnu.org> <87vawo57sn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxCag-0003n9-2z for guix-devel@gnu.org; Thu, 20 Oct 2016 08:36:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxCad-0005B5-0x for guix-devel@gnu.org; Thu, 20 Oct 2016 08:36:58 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxCac-0005As-TV for guix-devel@gnu.org; Thu, 20 Oct 2016 08:36:54 -0400 In-Reply-To: <87vawo57sn.fsf@gnu.org> (Roel Janssen's message of "Wed, 19 Oct 2016 23:48:56 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel Roel Janssen skribis: > Ludovic Court=C3=A8s writes: [...] >> I don=E2=80=99t think so. The old behavior will always be available by >> specifying a single generation anyway: >> >> guix package --list-generations=3D42 >> >> It may be worth mentioning this in the manual. >> >> My understanding of the discussion referred above is that people were >> fine with that (or indifferent ;-)). > > Then the following patch should be it. I applied your genius > suggestions of using @code{display-entry} instead of > @code{display-entries}. I learned something new again today. :-) Heh. :-) >>From 5630a512f16c6677fd5b0b8085e2ef15cb10499b Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Wed, 19 Oct 2016 23:38:11 +0200 > Subject: [PATCH] guix package: Display generation diffs. > > * guix/ui.scm (display-profile-content-diff): New variable. > * guix/scripts/package.scm (process-query): Use display-profile-content-d= iff. The code LGTM, but it doesn=E2=80=99t implement the behavior I suggested ab= ove for --list-generations=3D42, which I think I didn=E2=80=99t explain correct= ly. I think what I=E2=80=99m suggesting is that the first matching generation s= hould be displayed in full using =E2=80=98display-profile-content=E2=80=99, and s= ubsequent generations would be displayed as a diff. Thus, when viewing a single generation, as with --list-generations=3D42, we=E2=80=99d only display the full contents of that generation. Does that make sense? Sorry for not clarifying this in the first place! I guess that wasn=E2=80= =99t entirely clear to me either. ;-) Thanks, Ludo=E2=80=99.