From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH v2 2/3] gnu: Add hidapi. Date: Fri, 28 Oct 2016 08:19:42 +0200 Message-ID: <87funhf11d.fsf@elephly.net> References: <20161026210807.27390-1-theodoros.for@openmailbox.org> <20161026210807.27390-3-theodoros.for@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c00WB-0008FN-VY for guix-devel@gnu.org; Fri, 28 Oct 2016 02:19:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c00W7-0006C5-Cf for guix-devel@gnu.org; Fri, 28 Oct 2016 02:19:55 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21327) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c00W7-0006BE-3k for guix-devel@gnu.org; Fri, 28 Oct 2016 02:19:51 -0400 In-reply-to: <20161026210807.27390-3-theodoros.for@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Theodoros Foradis Cc: guix-devel@gnu.org Theodoros Foradis writes: > * gnu/packages/hidapi.scm: New file. > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. > --- > gnu/local.mk | 1 + > gnu/packages/hidapi.scm | 63 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 64 insertions(+) > create mode 100644 gnu/packages/hidapi.scm > > diff --git a/gnu/local.mk b/gnu/local.mk > index ff2d976..9019b98 100644 > --- a/gnu/local.mk > +++ b/gnu/local.mk > @@ -178,6 +178,7 @@ GNU_SYSTEM_MODULES = \ > %D%/packages/gxmessage.scm \ > %D%/packages/haskell.scm \ > %D%/packages/hexedit.scm \ > + %D%/packages/hidapi.scm \ > %D%/packages/hugs.scm \ > %D%/packages/hurd.scm \ > %D%/packages/ibus.scm \ > diff --git a/gnu/packages/hidapi.scm b/gnu/packages/hidapi.scm > new file mode 100644 > index 0000000..88e5eba > --- /dev/null > +++ b/gnu/packages/hidapi.scm > @@ -0,0 +1,63 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright © 2016 Theodoros Foradis > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages hidapi) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module ((guix licenses) #:prefix license:) > + #:use-module (guix build-system gnu) > + #:use-module (gnu packages) > + #:use-module (gnu packages autotools) > + #:use-module (gnu packages libusb) > + #:use-module (gnu packages linux) > + #:use-module (gnu packages pkg-config)) > + > +(define-public hidapi > + (package > + (name "hidapi") > + (version "0.8.0-rc1") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/signal11/hidapi/archive/hidapi-" > + version ".tar.gz")) > + (sha256 > + (base32 > + "0qdgyj9rgb7n0nk3ghfswrhzzknxqn4ibn3wj8g4r828pw07451w")))) > + (build-system gnu-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (add-before 'configure 'bootstrap > + (lambda _ > + (zero? (system* "autoreconf" "-vfi"))))))) > + (inputs > + `(("libusb" ,libusb) > + ("udev" ,eudev))) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool) > + ("pkg-config" ,pkg-config))) > + (home-page "http://www.signal11.us/oss/hidapi/") > + (synopsis "HID API library") > + (description > + "HIDAPI is a library which allows an application to interface with USB and Bluetooth > + HID-Class devices.") There should be no indentation for the continuing line starting with “HID-Class”. I wonder, should this rather go to “libusb.scm”? Having a separate module just for this one package seems a little excessive :) > + (license (list license:gpl3 ;HIDAPI can be used under one of > three licenses. I’d move the comment above the “license” field because it doesn’t apply to the GPL in particular. > + license:bsd-3 > + license:non-copyleft)))) ;LICENSE-orig.txt - permissive license “non-copyleft” takes at least one argument. In this case this would be (license:non-copyleft "file://LICENCE-orig.txt") There’s no need to mention that it’s a “permissive” (or “push-over”) license, because that’s what non-copyleft already states. ~~ Ricardo