From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: ng0 <ngillmann@runbox.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/4] gnu: Add perl-net-psyc.
Date: Sun, 30 Oct 2016 06:54:57 +0100 [thread overview]
Message-ID: <87fune9ya6.fsf@mdc-berlin.de> (raw)
In-Reply-To: <20160929103810.10273-1-ngillmann@runbox.com>
ng0 <ngillmann@runbox.com> writes:
> * gnu/packages/psyc.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> ---
> gnu/local.mk | 1 +
> gnu/packages/psyc.scm | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 106 insertions(+)
> create mode 100644 gnu/packages/psyc.scm
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index b864ea9..d49d458 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -296,6 +296,7 @@ GNU_SYSTEM_MODULES = \
> %D%/packages/pumpio.scm \
> %D%/packages/pretty-print.scm \
> %D%/packages/protobuf.scm \
> + %D%/packages/psyc.scm \
> %D%/packages/pv.scm \
> %D%/packages/python.scm \
> %D%/packages/qemu.scm \
> diff --git a/gnu/packages/psyc.scm b/gnu/packages/psyc.scm
> new file mode 100644
> index 0000000..4d53dfd
> --- /dev/null
> +++ b/gnu/packages/psyc.scm
Could you add this to “messaging” instead?
> @@ -0,0 +1,105 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2016 ng0 <ngillmann@runbox.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages psyc)
> + #:use-module (guix download)
> + #:use-module ((guix licenses) #:prefix license:)
> + #:use-module (guix packages)
> + #:use-module (guix build-system perl)
> + #:use-module (gnu packages)
> + #:use-module (gnu packages ncurses)
> + #:use-module (gnu packages perl)
> + #:use-module (gnu packages web))
> +
> +(define-public perl-net-psyc
> + (package
> + (name "perl-net-psyc")
> + (version "1.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "http://perl.psyc.eu/"
> + "perlpsyc-" version ".zip"))
> + (file-name (string-append name "-" version ".zip"))
> + (sha256
> + (base32
> + "1lw6807qrbmvzbrjn1rna1dhir2k70xpcjvyjn45y35hav333a42"))
> + ;; psycmp3 currently depends on MP3::List and rxaudio
> (shareware),
Let’s just call this “non-free”.
> + ;; we can add it back when this is no longer the case.
> + (snippet '(delete-file "contrib/psycmp3"))))
> + (build-system perl-build-system)
> + (inputs
> + `(("perl-curses" ,perl-curses)
> + ("perl-io-socket-ssl" ,perl-io-socket-ssl)))
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (delete 'configure) ; No configure script
> + ;; There is a Makefile, but it does not install everything
> + ;; (leaves out psycion) and says
> + ;; "# Just to give you a rough idea". XXX: Fix it upstream.
Since you appear to be involved with the project surrounding psyced
could you send a fix upstream instead of building a custom install phase
here?
> + (replace 'build
> + (lambda _
> + (zero? (system* "make" "manuals"))))
This might need a comment. By default the “build” phase runs the
“Build” script if it exists or runs the default gnu-build-system’s build
phase. If the only buildable thing really are the manuals (which would
be odd), then this should be a make-flag.
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (doc (string-append out "/share/doc/perl-net-psyc"))
> + (man1 (string-append out "/share/man/man1"))
> + (man3 (string-append out "/share/man/man3"))
> + (bin (string-append out "/bin"))
> + (libpsyc (string-append out "/lib/psyc/ion"))
> + (libperl (string-append out "/lib/perl5/site_perl/"
> + ,(package-version perl))))
> +
> + (copy-recursively "lib/perl5" libperl)
> + (copy-recursively "lib/psycion" libpsyc)
> + (copy-recursively "bin" bin)
> + (install-file "cgi/psycpager" (string-append doc "/cgi"))
> + (copy-recursively "contrib" (string-append doc "/contrib"))
> + (copy-recursively "hooks" (string-append doc "/hooks"))
> + (copy-recursively "sdj" (string-append doc "/sdj"))
> + (install-file "README.txt" doc)
> + (install-file "TODO.txt" doc)
> + (copy-recursively "share/man/man1" man1)
> + (copy-recursively "share/man/man3" man3)
> + #t)))
> + (add-after 'install 'wrap-programs
> + (lambda* (#:key outputs #:allow-other-keys)
> + ;; Make sure all executables in "bin" find the Perl modules
> + ;; provided by this package at runtime.
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin/"))
> + (path (getenv "PERL5LIB")))
> + (for-each (lambda (file)
> + (wrap-program file
> + `("PERL5LIB" ":" prefix (,path))))
> + (find-files bin "\\.*$"))
> + #t))))))
> + (description
> + "@code{Net::PSYC} with support for TCP, UDP, Event.pm, @code{IO::Select} and
> +Gtk2 event loops. This package includes 12 applications and additional scripts:
> +psycion (a @uref{http://about.psyc.eu,PSYC} chat client), remotor (a control console
> +for @uref{https://torproject.org,tor} router) and many more.")
Please use full sentences. Please also say what it’s used for.
> + (synopsis "Perl implementation of PSYC protocol")
> + (home-page "http://perlpsyc.pages.de")
> + (license (list license:gpl2 (package-license perl)
What is GPLv2 only and what code does the Perl license apply to?
> + ;; contrib/irssi-psyc.pl:
> + license:public-domain
> + ;; bin/psycplay states AGPL with no version:
> + license:agpl3+))))
~~ Ricardo
prev parent reply other threads:[~2016-10-30 5:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 10:38 [PATCH 1/4] gnu: Add perl-net-psyc ng0
2016-09-29 10:38 ` [PATCH 2/4] gnu: Add libpsyc ng0
2016-10-30 5:57 ` Ricardo Wurmus
2016-09-29 10:38 ` [PATCH 3/4] gnu: Add psyclpc ng0
2016-10-30 6:03 ` Ricardo Wurmus
2016-10-30 12:46 ` ng0
2016-09-29 10:38 ` [PATCH 4/4] gnu: Add psyced ng0
2016-09-29 10:44 ` ng0
2016-10-30 5:42 ` Ricardo Wurmus
2016-10-30 5:48 ` Ricardo Wurmus
2016-10-02 1:46 ` [PATCH 1/4] gnu: Add perl-net-psyc Leo Famulari
2016-10-02 10:35 ` ng0
2016-10-04 2:24 ` Leo Famulari
2016-10-04 8:23 ` ng0
2016-10-04 8:34 ` psyc.scm: new patch series ng0
2016-10-04 8:34 ` [PATCH 1/4] gnu: Add perl-net-psyc ng0
2016-10-04 8:34 ` [PATCH 2/4] gnu: Add libpsyc ng0
2016-10-04 8:34 ` [PATCH 3/4] gnu: Add psyclpc ng0
2016-10-04 8:34 ` [PATCH 4/4] gnu: Add psyced ng0
2016-10-26 11:37 ` Efraim Flashner
2016-10-28 10:04 ` ng0
2016-10-30 5:54 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fune9ya6.fsf@mdc-berlin.de \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=ngillmann@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).