From: Roel Janssen <roel@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 08/16] gnu: Add python-bleach.
Date: Fri, 04 Nov 2016 14:01:03 +0100 [thread overview]
Message-ID: <87fun7flgw.fsf@gnu.org> (raw)
In-Reply-To: <87ins3a62w.fsf@mdc-berlin.de>
Ricardo Wurmus writes:
> Roel Janssen <roel@gnu.org> writes:
>
>> Ricardo Wurmus writes:
>>
>>> * gnu/packages/python.scm (python-bleach, python2-bleach): New
>>> variables.
>>> ---
>>> gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
>>> 1 file changed, 26 insertions(+)
>>>
>>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>>> index 590ba43..a2d3d3c 100644
>>> --- a/gnu/packages/python.scm
>>> +++ b/gnu/packages/python.scm
>>> @@ -6693,6 +6693,32 @@ Jupyter Notebook format and Python APIs for working with notebooks.")
>>> (define-public python2-nbformat
>>> (package-with-python2 python-nbformat))
>>>
>>> +(define-public python-bleach
>>> + (package
>>> + (name "python-bleach")
>>> + (version "1.4.3")
>>> + (source
>>> + (origin
>>> + (method url-fetch)
>>> + (uri (pypi-uri "bleach" version))
>>> + (sha256
>>> + (base32
>>> + "0jvg3jxrvnx7xmm9gj262v60ib452xlnwlb0navyp7jsvcd0d4qj"))))
>>> + (build-system python-build-system)
>>> + (propagated-inputs
>>> + `(("python-html5lib" ,python-html5lib-0.9)
>>
>> If you add the following snippet, it does not need this older version of
>> html5lib to build.
>>
>> (arguments
>> `(#:phases
>> (modify-phases %standard-phases
>> (add-after 'unpack 'fix-html5lib-version
>> (lambda* (#:key inputs #:allow-other-keys)
>> (substitute* "setup.py"
>> (("'html5lib>=0.999,<0.99999999',") "'html5lib',")))))))
>>
>> I don't know whether this modification is problematic later on when
>> running Jupyter (I'm not there yet).
>
> I’d rather not do this, because they purposefully restricted the range.
> It used to be less restrictive, so I’m assuming that there’s a good
> reason for not using the latest version of html5lib.
Yes, I agree. Please ignore my suggestion. I submitted this before you
explained they restricted the version requirement deliberately.
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2016-11-04 12:59 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 12:20 [PATCH 00/16] Add Jupyter Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 01/16] gnu: python-traitlets: Update to 4.2.0 Ricardo Wurmus
2016-11-01 13:19 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 02/16] gnu: Add python-jupyter-core Ricardo Wurmus
2016-11-01 13:22 ` Roel Janssen
2016-11-04 10:21 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 03/16] gnu: Add python-jupyter-client Ricardo Wurmus
2016-11-01 13:27 ` Roel Janssen
2016-11-04 10:22 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 04/16] gnu: Add python-ipykernel Ricardo Wurmus
2016-11-01 13:32 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 05/16] gnu: Add python-testpath Ricardo Wurmus
2016-11-01 13:36 ` Roel Janssen
2016-11-04 10:25 ` Ricardo Wurmus
2016-11-02 8:23 ` Hartmut Goebel
2016-11-04 10:25 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 06/16] gnu: Add python-html5lib-0.9 Ricardo Wurmus
2016-11-01 13:40 ` Roel Janssen
2016-11-01 14:31 ` Ricardo Wurmus
2016-11-01 18:24 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 07/16] gnu: Add python-nbformat Ricardo Wurmus
2016-11-01 14:27 ` Roel Janssen
2016-11-04 10:27 ` Ricardo Wurmus
2016-11-02 8:23 ` Hartmut Goebel
2016-11-04 10:28 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 08/16] gnu: Add python-bleach Ricardo Wurmus
2016-11-01 13:59 ` Roel Janssen
2016-11-04 10:32 ` Ricardo Wurmus
2016-11-04 13:01 ` Roel Janssen [this message]
2016-11-01 14:00 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 09/16] gnu: Add python-entrypoints Ricardo Wurmus
2016-11-01 16:18 ` Roel Janssen
2016-11-02 8:23 ` Hartmut Goebel
2016-11-04 16:54 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 10/16] gnu: Add python-nbconvert Ricardo Wurmus
2016-11-01 16:23 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 11/16] gnu: Add python-notebook Ricardo Wurmus
2016-11-01 18:10 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 12/16] gnu: Add python-widgetsnbextension Ricardo Wurmus
2016-11-01 18:11 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 13/16] gnu: Add python-ipywidgets Ricardo Wurmus
2016-11-01 18:12 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 14/16] gnu: Add python-jupyter-console Ricardo Wurmus
2016-11-01 18:15 ` Roel Janssen
2016-11-04 16:47 ` Ricardo Wurmus
2016-11-04 17:40 ` Roel Janssen
2016-11-04 17:49 ` Hartmut Goebel
2016-11-01 12:20 ` [PATCH 15/16] gnu: python-ipython: Update to 4.0.0 Ricardo Wurmus
2016-11-01 18:18 ` Roel Janssen
2016-11-04 17:10 ` Ricardo Wurmus
2016-11-04 17:43 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 16/16] gnu: Add jupyter Ricardo Wurmus
2016-11-01 18:20 ` Roel Janssen
2016-11-04 20:26 ` Ricardo Wurmus
2016-11-01 13:16 ` [PATCH 00/16] Add Jupyter Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fun7flgw.fsf@gnu.org \
--to=roel@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).