From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: Let non-root users use MTP devices (Attempt #2) Date: Thu, 29 Dec 2016 16:41:10 -0800 Message-ID: <87ful6xn89.fsf@gmail.com> References: <87mvfggv4k.fsf@gmail.com> <20161229090121.3718-1-cmmarusich@gmail.com> <871swrf3cm.fsf@gmail.com> <871swqe4k6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMlG1-0003Uk-P2 for guix-devel@gnu.org; Thu, 29 Dec 2016 19:41:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMlG0-0004iU-L0 for guix-devel@gnu.org; Thu, 29 Dec 2016 19:41:17 -0500 In-Reply-To: <871swqe4k6.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 29 Dec 2016 23:48:00 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Chris Marusich skribis: > >> Chris Marusich writes: >> >>> Here's a second attempt to fix MTP support for GuixSD. It's simple and >>> requires no special group permissions. >>> >>> It turns out that elogind (like systemd's logind) can be compiled with >>> support for ACLs (provided by libacl), in which case elogind will >>> automatically set an ACL on a device file granting access to a user when >>> that user is logged in using a seat to which the device is attached. In >>> short, by adding acl as an input to elogind, users will be able to >>> access devices without running programs as root, and without being a >>> member of any special group. >>> >>> That's just one piece of the puzzle, though. The other piece is the >>> udev rules provided by libmtp. It's necessary to install those udev >>> rules; if we don't, then the MTP device won't be tagged properly, so >>> elogind will not set any ACLs for it. I've chosen to install those >>> rules by modifying the base services in desktop.scm so that all desktops >>> will get the rules, not just GNOME; if you know of a better way to >>> install them, please let me know. >>> >>> This patch has a happy side effect. Namely: because elogind is now >>> setting ACLs, it gives a user access to other devices that are attached >>> to their seat. For instance, after this change, I can access /dev/kvm >>> and /dev/cdrom (and other devices) without being root, and without being >>> in any special group. How nice! >> >> After sending this, I've noticed something odd: sometimes, it can take >> quite a while for elogind to set the ACLs. It's a bit of a mystery to >> me. I'm not sure how/when elogind decides to update the ACLs; I assumed >> it was continuously checking for changes in the hardware or receiving >> notifications about hardware changes, but it seems like elogind isn't >> noticing when I plug in my phone. Even though the device file shows up, >> elogind doesn't set the ACLs unless I do something. >> >> By "do something," I mean: Apparently, logging out and logging back in >> seems to trigger elogind to set the ACLs. Even just switching virtual >> terminals (i.e., Control + F1, followed by Control + F7) seems to >> trigger it, which is weird. Even when elogind has not yet set the ACLs, >> the "uaccess" tag has in fact been correctly set for the device (as >> reported by e.g. "udevadm info /dev/libmtp-1-1"), which leads me to >> suspect that elogind is either failing to notice or just ignoring the >> hardware change. I wonder if this might be a bug of some kind. >> >> What do you think we should do? > > Good question! I don=E2=80=99t know. Does this happen only for MTP devi= ces or > also with other things (KVM?)? Yes, this happens for other devices, too. For example, I observe exactly the same behavior for /dev/sr0 when I plug in an external CD-ROM drive (via USB cable) after logging in. The ACL doesn't get set until after I do something like switch to another virtual terminal and back. > Does =E2=80=9Cudevadm settle=E2=80=9D trigger the ACL change? No, neither "udevadm settle" nor "sudo udevadm settle" triggers the ACL change. I suspect that maybe elogind is ignoring or failing to notice the new device, or perhaps the mechanism that elogind relies on to learn about new devices is not working for some reason. It looks like elogind sets the ACLs via devnode_acl_all, defined in src/login/logind-acl.c. Ultimately it seems this gets called while in seat_set_active (specifically, invoked at src/login/logind-seat.c:213), under certain conditions. That's as far as I got. I cannot reproduce this issue on Ubuntu; there, the ACL gets set promptly. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlhlrScACgkQ3UCaFdgi Rp2VJBAAuIPsrckce8S75IeyJWWvcKE0e/sKjb7fpkmMvQyAiJ4XKWwyGK0xuNHn gx+FPH/bIeybaOemJklH4F+TP1O8muCkzhLLPvoP3lrpj7gMuThruzXKVsTYIHYb 2Cm9fE9U4stFNCVlUrrRuFqS9grtrd05Z/2Hwr2DYFNiq45y3Dpdr1mus9NEv3iZ PAMiZB9tE8NSMoGKevo90XLQUDTBaHGuk9UOphWZ7QijCB/dTfNm7IXVbzpffa4u 8XOtsNk3ISimFMx+6P3f/moj27jtmMJnl65ayVgQV7iIKpnlyW7hMJ4gGusRJrV3 xQMxwvlrodYzmd0h9i0j7mhk6YutB9ZIWBkXPvYmIWzIHKh9WFDK+vPiZBctcxP1 5ss5n5DxEKPh6Rv6nQsOcOYUG1EboWhyKWX18iV15cP7+akPdUGifDGYnTStO5R1 Aap3X4yRPF/T9x6JcAtDWwEaRK/ry188tYNPZFyjnKIZxGlxTNqzMiFZvVRTUn3x ZRQXi+MtElqcnSEkpxlJtxfKc+IsQxtsAkh6+NjlSBv7WXhh8ExvEXjCi5x59FqC DRZkK059zoXIGPtxwPlufghRgHaAJmB2SAdPW36YUjO48roi9eE8mLH2JTBb/00z r9YP4/nzasq99l5znSkjFBzhLMd6bZUeM134Y2yZlls/qFuGbWQ= =WczD -----END PGP SIGNATURE----- --=-=-=--