From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: [PATCH] gnu: sed: Update to 4.3.
Date: Thu, 05 Jan 2017 15:23:03 +0100
Message-ID: <87fukxy4ag.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
References: <20170104160134.28283-1-mbakke@fastmail.com>
	<20170104201638.GC7042@jasmine>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1cP8wf-0002ub-OB
	for guix-devel@gnu.org; Thu, 05 Jan 2017 09:23:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1cP8wb-0005D4-Ra
	for guix-devel@gnu.org; Thu, 05 Jan 2017 09:23:09 -0500
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:34013)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mbakke@fastmail.com>) id 1cP8wb-0005Cp-Lh
	for guix-devel@gnu.org; Thu, 05 Jan 2017 09:23:05 -0500
In-Reply-To: <20170104201638.GC7042@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

--=-=-=
Content-Type: text/plain

Leo Famulari <leo@famulari.name> writes:

> On Wed, Jan 04, 2017 at 05:01:34PM +0100, Marius Bakke wrote:
>> * gnu/packages/base.scm (sed): Update to 4.3.
>> [source]: Use xz tarball. Remove upstreamed patch.
>> [home-page]: Use https.
>> [native-inputs]: Add perl.
>> * gnu/packages/patches/sed-hurd-path-max.patch: Delete file.
>> * gnu/local.mk (dist_patch_DATA): Remove it.
>
> Thanks!
>
> We should make sure that the built package doesn't retain a reference to
> Perl.

Thanks for checking (in the other email!) :-)

> It's interesting that `guix refresh -l sed` doesn't show the full impact
> of this change:
>
> $ guix refresh -l sed
> Building the following 4 packages would ensure 4 dependent packages are rebuilt: password-store-1.6.5 hydra-20151030.1ff48da bamm-1.7.3 roary-3.7.0
>
> Also, this part of the package definition is incorrect:
>
> (substitute* '("testsuite/bsd.sh"
>                "testsuite/bug-regex9.c")
>   (("/bin/sh")
>    (string-append bash "/bin/bash")))
> #t)))))))
>
> Bash and sh behave differently; the replacement string should refer to
> '/bin/sh'.

Good catch! I fixed this too and pushed to 'core-updates' as
7d7ea947f56e5080c9913f311ede71475045b9d6 .

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlhuVscACgkQoqBt8qM6
VPpkYAf/Zo94QMGJL0xDwqlCkolB6iaHxq70vIHgt3NhvwVrSWb8BESOEmbjVQpI
V5LOGfw+3IBkjcbpTjxoY7zjf6VoVq/So/kw2318kZIdwvNqLB0d8xAzU4hBwUmY
NrgAoQAxy8Q4uGMshw6VFLscfdv1vxlczNFsQ545kDPjmJTdvPaw6AkPr0yQ4+0t
aD5z0hdCTXYurguAHBGr8pROnizzbelbvh4hCGsAAUmbkX8fVYIphX9cAqLx9L57
u0SmZX3nWsiUiiKgWhiDVQZrkdO+MZiiMzPEu3c6IhlQ7AFcO5HGlS2Z1x+JosTD
VNATccSNZo2NDszk/gAP2wBibtFNeQ==
=cVmK
-----END PGP SIGNATURE-----
--=-=-=--