From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 2/2] gnu: Add notmuch-vim. Date: Sun, 15 Jan 2017 20:16:24 +0100 Message-ID: <87fukkxhfb.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20170114150811.21767-1-ng0@libertad.pw> <20170114150811.21767-3-ng0@libertad.pw> <87lgud4knh.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87sholedj7.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cSqI3-000772-AS for guix-devel@gnu.org; Sun, 15 Jan 2017 14:16:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cSqHz-0000W2-5R for guix-devel@gnu.org; Sun, 15 Jan 2017 14:16:31 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:48154) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cSqHz-0000Vy-0c for guix-devel@gnu.org; Sun, 15 Jan 2017 14:16:27 -0500 In-Reply-To: <87sholedj7.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ng0 writes: > Marius Bakke writes: > >> ng0 writes: >> >>> * gnu/packages/mail.scm (notmuch-vim): New variable. >>> --- >>> gnu/packages/mail.scm | 37 ++++++++++++++++++++++++++++++++++++- >>> 1 file changed, 36 insertions(+), 1 deletion(-) >>> >>> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm >>> index 206055751..89aa2444d 100644 >>> --- a/gnu/packages/mail.scm >>> +++ b/gnu/packages/mail.scm >>> @@ -15,7 +15,7 @@ >>> ;;; Copyright =C2=A9 2016 Lukas Gradl >>> ;;; Copyright =C2=A9 2016 Alex Kost >>> ;;; Copyright =C2=A9 2016 Troy Sankey >>> -;;; Copyright =C2=A9 2016 ng0 >>> +;;; Copyright =C2=A9 2016, 2017 ng0 >>> ;;; Copyright =C2=A9 2016 Cl=C3=A9ment Lassieur >>> ;;; Copyright =C2=A9 2016 Arun Isaac >>> ;;; Copyright =C2=A9 2016 John Darrington >>> @@ -71,6 +71,7 @@ >>> #:use-module (gnu packages perl) >>> #:use-module (gnu packages python) >>> #:use-module (gnu packages readline) >>> + #:use-module (gnu packages ruby) >>> #:use-module (gnu packages search) >>> #:use-module (gnu packages texinfo) >>> #:use-module (gnu packages compression) >>> @@ -83,6 +84,7 @@ >>> #:use-module (gnu packages screen) >>> #:use-module (gnu packages tls) >>> #:use-module (gnu packages networking) >>> + #:use-module (gnu packages vim) >>> #:use-module (gnu packages web) >>> #:use-module (gnu packages xml) >>> #:use-module (gnu packages xorg) >>> @@ -587,6 +589,39 @@ invoking @command{notifymuch} from the post-new ho= ok.") >>> ing, and tagging large collections of email messages.") >>> (license gpl3+))) >>>=20=20 >>> +(define-public notmuch-vim >>> + (package >>> + (name "notmuch-vim") >>> + (version (package-version notmuch)) >>> + ;; The vim plugin is distributed via the notmuch release tarball. >>> + (source (package-source notmuch)) >>> + (build-system gnu-build-system) >>> + (propagated-inputs >>> + ;; XXX: This is a plugin, it will not be functional without >>> + ;; vim-full (ruby), ruby-mail, and notmuch. >>> + `(("notmuch" ,notmuch) >>> + ("vim-full" ,vim-full) >> >> I think if someone installs this plugin, they already have vim and >> notmuch, and may want to use other versions etc. So those can be >> omitted. >> >>> + ("ruby-mail" ,ruby-mail))) >>> + (arguments >>> + `(#:tests? #f ; no "test" target >>> + ;; XXX: Replace the "vim80" folder with a dynamic name. >>> + #:make-flags (list (string-append "prefix=3D" >>> + (assoc-ref %outputs "out") >>> + "/share/vim/vim80")) >> ^^ >> You can use (version-major+minor (package-version vim)) here. > > That's not the same as vim80 though... resulting structure: Oops, you're right. I forgot that the dot was included. Let's just keep it 'hard-coded' for now. We can add a helper function to determine the correct directory if/when this becomes a problem / recurring theme. Yet another reason to put it in vim.scm.. ;-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlh7yogACgkQoqBt8qM6 VPrtvQgAhxos9VCGiN+kUdwBpd3teCoJ7dbwk4K1anaqBzgto9lZT52KRRb/dNdv DNd/U568J/vmoC0iNud7NqS00B5TdPAyXtU5RBK7/aEHT8Vl/ifIm628ut+fg5Br t6WH1rjamBD/Vv1rbolufb+ZpGE7kzO8X3Jq8UDfQuQDteg7/oc7CanJyOLEDhjf 0jTGNVPXxAAVTjMwG8vuqMsexUMa5dG2YwHff38lqLhJPzE+sdMDDK7kSxoJ203h 9s08IOOBjewTtePW0bNOTSgcY0mzJtNovrG1pshVVsQ0zGO3aKIsSWMr8VyVt+NA W6cAUAdOFtAnTShxe6mpheInm3X3bw== =Vppy -----END PGP SIGNATURE----- --=-=-=--