From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 4/6] gnu: Add rocksdb.
Date: Tue, 17 Jan 2017 23:42:38 +0100
Message-ID: <87fukhb95t.fsf@gnu.org>
References: <20170115203338.19769-1-mbakke@fastmail.com>
	<20170115203338.19769-5-mbakke@fastmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48415)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cTcSj-0001xr-Nf
	for guix-devel@gnu.org; Tue, 17 Jan 2017 17:42:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cTcSe-0007CB-Oz
	for guix-devel@gnu.org; Tue, 17 Jan 2017 17:42:45 -0500
In-Reply-To: <20170115203338.19769-5-mbakke@fastmail.com> (Marius Bakke's
	message of "Sun, 15 Jan 2017 21:33:36 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> * gnu/packages/databases.scm (rocksdb): New variable.

[...]

> +           (lambda* (#:key (make-flags '()) #:allow-other-keys)
> +             ;; Prevent the build from adding machine-specific optimizat=
ions.
> +             ;; This does not work if passed as a make flag...
> +             (setenv "PORTABLE" "1")
> +             (and (zero? (apply system* "make" "static_lib" make-flags))
> +                  (zero? (apply system* "make" "shared_lib" make-flags))=
)))

We could avoid building the static libs if nothing requires it; no
strong opinion though.

> +    (home-page "http://rocksdb.org/")
> +    (synopsis "Persistent key-value store for fast storage")
> +    (description
> +     "RocksDB is an embeddable, persistent key-value storage library tha=
t is
> +designed for flash and RAM storage.")

Could you expound a little bit?

LGTM!

Ludo=E2=80=99.