From: Marius Bakke <mbakke@fastmail.com>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: python2-traceback2, python2-linecache2
Date: Thu, 19 Jan 2017 16:01:43 +0100 [thread overview]
Message-ID: <87fukf6qlk.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20170119153412.6cacee8d@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]
Danny Milosavljevic <dannym@scratchpost.org> writes:
> Hi,
>
>> The traceback2 module works on python3 as well. I don't think patching
>> imports will be necessary?
>
> Maybe it works. However, I think it's silly to package a "traceback"
> module for Python 3.5 which is a backport of the "traceback" module
> included in the CPython 3.5 interpreter when we use the CPython 3.5
> interpreter in the first place.
There are other modules extracted from python3 and packaged for
python2+3. "enum34", "contextlib2", etc. AFAICT traceback was added
already in 3.0: https://docs.python.org/3.0/library/traceback.html
> Same for python-linecache2.
>
> Therefore, I would have another patchset which adds them for Python 2
> only and patches them out otherwise (s/traceback2/traceback/g).
If a module written for python3 imports "traceback2", that won't work
anyway with the standard library since it's called just "traceback". I
would much rather package a "superfluous" module, instead of
conditionally patching packages to use the built-in for python3 only.
> Adding them for Python 3.5 would just be asking for them to become
> outdated for no reason (they are part of Python 3.5 and will update
> with it - their origin is Python 3.5).
>
> That said, I'm happy that this is being discussed - I'm not sure what
> the right way to go forward is.
Me neither :-) but it's obviously something we need to tackle
eventually. Copied in Hartmut, maybe he's got some insight?
>>But I see we don't currently have traceback2, so I'm fine with 1.4.0
>>for now just to avoid packaging it. The rest LGTM, let's get this
>>[python-testtools] in!
>
> OK!
...and the rest of this series ;-)
I wonder if we should update scipy and numpy while at it. Thoughts?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-01-19 15:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 23:30 [PATCH] guix: python-build-system: Properly inform caller about test status Danny Milosavljevic
2017-01-05 10:14 ` Hartmut Goebel
2017-01-05 13:31 ` Marius Bakke
2017-01-05 15:49 ` Leo Famulari
2017-01-05 16:06 ` python-tests: Sphinx Danny Milosavljevic
2017-01-05 16:11 ` Marius Bakke
2017-01-18 7:52 ` [PATCH v2 0/6] Make python-oslosphinx work in python-tests branch Danny Milosavljevic
2017-01-18 7:53 ` [PATCH v2 1/6] gnu: python-testtools: Update to 1.4.0 Danny Milosavljevic
2017-01-18 17:39 ` Marius Bakke
2017-01-19 9:28 ` Danny Milosavljevic
2017-01-19 12:59 ` Marius Bakke
2017-01-19 14:34 ` python2-traceback2, python2-linecache2 Danny Milosavljevic
2017-01-19 15:01 ` Marius Bakke [this message]
2017-01-19 17:46 ` Marius Bakke
2017-01-20 19:56 ` 'python-tests' merge Marius Bakke
2017-01-19 20:38 ` python2-traceback2, python2-linecache2 Hartmut Goebel
2017-01-19 20:35 ` Hartmut Goebel
2017-01-19 15:31 ` [PATCH v2 1/6] gnu: python-testtools: Update to 1.4.0 Danny Milosavljevic
2017-01-18 7:53 ` [PATCH v2 2/6] gnu: Add python-fastimport Danny Milosavljevic
2017-01-18 17:39 ` Marius Bakke
2017-01-18 23:43 ` Danny Milosavljevic
2017-01-18 7:53 ` [PATCH v2 3/6] gnu: Add python-dulwich Danny Milosavljevic
2017-01-18 17:48 ` Marius Bakke
2017-01-18 20:57 ` Efraim Flashner
2017-01-19 9:38 ` Danny Milosavljevic
2017-01-19 9:34 ` Danny Milosavljevic
2017-01-19 15:27 ` Danny Milosavljevic
2017-01-18 7:53 ` [PATCH v2 4/6] gnu: Add python-reno Danny Milosavljevic
2017-01-18 17:51 ` Marius Bakke
2017-01-19 15:40 ` Danny Milosavljevic
2017-01-19 16:32 ` Danny Milosavljevic
2017-01-18 7:53 ` [PATCH v2 5/6] gnu: python-mox3: Remove python-oslosphinx dependency (since the tests don't run anyway) Danny Milosavljevic
2017-01-18 17:54 ` Marius Bakke
2017-01-18 23:42 ` Danny Milosavljevic
2017-01-18 7:53 ` [PATCH v2 6/6] gnu: python-sphinx: Update to 1.5.1 and enable tests Danny Milosavljevic
2017-01-18 17:55 ` Marius Bakke
2017-01-18 23:35 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fukf6qlk.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).