From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 00/10] ocaml patches v2 Date: Mon, 30 Jan 2017 10:23:56 +0100 Message-ID: <87fuk0gatv.fsf@gnu.org> References: <20170127221228.4370-1-julien@lepiller.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cY8Bv-0001yl-75 for guix-devel@gnu.org; Mon, 30 Jan 2017 04:24:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cY8Br-00011n-8g for guix-devel@gnu.org; Mon, 30 Jan 2017 04:24:03 -0500 In-Reply-To: <20170127221228.4370-1-julien@lepiller.eu> (Julien Lepiller's message of "Fri, 27 Jan 2017 23:12:18 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Julien Lepiller Cc: guix-devel@gnu.org Hi Julien, Julien Lepiller skribis: > I finally had some time to work on these patches, so here are the new ver= sions of > them. I was unable to fix the failing tests in oasis, so I just disabled = the > failing ones. I=E2=80=99ve looked at the whole series, and apart from the specific commen= ts I wrote, nothing special to declare. Before committing, just make sure =E2=80=98guix lint=E2=80=99 passes on all= these, and double-check the licenses (there are a couple of =E2=80=98lgpl2.0=E2=80=99 = or similar, which means =E2=80=9Cversion 2.0 only=E2=80=9D; this is the case if and onl= y if source file headers or explicitly omit the =E2=80=9Cor any later version=E2=80=9D = wording; otherwise it=E2=80=99s =E2=80=98lgpl2.0+=E2=80=99.) Thank you! Ludo=E2=80=99.