ludo@gnu.org (Ludovic Courtès) writes:

> Hi 宋文武!
>
> 宋文武 <iyzsong@member.fsf.org> skribis:
>
>> * gnu/packages/networking.scm (openvswitch): New variable.
>
> [...]
>
>> +     '(;; FIXME: many tests fail with:
>> +       ;;    […]
>> +       ;;    test -e $OVS_RUNDIR/ovs-vswitchd.pid
>> +       ;;    ovs-appctl -t ovs-vswitchd exit
>> +       ;;    hard failure
>> +       #:tests? #f
>
> Can we assume that the failures are due to the lack of a proper
> networking environment?  Do they pass outside of the chroot?

In `guix environment -C openvswitch` those tests did pass, but more
tests fail due to unable to bind to network address.  In the builder
they can bind and listen successful.

>
> It would be good to have a rough idea of why they fail.

I have no idea and luck for them now...

>
>> +         (replace 'install
>> +           (lambda _
>> +             (zero? (system* "make"
>> +                             "RUNDIR=/tmp"
>> +                             "PKIDIR=/tmp"
>> +                             "LOGDIR=/tmp"
>> +                             "DBDIR=/tmp"
>> +                             "install")))))))
>
> I suppose this is to prevent “mkdir /var/log” or similar, right?
> Perhaps worth mentioning in a comment.
>
> The rest LGTM.

Sure, thanks for review!


Here is the updated patch: