From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: GRUB EFI installation breakage
Date: Wed, 23 Aug 2017 00:25:59 +0200
Message-ID: <87fucjnsso.fsf@gnu.org>
References: <87efs34tfl.fsf@gnu.org> <87shgj2wzx.fsf@fastmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1dkHcZ-0006pw-4Z
	for guix-devel@gnu.org; Tue, 22 Aug 2017 18:26:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1dkHcY-0007Ae-0m
	for guix-devel@gnu.org; Tue, 22 Aug 2017 18:26:03 -0400
In-Reply-To: <87shgj2wzx.fsf@fastmail.com> (Marius Bakke's message of "Tue, 22
	Aug 2017 22:00:50 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel <guix-devel@gnu.org>

Marius Bakke <mbakke@fastmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Hello,
>>
>> To reconfigure my system on UEFI, I had to apply this patch:
>>
>> modified   gnu/bootloader/grub.scm
>> @@ -401,7 +401,8 @@ submenu \"GNU system, old configurations...\" {~%")
>>          ;; root partition.
>>          (setenv "GRUB_ENABLE_CRYPTODISK" "y")
>>          (unless (zero? (system* grub-install "--boot-directory" install=
-dir
>> -                                "--efi-directory" efi-dir))
>> +                                ;; "--efi-directory" efi-dir
>> +                                ))
>>            (error "failed to install GRUB (EFI)")))))
>>=20=20
>>
>> Before that =E2=80=98grub-install=E2=80=99 would fail because =E2=80=98e=
fi-dir=E2=80=99 would actually
>> be =E2=80=9C/dev/sda=E2=80=9D, which is what I have in the =E2=80=98devi=
ce=E2=80=99 field of
>> =E2=80=98grub-configuration=E2=80=99.
>>
>> Removing the =E2=80=9C--efi-directory=E2=80=9D solves the problem becaus=
e =E2=80=98grub-install=E2=80=99
>> automatically determines that the EFI directory is mounted at /boot/efi.
>>
>> I think 2941b347b664a3d3114de0ac95e28db78db66144 is bogus because it
>> assumes that the second argument of the gexp=E2=80=99d lambda is =E2=80=
=98efi-dir=E2=80=99,
>> where in fact it is the =E2=80=98device=E2=80=99 field of the bootloader=
 config.
>>
>> So what is the preferred fix?  Simply remove =E2=80=9C--efi-directory=E2=
=80=9D like I
>> did above, and rename =E2=80=98efi-dir=E2=80=99 to =E2=80=98device=E2=80=
=99 to avoid the ambiguity?
>> Thoughts?
>
> Maybe we could rename "device" to something like "target" and update the
> documentation to mention that "target" means the _mounted_ EFI System
> Partition for grub-efi, but is typically a block device.

You mean it=E2=80=99s a block device except for EFI, right?
So yes, we can rename =E2=80=98device=E2=80=99 to =E2=80=98target=E2=80=99,=
 and we should at least
document what you wrote.

> "device" was a no-op for grub-efi anyway since it autodiscovered
> "/boot/efi", at least now we can choose a different location.

Right.

Do you feel like updating the doc and examples?  :-)

Thanks,
Ludo=E2=80=99.