From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0+guixpatches@n0.is Subject: Re: [bug#30165] [PATCH] gnu: gnurl: Add '--with-ca-bundle' path to configure-flags. Date: Wed, 24 Jan 2018 11:52:55 +0000 Message-ID: <87fu6v1njc.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> References: <87h8rchvfs.fsf@vany.ca> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeJcJ-0006Ga-Df for guix-devel@gnu.org; Wed, 24 Jan 2018 06:53:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeJcG-0006PE-BW for guix-devel@gnu.org; Wed, 24 Jan 2018 06:53:23 -0500 Received: from aibo.runbox.com ([91.220.196.211]:51458) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eeJcG-0006Nt-3z for guix-devel@gnu.org; Wed, 24 Jan 2018 06:53:20 -0500 In-Reply-To: <87h8rchvfs.fsf@vany.ca> (Adam Van Ymeren's message of "Tue, 23 Jan 2018 20:55:35 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Adam Van Ymeren Cc: ng0+guixpatches@n0.is, guix-devel@gnu.org Sorry, my email went out-of-order for the past 7 days. I would've sent an explanation to the patch otherwise. Let me comment inline. adam@vany.ca transcribed Tue 23 Jan 2018 08:55:35 PM UTC bytes: > Regarding https://debbugs.gnu.org/30165 > > gnurl is failing to build on my system and I think this patch is to > blame. Why is gnurl referencing something under the root filesystem > rather something provided by an input? Shouldn't we provided > ca-certificates.crt from an input and reference that? The problem I'm trying to address is the same horror story we have with cURL: We need to be able to reference a certificate store. So far no one in 2+ years fixed this in our cURL to my best knowledge, so my idea as a maintainer of gnURL was to simply apply this to gnURL because someone in GNUnet reported errors with regards to gnURL not finding the certificates with a recent build of gnURL. I though I had this fixed a while ago, but apparently I didn't. I'm more than open to better fixes (we could also set the expected environment variable). > I guess we want to be able to to change what certificates that gnurl > accepts without rebulding the package, but I think we need something to > provide that file when building the package in the first place, or What you seem to want is the env. variable solution. > disable the relelvant tests. > > For reference the build error I'm seeing is > ========================== > test 0324...[TLS-SRP with server cert checking] > > curl returned 77, when expecting 51 > exit FAILED > > - abort tests > > ========================= Wild. For what it's worth, I built this before I've sent a patch and it passed all of its relevant testsuites. I didn't get this error. > From the curl man page, exit code 77 means "Problem with reading the SSL > CA cert (path? access rights?)." May I ask what system you are building on? I have a GuixSD-only setup here. Next time I'll wait for the CI to finish building (Debian based). I'm in the middle of releasing gnURL 7.58.0 and preparing for a test that I have tomorrow, followed by some social appointments afterwards, so I'll be able to start working on a real fix on the weekend. In the meantime you could send a patch to revert my commit. -- ng0 :: https://ea.n0.is A88C8ADD129828D7EAC02E52E22F9BBFEE348588 :: https://ea.n0.is/keys/