From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: 01/01: build-system/meson: Really skip the 'fix-runpath' phase on armhf. Date: Wed, 04 Jul 2018 16:27:55 +0200 Message-ID: <87fu0z849g.fsf@fastmail.com> References: <20180702101757.22792.51026@vcs0.savannah.gnu.org> <20180702101758.97A6020543@vcs0.savannah.gnu.org> <8736x1r1g0.fsf@netris.org> <874lhhwkz7.fsf@fastmail.com> <87a7r8nmuy.fsf@netris.org> <87a7r7e9zg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1failG-0003QU-N4 for guix-devel@gnu.org; Wed, 04 Jul 2018 10:28:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1failC-0006AP-Kz for guix-devel@gnu.org; Wed, 04 Jul 2018 10:28:02 -0400 In-Reply-To: <87a7r7e9zg.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Mark H Weaver Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hello, > > Mark H Weaver skribis: > >> Marius Bakke writes: > > [...] > >>> I'm sorry, I forgot to address your actual concerns. The (buggy) >>> workaround was put in place and discussed in >>> . The meat of it can be found in (guix >>> build-system meson): >>> >>> ;; XXX PatchELF fails to build on armhf, so we skip >>> ;; the 'fix-runpath' phase there for now. It is used >>> ;; to avoid superfluous entries in RUNPATH as described >>> ;; in , so armhf may now >>> ;; have different runtime dependencies from other arches. >> >> Thanks for this, but I'd still like to know the answer to my questions: >> "What does the [fix-runpath] phase accomplish, and how will armhf users >> be disadvantaged by the removal of that phase?" > > As discussed in and > , Meson does not (or did not) adjust > RUNPATHs upon installation (contrary to what Libtool does, for > instance.) > > Consequently, the RUNPATH is left with /tmp/guix-build-=E2=80=A6 entries,= which > is not great but okay, but more importantly if usually lacks OUTPUT/lib > as well. I haven't seen /tmp in RUNPATH during my testing, which would be a *huge* security problem. The only consequence I've noticed from dropping 'fix-runpath' is that it sometimes contain entries that are not in NEEDED (but often required for a "neighbour" library, so no big deal). > However, the commit Marius referred to=C2=B9 as well as what you reported= for > Epiphany in #31974 suggest that things are improving in Meson proper, > and that we might be able to remove that =E2=80=98fix-runpath=E2=80=99 ph= ase altogether > soon. > > I think we should simply try building things without =E2=80=98fix-runpath= =E2=80=99 and > see if =E2=80=98validate-runpath=E2=80=99 reports anything. > > Thoughts? I'm in favor of removing it on all architectures and see how it fares. I suspect the main reason for adding it was that /lib was often lacking, which is mitigated by 09a45ffb146fda75b87f89c729c31d1da5bf93da. I'll prepare patches for this for the next staging round. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAls82WsACgkQoqBt8qM6 VPo7Jgf+Ly/gsw8PUaKnJ4EA8QhqG2mfrr0/WBT+IcMD6Ho6jenZAPPVuJjGO3mp uYnBAjzqF7xsdtzoqZkxelyy8NVKFXq1HfEfiw/SOruv1s7vQ3yA80pnNax/1Usr 86X8qnQF5aeD37TKsLn10IvIz2Q1bKHtKO00o/dK9VQpF68+DpFoOoXPfcN84YPX aCVP/moFp53Akf4rZ2yKyj/+BNb+AkKQ7cSJWCWLGPQHCbMB38yKxvWZ6Th1vDvl /rsxbILO0tz4cjlH3gYq1lX7YIWjNByEx3kDS2dkedZpG5KTFRJf1lfnQiyY3cwj P2V7iXUohVuGmOrUqi9rsu35qy5Jwg== =QjOY -----END PGP SIGNATURE----- --=-=-=--