unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org, Efraim Flashner <efraim@flashner.co.il>
Subject: Re: 02/02: doc: Example vm-image doesn't need firmware.
Date: Tue, 25 Dec 2018 16:02:37 +0100	[thread overview]
Message-ID: <87ftulfy42.fsf@gnu.org> (raw)
In-Reply-To: <20181224091641.731F420496@vcs0.savannah.gnu.org> (guix-commits's message of "Mon, 24 Dec 2018 04:16:41 -0500 (EST)")

Hi,

guix-commits@gnu.org skribis:

> efraim pushed a commit to branch master
> in repository guix.
>
> commit 3c515b22255c8ca4a727ba230168cf1083979086
> Author: Efraim Flashner <efraim@flashner.co.il>
> Date:   Tue Dec 11 16:42:56 2018 +0200
>
>     doc: Example vm-image doesn't need firmware.
>     
>     * gnu/system/examples/vm-image.tmpl (firmware): New field, explicitly
>     empty list.
> ---
>  gnu/system/examples/vm-image.tmpl | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/system/examples/vm-image.tmpl b/gnu/system/examples/vm-image.tmpl
> index 36e2727..f149f67 100644
> --- a/gnu/system/examples/vm-image.tmpl
> +++ b/gnu/system/examples/vm-image.tmpl
> @@ -24,6 +24,8 @@ partprobe, and then 2) resizing the filesystem with resize2fs.\n"))
>    (timezone "Etc/UTC")
>    (locale "en_US.utf8")
>  
> +(firmware '())

Two things: (1) the indentation is off ;-), and (2) shouldn’t we set
‘firmware’ directly in ‘virtualized-operating-system’ in (gnu system
vm)?

Thanks,
Ludo’.

           reply	other threads:[~2018-12-25 15:02 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20181224091641.731F420496@vcs0.savannah.gnu.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftulfy42.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).