From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ABdXHsUaUWD4XgAA0tVLHw (envelope-from ) for ; Tue, 16 Mar 2021 20:53:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wK4SGsUaUWARewAAB5/wlQ (envelope-from ) for ; Tue, 16 Mar 2021 20:53:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 310371373C for ; Tue, 16 Mar 2021 21:53:25 +0100 (CET) Received: from localhost ([::1]:49308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMGgt-0005kp-Cs for larch@yhetil.org; Tue, 16 Mar 2021 16:53:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMGgi-0005jk-8l for guix-devel@gnu.org; Tue, 16 Mar 2021 16:53:12 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:55282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMGge-0001G8-Hz for guix-devel@gnu.org; Tue, 16 Mar 2021 16:53:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=K/c02ghz52TXKTGF1kykxSNuJIPyFenF1vBKgkFPCEo=; h=date:in-reply-to: references:subject:cc:to:from; b=afjLf/wWEjtWSQJMgR5GN28ued0l3qpiUKMjX tNHgkPH/Bm1ASJUlwWfM246pwR+K8ID4xc1PpfyVfLPZebeBW05AjZTm+oBVaTbMDomYAq PvBtT7bfD2ekZY8Rk92LqedjabdjI4vRgWqdVne3+zUm19aYaLmlQTGCv4Uvwr4wTaBW2t ktqlbeogqIteHbLuB4DfczpyrzJEz3cgbWCTf5Hbl8t/lpAUOVrQFDtVBhOoirq0k4LdpV NbEHlgVEB1plhWTTrWU44t4y5O0uL3Lw1DRnuIiHBGCMveqS5nN9xFgJclIJUDnRzDBUdb P3Z7Ftku6VkPjwunliDJPPSZg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 861faa68 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 16 Mar 2021 20:54:04 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: Leo Famulari Cc: =?utf-8?Q?L=C3=A9o?= Le Bouter , guix-devel@gnu.org Subject: Re: Release 1.2.1: zstd 1.4.4 -> 1.4.9: grafting or core-updates? References: <91998d12df3c4a279f46cf50b15d47c99e064a46.camel@zaclys.net> In-reply-to: Date: Tue, 16 Mar 2021 21:53:01 +0100 Message-ID: <87ft0un7ma.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615928005; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=K/c02ghz52TXKTGF1kykxSNuJIPyFenF1vBKgkFPCEo=; b=HlYWk7uwTVGAMhIJvBy/6ddYArMu+0XaM8Y0cpkPzEoofR5C2my3E4LwIGVjy5H1Y3AiPw 80oJVVyLNJBtHaFTBk9UDZoLPbrOov43WWb7iCaFkKwV67SIjZz+yU1BABUgSj3rIYv/P6 gkbuqYiutWKSFr8yEOwKamed2MfgOH3+y9Cti8xPbcs1mk3XTMyLBfGK6lonILYOzwxBdX d9vgphkaJWJftSn/4ENJ9xavQdxb9KMcJfO5/bRpToTR/AMDRyYT9edoawcdWPjHKC+Lmw Eg+5BJheag1K2dcyn59Bq012CkQJWMKXUWQmyFWk2AelAa4mZALatJmxgzRYWg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615928005; a=rsa-sha256; cv=none; b=C63y1Zg0MisnqY1rYs29idYh+eEcieIzrTf2FafTedPGFsXDT/rt3UhzKV9de0gPHhwYsx oMX9tm/NdmQoc7/wzKBDA93yDcDBsiCVVzhQluHvBHx5RyblGUkEadMtXkejfow4+iochM Vsp38LNJlSI0lzAK3p374lAnkE02AszGXRoEdEssv4OdimHykdoepDyr84ENGB+sAXGBux U5dsWOqFewYZIpwlnrV/hp5Aii9DSnIEft8MF9QsCA0EEEY5n1KEUDTSiLftGBN4yE24Pa c+8nxbnNHfiqlk18VBGg/m8Qw6uV4eDxTceqTHbB16lEXjOmZMuzUmn4x1JKzg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=tobias.gr header.s=2018 header.b="afjLf/wW"; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.70 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=tobias.gr header.s=2018 header.b="afjLf/wW"; dmarc=pass (policy=reject) header.from=tobias.gr; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 310371373C X-Spam-Score: -3.70 X-Migadu-Scanner: scn0.migadu.com X-TUID: PmLqe3Nv8nr9 --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi L[=C3=A9e]o, Wow, L=C3=A9o. You've done some seriously impressive CVE squashing in=20 such a short timespan, and I'm very grateful to have you on board. Leo Famulari =E5=86=99=E9=81=93=EF=BC=9A > I do agree that updating this program 5 versions in a graft was=20 > perhaps > too much. > > We should always try to cherry-pick bug-fix patches when=20 > grafting. > Otherwise the risk of breakage is too high. I agree. Whilst grafts are indispensible for timely deployment of=20 security patches, they're also a dirty hack composed entirely of=20 rough edges. They exist for one purpose: patch out known vulnerabilities.=20 Every extra change not strictly required for security is a=20 liability. We sometimes get away with grafting entire releases (OpenSSL comes=20 to mind), but this is not an ideal to emulate. > At least, these types of patches should be reviewed on=20 > guix-patches. > L=C3=A9o, can you send them to guix-patches in the future? I have the same request :-) Please submit non-trivial patches for=20 review (and, unfortunately, grafts are hardly ever trivial). This=20 isn't a comment on your work; it's our standard way of doing=20 things. I know we're not the #1 bestest project when it comes to the swift=20 review of patches. I understand the sense of urgency in fixing=20 things that one feels should have been fixed long ago. Thank you=20 for helping us to improve on both points. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYFEarQ0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW155gEBAIyq72wxVTmlWtHTeUkbSR4o2nzQa75/FNsZX7Z8 /3jjAQDzAhzJFhcYL00ZMvhZ+eaUVFKMPwUL3TCtw9ClVfAaAw== =9FFJ -----END PGP SIGNATURE----- --=-=-=--