From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id j6TfBmL2WWCjKwAA0tVLHw (envelope-from ) for ; Tue, 23 Mar 2021 14:08:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4D0wAmL2WWDFYQAAB5/wlQ (envelope-from ) for ; Tue, 23 Mar 2021 14:08:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A26AE24A0A for ; Tue, 23 Mar 2021 15:08:33 +0100 (CET) Received: from localhost ([::1]:50158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOhhw-0001x7-QB for larch@yhetil.org; Tue, 23 Mar 2021 10:08:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOhhS-0001vz-C1 for guix-devel@gnu.org; Tue, 23 Mar 2021 10:08:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55888) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOhhQ-0004kX-L2; Tue, 23 Mar 2021 10:08:00 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=54698 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lOhhQ-0004KQ-5J; Tue, 23 Mar 2021 10:08:00 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mark H Weaver Subject: Re: imagemagick@6.9.11-48 to graft or not to graft with 6.9.12-2 References: <87v99iki3l.fsf@netris.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 3 Germinal an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 23 Mar 2021 15:07:58 +0100 In-Reply-To: <87v99iki3l.fsf@netris.org> (Mark H. Weaver's message of "Mon, 22 Mar 2021 17:12:35 -0400") Message-ID: <87ft0mhsjl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616508513; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Ir6SeFhiourjZOxiTrwXCLwfwNatHkuAMTQ1n5qh0v8=; b=S2LDXKlSA3yWawioIROCnUryG4vnQPzRhvfaYqrd0/LwNsSslDKJ8EVK5RKjlkU8cw4VFu YDoGmXQxIL5Ot2xXFnsbtoS7OmDWLUjyJT6eHB2Guh0rlo81Xe9LZYw7InsR4/sUvB6ax8 EZJlDWmEF+t6pLK4JKy1U0wMcVzknXeBIZECBV3vGpeVJ9s/V9JpQeFyqRURUgigZURKOK GfkAL+HWqB+9brgGde82cBexBVY4pe0Ws0FmVxkesvyZ3k99Du7TSr/IJVmaYp50QeZCrx 0gpe/c0LEV16Sh6jWOqx7Z/LROcd8XSiLA8Xi02a3Y+yparLnLoUuZZU1eGHEg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616508513; a=rsa-sha256; cv=none; b=ZaUvQPl3SBZ9oTE88KciSm8/hS1GBxg61a2w8HkJsJBe2eGo8rG67Qyx5GHYnl1aBhWHfF WCtVhFoEQokGS6pgfeJWFSaAf3reDHq9ocXBrboHa32aCpxF0CHDtxk4rvudyK5wUb4h3o rNCurD++3KKZiI0eKUXmf5sDGS4cpjs/53xwf1WmE29rjxlWWVAdcXTxI6RtsdsoClIzhr AW3wqt0/gcojM25YZlLsVXQBm4cMyfIhfxrNIDa0/AhJxv7x3BBeeJ8pGOZ9EXPUfx6HYq OtL+F7Wby5K8fI29ylQiDqWm1dlZcPYj1nlvDCxjHqbytgqrAMPX4xLBVhD79w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: A26AE24A0A X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: EgNxjVgH2aJF Hi, Mark H Weaver skribis: > Andreas Enge writes: >> And please let us agree that in the future, we only backport fixes in gr= afts >> and do not update version numbers. > > I agree that in this particular case, that's what should have been done, > and that we should still try to do it. It will be several days at least > before I'm able to look at it, though. Would someone else like to try? > > I also agree that in general, we should be more careful to check for ABI > compatibility before grafting. More specifically, for libraries, we should only ever use replacements that are ABI-compatible. (That usually means that the major and minor version numbers are the same, which may be what Andreas had in mind.) Anything else is most likely broken. For command-line tools, I think we should only graft with replacements that are backward-compatible at the CLI level. That requires manual review of the changes, I guess. Thanks, Ludo=E2=80=99.