From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iPf8I4wAiGDCTwAAgWs5BA (envelope-from ) for ; Tue, 27 Apr 2021 14:16:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MHaoH4wAiGALQwAAbx9fmQ (envelope-from ) for ; Tue, 27 Apr 2021 12:16:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2F2EE26C09 for ; Tue, 27 Apr 2021 14:16:11 +0200 (CEST) Received: from localhost ([::1]:56116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbMdO-0008P0-6W for larch@yhetil.org; Tue, 27 Apr 2021 08:16:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbMco-0008O0-HM for guix-devel@gnu.org; Tue, 27 Apr 2021 08:15:34 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:60558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbMck-00029X-OH for guix-devel@gnu.org; Tue, 27 Apr 2021 08:15:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=hwrJA5fNgpCb7d41+7MAE7PEfqeqA7KDJJPxTEYGjQE=; h=date:in-reply-to: subject:cc:to:from:references; b=XgQ7f7AA9BiGqIHm181vuHl+UVnCLyNTvpGEN I6j1ObnIRifvCdZctHmE/QKnRo5K54X9CVw9ffqopiJtBicJRISegyYPfo2SG2m4cxLBvh bBAPtgWwUUXlD1TnjzivX7HMSfCm6h88ZcwqSDskZhre79hzBQgf7sSmsnwQEG0kGOs1nE ZQQyfINzEX2EqlL4FZMbn8/q03enBU0fBGpLXIJXE4bKBWl/IHbNcma6Vlih2Rm33w4efW 5ZgP1QC+NVZirU9t8lAHHmr7IBycRSxNDo9LVKuyVFPj+NoztkOhYkV8AhQ0e/QiNmcDtT 8N1mmSQBQ2rJDI1Fo9hrRulag== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 595f4950 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 27 Apr 2021 12:15:34 +0000 (UTC) References: <20210427113731.13295.67045@vcs0.savannah.gnu.org> From: Tobias Geerinckx-Rice To: Guillaume Le Vaillant Cc: guix-devel@gnu.org Subject: Re: branch master updated: gnu: Add html2text. In-reply-to: <20210427113731.13295.67045@vcs0.savannah.gnu.org> BIMI-Selector: v=BIMI1; s=default; Date: Tue, 27 Apr 2021 14:15:26 +0200 Message-ID: <87fszbsz35.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619525771; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hwrJA5fNgpCb7d41+7MAE7PEfqeqA7KDJJPxTEYGjQE=; b=k3y22Va12jQSndS7o+2Lqu6BF84BUkH/vhIQG3JfkpKa0RsMn+h4U8GYtBmbF+sN/6DNNN BWzSo25u/hdhyoH6FVi+ThVzgF6WDu1ITgQFWWusdeehzVdMw9n4XjLttS83Vvmkjnmk/6 PhxqMHDmGKsL/drCYn0ZE60eUnQihhVdWUEsghc5aA8d/qrtBaVLfh/8mNIqAq4q/HtqrI Yig9IvCePcmxeOaTh/1+qkSJ22IUB9y1m9h+nElMEEeFkUeuCaCNzzYpW43FbY++Wa0va+ hur5JehrBYSyypw9aNgNUFS/v76vkEVggO4kIK7W0GsULq56eFg8YVjI3Tb9Mw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619525771; a=rsa-sha256; cv=none; b=qpbhBTePyvITQcObt8qScqQi1hrrj1CmGUVYyoQac0c92bS4tIqAflKcWyFb3dwv3JyNUF xeVOdYY8bIr9ZH+WMCr/BTngiADg4evfYfndQ1Z9jYtZxBAmCHDJ+7bo0mVgTBPX0h9M2H 3UyaEQaPjKoyFAyGrddKtZcF8BNcnnOL62K8Mfx43oXSIgRk5CKF9eycdTqU0zQDbgYfSp QbkUdoJ01462wdBvUr770ICOyAKSeYh/SZ4wW9bEFO2XsORHfgXOxTggzg7qmSWmaqKarF XLiAkHDicelsY6N1vVKJi9scmmaKAPFR0ktDsr3hhKwiew/hLbVkdeCq2EMH+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=tobias.gr header.s=2018 header.b=XgQ7f7AA; dmarc=pass (policy=reject) header.from=tobias.gr; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -4.75 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=tobias.gr header.s=2018 header.b=XgQ7f7AA; dmarc=pass (policy=reject) header.from=tobias.gr; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 2F2EE26C09 X-Spam-Score: -4.75 X-Migadu-Scanner: scn0.migadu.com X-TUID: JmiYZ0mACdGK --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Guillaume, guix-commits@gnu.org =E5=86=99=E9=81=93=EF=BC=9A > gnu: Add html2text. Thanks! This package is good but would've benefited from review. Please=20 submit all non-trivial patches to guix-patches@gnu.org first (if=20 you did, I couldn't find it). We've been too lax about this in=20 the past, myself certainly included. I've pushed some additional fixes[0]: =2D The configure script is home-grown and simply =E2=80=98eval=E2=80=99s a= ll=20 command-line arguments in the hope that they are variable=20 assignments. Our defaults confuse it greatly: =2D-8<---------------cut here---------------start------------->8--- configure flags:=20 ("CONFIG_SHELL=3D/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5= .0.16/bin/bash"=20 "SHELL=3D/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bi= n/bash"=20 "--prefix=3D/gnu/store/bblcx4gcchp7a5dp2y51wbmlh0212xz6-html2text-2.0.1_pre= -1.05364c1"=20 "--enable-fast-install" "--build=3Dx86_64-unknown-linux-gnu") ./configure: line 25: eval: --: invalid option eval: usage: eval [arg ...] ./configure: line 25: eval: --: invalid option eval: usage: eval [arg ...] =2D-8<---------------cut here---------------end--------------->8--- Upstream didn't bother to add error checking, but we should still=20 call it in the expected manner. =2D Use #:make-flags etc. whenever possible rather than patching=20 build scripts. =2D Cross-compilation was broken. Building with=20 --target=3Daarch64-linux-gnu produced an x86_64 binary. Fixed by=20 passing CXX to ./configure in the non-standard manner above. =2D I noticed some 4-clause BSD headers & added them to the license=20 field. This is purely informative: the result remains GPL2+. Kind regards, T G-R [0]:=20 https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3De009b8d7126531a2983= 701413c5b97e620e495e4=20 and parents --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYIgAXg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW154zsBALPl9/D/re/6ebg8YbwhD7TX6tzmrh2F/WYCCFsb 5vQPAP48Ehqr/0du9coUc7lGR80YXBlHPDvvd+UoRlpqiawRBw== =VI5b -----END PGP SIGNATURE----- --=-=-=--