From: Xinglu Chen <public@yoctocell.xyz>
To: Leo Famulari <leo@famulari.name>,
Sarah Morgensen <iskarian@mgsn.dev>,
"Christopher Baines via Development of GNU Guix and the GNU
System distribution." <guix-devel@gnu.org>
Subject: Re: Can we find a better idiom for unversioned packages?
Date: Wed, 01 Sep 2021 18:50:36 +0200 [thread overview]
Message-ID: <87fsuojl43.fsf@yoctocell.xyz> (raw)
In-Reply-To: <2def863d-fd2e-46c3-9a4c-9c6772724d27@www.fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 2550 bytes --]
On Wed, Sep 01 2021, Leo Famulari wrote:
> On Wed, Sep 1, 2021, at 06:55, Xinglu Chen wrote:
>> I never felt like including the commit id in the version of a package
>> was useful; e.g., just seeing the first seven characters of the commit
>> id doesn’t really tell me anything about the version. I think it is
>> more useful to put the date of the commit in the version; Nixpkgs does
>> something like this[1]. I have started to put the date of the commit in
>> a comment, just to make it easier for people to know how old it commit
>> is; otherwise, one would have to find the VCS repo and find the commit
>> just to see how old the commit is.
>
> The issue I see with only using the date is that Git dates are not
> unique, in order, or even meaningful in a clear way.
Well, seeing
foo-1.0.0-1.2021-01-31
gives a user more useful information than something like
foo-1.0.0-1.cabba9e
With the former, I can quickly see that the version is from 2021-01-31,
whereas with the latter, I would have to either find the VCS repo online
or go to my local checkout of it and browse the logs.
> Commit dates don't have a consistent meaning: are they the time of
> first revision of a commit? Final revision of a commit? Time of
> signing? Pushing? They are often useful to estimate a timeline, but
> it's common for a Git "timeline" to jump back and forth by months or a
> year due to long-running development branches being merged in, or due
> to a "commit and then polish by rebasing" workflow.
I would say the the time of the final commit would be the best option,
but I agree that it can be ambiguous.
> Using the revision ID (of sufficient length) gives an unambiguous
> reference to the upstream source of a package and its artifacts in the
> store. How would you describe a package version to upstream when
> reporting a bug, except by revision ID? You can't tell them a
> timestamp and expect them to know which code a buggy package is based
> on.
One can get the commit id of a package by simply running ‘guix edit
PACKAGE’ and copying the commit id from the package definition. I don’t
think hiding the commit id from the package version would be a problem
for this situation.
> We could certainly add a timestamp to our version strings for
> VCS-based packages, but we should keep the revision ID too.
I haven’t really found the commit id that useful when looking at the
version of a package; adding a timestamp would certainly be better than
the status quo. :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-09-01 16:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 19:57 Can we find a better idiom for unversioned packages? Sarah Morgensen
2021-08-31 21:20 ` Maxime Devos
2021-09-01 12:11 ` Xinglu Chen
2021-09-01 16:29 ` Maxime Devos
2021-09-01 13:33 ` Liliana Marie Prikler
2021-09-01 16:39 ` Maxime Devos
2021-09-01 18:34 ` Liliana Marie Prikler
2021-09-02 14:09 ` Maxime Devos
2021-09-02 14:20 ` Liliana Marie Prikler
2021-09-02 14:34 ` Maxime Devos
2021-09-01 19:48 ` Jonathan McHugh
2021-09-01 21:47 ` Liliana Marie Prikler
2021-09-02 13:32 ` Maxime Devos
2021-09-02 7:53 ` Jonathan McHugh
2021-09-02 9:25 ` Liliana Marie Prikler
2021-09-01 10:55 ` Xinglu Chen
2021-09-01 15:37 ` Leo Famulari
2021-09-01 16:50 ` Xinglu Chen [this message]
2021-09-02 16:51 ` Leo Famulari
2021-09-02 17:29 ` Leo Famulari
2021-09-03 16:11 ` Xinglu Chen
2021-09-03 16:35 ` Leo Famulari
2021-09-03 16:57 ` Leo Famulari
2021-09-03 20:03 ` Xinglu Chen
2021-09-04 21:00 ` Leo Famulari
2021-09-08 21:15 ` Ludovic Courtès
2021-09-02 17:08 ` Leo Famulari
2021-09-08 21:28 ` Ludovic Courtès
2021-09-08 22:21 ` Jonathan McHugh
2021-09-08 22:38 ` Leo Famulari
-- strict thread matches above, loose matches on Subject: below --
2021-09-03 5:51 Sarah Morgensen
2021-09-03 21:14 Sarah Morgensen
2021-09-03 22:11 ` Liliana Marie Prikler
2021-09-04 12:32 ` Taylan Kammer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsuojl43.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=guix-devel@gnu.org \
--cc=iskarian@mgsn.dev \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).