From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UAxKGGavqGL0SAAAbAwnHQ (envelope-from ) for ; Tue, 14 Jun 2022 17:55:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0G1ZGGavqGLUJgEA9RJhRA (envelope-from ) for ; Tue, 14 Jun 2022 17:55:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 238221DB47 for ; Tue, 14 Jun 2022 17:55:18 +0200 (CEST) Received: from localhost ([::1]:34942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o18su-0005W5-Ui for larch@yhetil.org; Tue, 14 Jun 2022 11:55:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o18sF-0005UJ-9E for guix-devel@gnu.org; Tue, 14 Jun 2022 11:54:35 -0400 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]:40619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o18sD-0002kX-Gm; Tue, 14 Jun 2022 11:54:35 -0400 Received: by mail-qt1-x82b.google.com with SMTP id hf10so6384187qtb.7; Tue, 14 Jun 2022 08:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=SjkRDlplVzU3TJES9oN6Viye1+yhyqAMIejKm1RbRNE=; b=gj+8BRke5pPCTePvj+Ubtm+E69+/ZKf0ntGe0PVpQWyNW0RfM8Gl9kVpNin7WXWkAK ZhgkhxhySSkME72NbOZQz/ECtESuLXy8tACwXDzNePZHCqYdzsosWJn85Gra5fyV6opP l13rbFWtBy5F+zs08eD4Pv3s8Tj709KYbOT7McjN2ig3CYxwptarq5FtrshqpmbfHq4Q h3NRYIEPtXL9SclMTU9RuTgFtW++Kn6NpqxI0C9EHjtRcCqRE9JSL0wPygytqxswA/kA rTWu1oT6lOEiZEDW8///bQ0haAu8TYZEqA/tx9aW31OJQIfL6HllPKJo0/1CljPRdldT O1UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=SjkRDlplVzU3TJES9oN6Viye1+yhyqAMIejKm1RbRNE=; b=hTk6isiYFEmAKEWbs0o7HxdmjgOlG0HaYwRddxs8usN1mhmbNji4TV/V+aMfRdInAY HZx1vxfnesGqidM+EFG/WLiWuurUxMHYeI2V2kO0Hi7j2ZoRu0HG+EhZFSirCJyfu7K4 jQHgip3HSIpPHG4bu/0gvciWcYr052LRqwrEIAwcimPTo34zu0kMCM9+j7HrhukAh1T0 Ts4LvXpKgRI3RonuR8T2anNspj59izH4igzTBfz//KWFXy+g82MbVtNbWXPaki/IyWSa l5sAPvSnZ8kVIs86N72qQRa7RAnK0XXHMz/EyHYCuaNa4HD9gAXlWj/qif87dk6hVz7G HYVw== X-Gm-Message-State: AOAM530vi6ZtdQnCYVzTcf/Or6WZUaF77Sgvd5qL96CKvWmeVIvESi0O gtEBcgOGLt67rIshN1xN23K/9cjxleKLYA== X-Google-Smtp-Source: ABdhPJzUIGSp8hroJ4QtaGv73uawyzo+maS1/lfJ5sbI69aLY6lgRLLNOn/TYU5fpwJqjWxwQW7wsg== X-Received: by 2002:a05:622a:1803:b0:304:ef17:7532 with SMTP id t3-20020a05622a180300b00304ef177532mr4767153qtc.110.1655222071993; Tue, 14 Jun 2022 08:54:31 -0700 (PDT) Received: from hurd (dsl-10-149-55.b2b2c.ca. [72.10.149.55]) by smtp.gmail.com with ESMTPSA id h8-20020ac87148000000b0030501abadabsm7207736qtp.19.2022.06.14.08.54.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 08:54:31 -0700 (PDT) From: Maxim Cournoyer To: zimoun Cc: Thiago Jung Bauermann , Giovanni Biscuolo , Arun Isaac , GNU Guix maintainers , guix-devel@gnu.org Subject: Re: On commit access, patch review, and remaining healthy References: <87ee07m77w.fsf@gnu.org> <877d5um1oe.fsf@systemreboot.net> <87tu8viix0.fsf@xelera.eu> <87bkv1lipm.fsf@systemreboot.net> <87o7z0itz3.fsf@xelera.eu> <8735gb4xry.fsf@kolabnow.com> <86ilp3cvf8.fsf@gmail.com> Date: Tue, 14 Jun 2022 11:54:30 -0400 In-Reply-To: <86ilp3cvf8.fsf@gmail.com> (zimoun's message of "Tue, 14 Jun 2022 13:54:19 +0200") Message-ID: <87fsk7fdft.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::82b; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x82b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655222118; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=SjkRDlplVzU3TJES9oN6Viye1+yhyqAMIejKm1RbRNE=; b=uPEPHMqZqq0IOcVqWpxa5i4affVcG7dDzb1ionKxlgNQYDZMiDUb5xs8esY6bLQc3bWVk2 VY7evkTgPGHEHkGj8kLmiVurrBmCh6DufddvtscF1HG7jNULxHJuFGI+DgubAN0OKiht8T 4sPbtCbdiSJKwQiAFE1asbAN0gP9S3bLhinM1fXYZN2bAySRiiI40KIlw3998U1XM8InIa bQZsCzcNSlzcV0GFsVtz4V1bMK7fi/+vIVV+iXcqdWzzqHa1Wphb4BXyOcj0zYL2l1LFOr pNnGo0eOBrSXeNJXiC40jUfY92kHPyDN1pWUWujl7CEo9F8qiJD0v9GcbTyEIg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655222118; a=rsa-sha256; cv=none; b=shNCF1yPVmt8JnPDs0BINdirFHYHe8PMkO0oU3tA3iacnISoKFaOYfiLtAJT7XzlNfeLNv pFdeK0Wfzc102k0HKX8hTfHWZZsAbEErfByKPcRZ8j/kXNEYKuUMQMEmI1FnQVY0PC6+qj t6DeRaorwUyOXY6jlC5/O6aBNnwQVxzs8caZ0MXxdaujZ7xSGD29FjkRdadeCMGK5WW98U lgHUTxDGWlDBr2n8BHLtCnLqqUL9nPgPj9P/YnEDJLqO4g8kQVZzZh35+HxEX6YJaI/gLM dPLkrSfwqkf1Pgj+XMylqS6Ny8/U1B1Jc0BQfsS8zZamy8GV+Yx0eOjTEk/X6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gj+8BRke; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.99 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gj+8BRke; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 238221DB47 X-Spam-Score: -0.99 X-Migadu-Scanner: scn0.migadu.com X-TUID: 14l+QB2W6qke Hello, zimoun writes: > Hi, > > On Sat, 11 Jun 2022 at 01:13, Thiago Jung Bauermann wrote: > >> But I do think it's one more source of =E2=80=9Cfriction=E2=80=9D for ne= w contributors, >> and one more thing for us to require that they get right. > > [...] > >> There's one in the GNU Coding Standards=C2=B9: > > [...] > >> Personally, I think nowadays this purpose is better fulfilled by >> good commit messages and git blame. Especially with an editor that makes >> it easy to use them to navigate through history (such as Emacs, but >> certainly others as well). > > I agree that Emacs+Magit among many others make easy to navigate through > the history. However, the commit messages are probably good enough > because some Coding Standards are imposed. > > Because these standards, it is easy to navigate via grep for instance. > Git blame is useful once you know exactly what you are looking for. > Before that, when I try to figure out the logic behind such change, the > commit messages more or less fixed by the standards are very helpful, > IMHO. I agree. I've come to like GNU ChangeLog commit messages because it forces me to lay down the changes I've worked on, and sometimes I can spot things that would be better separated in its own commit, or that was unintentionally left while testing. When reviewing others' work it also give me a clear trail of what they did, and I can match the actual changes to their high level description. > Whatever the style (ChangeLog or anything else), it appears to me a good > thing to have strong standards. Agreed! Thanks, Maxim