From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Potential minor API change notice
Date: Sat, 03 Dec 2022 23:44:50 -0500 [thread overview]
Message-ID: <87fsdv7p6l.fsf@gmail.com> (raw)
In-Reply-To: <871qpiw4xy.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 02 Dec 2022 10:06:01 +0100")
Hi Ludovic,
Ludovic Courtès <ludo@gnu.org> writes:
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Hi,
>>>
>>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>>
>>>> This is a heads up to let you know that the
>>>> %BASE-PACKAGES-DISK-UTILITIES public variable exported from (gnu system)
>>>> may be removed in the near future.
>>>
>>> If the patch eventually gets consensus, I would suggest making that
>>> variable an alias using ‘define-deprecated’: that way people will know
>>> about it and code won’t break.
>>
>> An deprecated alias to what?
>
> To ‘%base-packages’ for example? It doesn’t really matter.
I've found that by setting the replacement to #f, it does what I want:
--8<---------------cut here---------------start------------->8---
1 file changed, 4 insertions(+)
gnu/system.scm | 4 ++++
modified gnu/system.scm
@@ -38,6 +38,7 @@ (define-module (gnu system)
#:use-module (guix gexp)
#:use-module (guix records)
#:use-module (guix packages)
+ #:use-module (guix deprecation)
#:use-module (guix derivations)
#:use-module (guix profiles)
#:use-module ((guix utils) #:select (substitute-keyword-arguments))
@@ -177,6 +178,7 @@ (define-module (gnu system)
%base-packages-interactive
%base-packages-linux
%base-packages-networking
+ %base-packages-disk-utilities
%base-packages-utils
%base-firmware
%default-kernel-arguments))
@@ -894,6 +896,8 @@ (define %base-packages-networking
;; many people are familiar with, so keep it around.
iw wireless-tools))
+(define-deprecated %base-packages-disk-utilities #f '())
+
(define %base-packages
;; Default set of packages globally visible. It should include anything
;; required for basic administrator tasks.
--8<---------------cut here---------------end--------------->8---
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix system build ~/stow/guix/hurd.scm
/home/maxim/stow/guix/hurd.scm:410:22: warning: '%base-packages-disk-utilities' is deprecated
--8<---------------cut here---------------end--------------->8---
I've sent a v2 to 59661 (you are in cc).
--
Thanks,
Maxim
next prev parent reply other threads:[~2022-12-04 4:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 20:07 Potential minor API change notice Maxim Cournoyer
2022-11-29 9:02 ` Ludovic Courtès
2022-11-29 16:40 ` Maxim Cournoyer
2022-12-02 9:06 ` Ludovic Courtès
2022-12-04 4:44 ` Maxim Cournoyer [this message]
2022-12-05 16:19 ` Katherine Cox-Buday
2022-12-05 19:29 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsdv7p6l.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).