From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8FV9AM3fAmUl0gAAauVa8A:P1 (envelope-from ) for ; Thu, 14 Sep 2023 12:26:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8FV9AM3fAmUl0gAAauVa8A (envelope-from ) for ; Thu, 14 Sep 2023 12:26:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9334F41422 for ; Thu, 14 Sep 2023 12:26:20 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694687180; a=rsa-sha256; cv=none; b=LD8piqEi5FyynuA1PePIMd5bDcBjgHA4VGKN7BIL8ZjsF9E+wHtUfIpEcWtcpQoURNn03/ /21fM/N5y16540OEj9odkBayYX9OnCqww+JwSSb8K7WQvoAeXAsw+GRjiyax3eO6mDQ+5b twj7DZ2GXjjcrQBfDFyCjtCQPI+DzofKs0969BYaje1qR6+QwvmskHlxdxg0aPlqKP5tBO FlTCKCUQnP0dRZjZyCIsfi2FsxTcI+MihGY81/B0jbwu6dqUhyHEfwN81Hp12EyunarP3m Q8TbMTnbHUTmF2PmVyGJcUlXycNuvPnfsT7CWc5SmTuoAYd71UM/LIL5O+FyuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694687180; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=xb6Di4adZc02OcwncvHJ4mQ0HrrJzr1ThG0WUaBMy1M=; b=vC3ccNuzAEaN9FKy5hgJfgH5/MAg9ibJKxRHiwENfCXttPujPoopV+cC+Qa3tBrao5GodQ tBkLsmPMHZLCpNvqzjC4ZG51aKRoqQ06TBwtN3kT9nKn15eTAoOnLVkWyJ0/y0zmjqWhqf sXiXiYpH2c/ymmrmDukZ5f7szwjnnfF7NKNmLnVL/fdsxTjYapfpCO/zqnlbVjo3tdmUcw r47+IEqQUyClzVzvWmmJbUe4D/x85Tj7ZmGWF6syW9X/QDrzr2p7rYN2q7W1R6JW+93eSe n4U5MrBgMGQLr3T/NCCvOVhhZnO7A2Wd3en2nerophpDE7xhL5YrGZGq6zbXlQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgjXt-0000gO-EI; Thu, 14 Sep 2023 06:26:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgjXP-0000C5-Nl for guix-devel@gnu.org; Thu, 14 Sep 2023 06:25:44 -0400 Received: from ns13.heimat.it ([46.4.214.66]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgjXJ-0002mm-G7 for guix-devel@gnu.org; Thu, 14 Sep 2023 06:25:30 -0400 Received: from localhost (ip6-localhost [127.0.0.1]) by ns13.heimat.it (Postfix) with ESMTP id 2A9EA3009C0; Thu, 14 Sep 2023 10:25:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at ns13.heimat.it Received: from ns13.heimat.it ([127.0.0.1]) by localhost (ns13.heimat.it [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rFVDcs-ujwh4; Thu, 14 Sep 2023 10:25:18 +0000 (UTC) Received: from bourrache.mug.xelera.it (unknown [93.56.171.217]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ns13.heimat.it (Postfix) with ESMTPSA id 26C593009B9; Thu, 14 Sep 2023 10:25:18 +0000 (UTC) Received: from roquette.mug.biscuolo.net (roquette [10.38.2.14]) by bourrache.mug.xelera.it (Postfix) with SMTP id C4C6D29C0BFB; Thu, 14 Sep 2023 12:25:17 +0200 (CEST) Received: (nullmailer pid 12575 invoked by uid 1000); Thu, 14 Sep 2023 10:25:17 -0000 From: Giovanni Biscuolo To: Liliana Marie Prikler , Maxim Cournoyer Cc: guix-devel@gnu.org Subject: Re: [workflow] Automatically close bug report when a patch is committed In-Reply-To: Organization: Xelera.eu References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <87jzt2feq6.fsf@xelera.eu> <87y1hikln6.fsf@wireframe> <2d93b48dfd381c55ff706394ff7226133f5e014a.camel@gmail.com> <87pm2pces0.fsf@xelera.eu> <87bke8wo96.fsf@gmail.com> <929b035f6f4aca0793d9f8a6454b673b2a7069c1.camel@gmail.com> <87zg1sv3vt.fsf@gmail.com> <6929416953b2939445a5247b014142ea8bb521d9.camel@gmail.com> <87h6nyw0su.fsf@gmail.com> Date: Thu, 14 Sep 2023 12:25:16 +0200 Message-ID: <87fs3h9hmb.fsf@xelera.eu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=46.4.214.66; envelope-from=g@xelera.eu; helo=ns13.heimat.it X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.31 X-Spam-Score: -8.31 X-Migadu-Queue-Id: 9334F41422 X-Migadu-Scanner: mx2.migadu.com X-TUID: JFg8tuK5M3TU --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Liliana Liliana Marie Prikler writes: > Am Mittwoch, dem 13.09.2023 um 11:27 -0400 schrieb Maxim Cournoyer: [...] > I do wonder how the ChangeId would work in practice. It's a =C2=ABtag to track commits across cherry-picks and rebases.=C2=BB It is used by Gerrit to identify commits that belong to the same review: https://gerrit-review.googlesource.com/Documentation/user-changeid.html We could use it for the same purpose and instead of building a web application for code review, "simply" count that all 'Change-Id's in a patchset have been pushed to the Guix official repo to declare the related bug report closed. > Since it's not really assigned by the committer, it would have to be > generated "on the fly" and attached to the mail in between Not to the mail, to the commit msg! [1] > which could result in all kinds of nasty behaviour like unstable Ids > or duplicated ones. No, modulo hook script bugs obviously. > Also, if we can automate this for ChangeIds, we could also automate > this for patch-sets =E2=80=93 the last patch in the series just gets the > Closes: tag added by mumi. =C2=A0 The idea is that, but we don't need to add "Closes" to the commit msg (via post-receive hook), we "just" need the hook to send an email to NNNN-done on behalf of the committer (the committer, not the contributor). > Furthermore, I'm not convinced that it would ease the issue of > forgotten bugs as you can't really apply them to the past. No, this 'Change-Id' is not intended for past bug reports since we **must not** rewrite past commits _because_ commit messages are /embedded/ in commit objects. ...but for this purpose we could use git-notes, **if** wanted: https://git-scm.com/docs/git-notes :-D > So the practical use is limited to the case where you intentionally > cherry- pick this or that commit from a series. No: the practical use is that for each guix-patch bug report we can count how many [PATCH]es are left to be committed and act accordigly, for example notify all involved parties (contributor, committer, 'X-Debbugs-CC's) that N/M patches from the series are still to be merged upstream... or close the bug report if zero patches are left. > How we want to deal with that case could be a discussion in its own > right, and maybe ChangeIds really trump the explicit tags proposed by > Giovanni or myself here. Whether that justifies the cognitive > overhead of juggling them around on every submission remains to be > shown or disproven. There will be no additional cognitive overhead for contributors since 'Change-Id' will be automatically managed, they can simply ignore it. > Beyond the scope of the discussion so far, it also doesn't help us with > duplicate or superseded patches (e.g. two series on the mailing list > propose a similar change, because one of them has already been > forgotten). No, IMO there is **no** solution to this problems other than "triaging" (id:87msxyfhmv.fsf@xelera.eu https://yhetil.org/guix/87msxyfhmv.fsf@xelera.eu/) > Again, the explicit close tags would allow this case to be > handled in an interpretable fashion. In both cases, we do however also > introduce the potential for incorrect tagging, which then needs to be > resolved manually (more or less a non-issue, as it's the status quo). There is no potential of incorret tagging when using a hook-commit-msg [1] to add 'Change-Id'. For the other method discussed here, there is no way to avoid users mistyping 'Closes:' pseuto-headers in their commit messages: if mistuped they will be ignored :-( Cheeers, Gio' [1] https://gerrit-review.googlesource.com/Documentation/cmd-hook-commit-ms= g.html =2D-=20 Giovanni Biscuolo Xelera IT Infrastructures --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJABAEBCgAqFiEERcxjuFJYydVfNLI5030Op87MORIFAmUC34wMHGdAeGVsZXJh LmV1AAoJENN9DqfOzDkSVloP/08yrxUtyHh1rMM1xS6T7bvWlLtNw70Ec2nmoknR 1Xs4HUETUrWXmbgadc77aRM5JBi4huGasQZFssS+W2lkZeftnLWlU8h/zMTsKSv+ 8ZygItuv88meU2vmWxkvqeDHGewJ07cWsVs5+t773EyfCl551AjqRSvR7aTLCsSV x0t255FJ//N7cdGiPQs6IjfS+KdFu9M1eoDqUMDPzKk2D/tqrnt0GU07eBTp35A4 5u1i4/HZAY5yMvNg923f2j73sUaTJ/1d6My6kSPF2A0v+0SJ1H9ajwGGoQJJOsJY mvg0xfBWyPi80eKOD8P8UHTKrRNAayJhxRsvDPgsSwTqZoE+6rT+JrnVfeWK931c VH47T0EcRQqqppDKptmHUOEB0Q2icEC46qYAYy1N3B34m6UvH1pIWpxe0v01/TAR PJIK56MaKbhGLMLoD7awB9rmpaiHTbrbfKeQccoC9JmZKiqUUclqQxN5ZiGUETz/ puIfESEuOmaoK+B0pW5GDIapTYQp7/HAlARRXcx7Q2OAqa/V9uTR8DgIHF3PIKOi NwtrSyjgJ1v4KOh7JlV9nJqS1gGnoHIt9XIaX/DhELBsPMPg79LydkCvNAwd5fOm gkHMEhtMvZmwQXCb2wxjDKASDKBDcC+IygsR3EYWSUa+9kXUq56TNwc2cF3OVmh0 H+ap =Hbh7 -----END PGP SIGNATURE----- --=-=-=--