From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id yPT7Mk35dmXEgAAAkFu2QA (envelope-from ) for ; Mon, 11 Dec 2023 12:58:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id sE/ZK035dmX0oAAAe85BDQ (envelope-from ) for ; Mon, 11 Dec 2023 12:58:05 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=UO2o1De1; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; arc=pass ("zohomail.com:s=zohoarc:i=1"); dmarc=none ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702295885; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=B9wwVpfhbXjCzmdP4Rw4WZpSFriwICxPsiWAwaISi0s=; b=Rh8ADfLM0YsbIlcT4hpB/8W06+P5e6USBz8SQ+WSXpj2IKnMQCcH7vU6ll4PThLrbB9kAT TNh6Mn3RRL+QfsI+zqDSvO8PZr+/cBIhCq0NfJVBcutNUx4uiOMMrho+lxHzA24JHFN0wy 3vXzHQDw2V1Y1ygA1/KzeWYIvMBr+HuNaomdMdGIgxzzs9S8swlY9G/CCwqD7u4VOic2bX lIJ2lFPJW/DxYOwx7vMTe6gsd2HkVtV77GYQaaxjvK6s/7lyeKcGY7hRRNW/DspPODjcAg c18Yzd5b9WoPhN7DCC46nW6CFjlWsfgVWzdC9bO4kHxF9+W7Ovg8P+z3TAE4YA== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1702295885; a=rsa-sha256; cv=pass; b=SLY7aq1RzoUU4eqNoxIXo9u6D3hZ+7Nk0o5QyfXsXveUv9ck3KvuH8rFyTmM3txZxOXwyb cuXBqFGfT5GQsTqKn9wEbye8e758oVd3Fi2NToGEY3WYVoanN1SxSr9RYoMyoXAh40gC6H mXeUwB6JMu6GXdxFm2UaPiwZvummPgF5cF9iY1BGRBdwX1U+W4pOCEpfMpLNel8fDSx3uO gNKL9bEvzkNRthFIwzK5wj2G3DyPHyRc0ree4Z62RS/02MoQiB8KWZYrVuvvr1lCKGfBGz CLaa/aH8G2o5wYHoXBW5sBKJO0tRwwd2Tqlij+9NtzSHfzPq+339vUgNV2jzZg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=UO2o1De1; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; arc=pass ("zohomail.com:s=zohoarc:i=1"); dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 33EBF59D55 for ; Mon, 11 Dec 2023 12:58:01 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCeuk-0000yr-Fp; Mon, 11 Dec 2023 06:57:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCeuh-0000yO-Tw for guix-devel@gnu.org; Mon, 11 Dec 2023 06:57:32 -0500 Received: from sender4-of-o57.zoho.com ([136.143.188.57]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCeuW-0008Pd-4z for guix-devel@gnu.org; Mon, 11 Dec 2023 06:57:31 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1702295836; cv=none; d=zohomail.com; s=zohoarc; b=FN7wR6eNQd+sIbtIS7Tl2LBmljMf785T2/HjCYJbEjpfdJd7WFl/WTfB/nG7eXmbVCmfyHvh+QvCFEZzCvnsGIQXqbEKSv82NXz29E+tiHu6PbfJc8rSjzc35I3nlvSLXr7gzZL/PNjrio2cXBEFDEUjy5VKwk7m6Y+E60ngFW4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702295836; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=B9wwVpfhbXjCzmdP4Rw4WZpSFriwICxPsiWAwaISi0s=; b=GwvBAMgXRfZDt8EFMnLiKOUukwFKFHmiuJiRfwmKA1QJ+Y8S1mibPpd5qS2fd+IAFd6jQg2WFKOGnX46bNUf8f7x2Gd48rl4jxIT9Zp1RtLc/SeLhCZpxN6NuOLNsv706q3ZptxESip0ImkcVxVv25P1eZtGq/4sozy0VqXOkA8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1702295836; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=B9wwVpfhbXjCzmdP4Rw4WZpSFriwICxPsiWAwaISi0s=; b=UO2o1De17Hk6+CUYgMbQghy+AGbLpbSyUMUw0GiziCH/g1+Yw+Q+UDkgyWi8cz4v INC0GTfUF2jfdDvyvoR8S3b+ieLsNsSVWwS3iRgoHAh8VKbYcotmhEXNJ6aDTxANSLQ Ji5iYrKhopuknFj0i6dQY6O4Hk48tbyPGGvVp5YI= Received: from localhost (153-108-142-46.pool.kielnet.net [46.142.108.153]) by mx.zohomail.com with SMTPS id 1702295833597554.5833414195881; Mon, 11 Dec 2023 03:57:13 -0800 (PST) References: <6bcc9412f092c20fbd7f8326dbf91e90cef0eed1.camel@gmail.com> <875y16c54b.fsf@elephly.net> User-agent: mu4e 1.10.8; emacs 29.1 From: Ricardo Wurmus To: Attila Lendvai Cc: Philip McGrath , Saku Laesvuori , Liliana Marie Prikler , guix-devel@gnu.org Subject: Re: Should commits rather be buildable or small Date: Mon, 11 Dec 2023 12:51:41 +0100 In-reply-to: Message-ID: <87fs09ar56.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.57; envelope-from=rekado@elephly.net; helo=sender4-of-o57.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 0.39 X-Spam-Score: 0.39 X-Migadu-Queue-Id: 33EBF59D55 X-Migadu-Scanner: mx11.migadu.com X-TUID: nABxZA0sdmrP Attila Lendvai writes: > i myself also had headaches multiple times when i fixed something that > needed to touch several different packages, and they would only work > when applied in one transaction: > > how many debbugs issues? multiple issues and record the dependencies? > little gain for much more effort on both sides... but if one issue, > then what should be the name of the debbugs issue? etc... We often have just one debbugs issue per transaction, i.e. multiple patches that all belong to the same issue. The free form cover letter should describe what the relation between the patches is. This can be done for dependencies (e.g. an R package and all the unpackaged things it needs) or for a feature with several related but atomically recorded changes. A misconception I read earlier is that there=E2=80=99s a desire to have one commit per touched file, but that=E2=80=99s certainly not true. Atomicity doesn=E2=80=99t care about file boundaries, and we don=E2=80=99t care about= them either. Commits should tell a story and often it is easier to tell it by making consecutive independent changes. --=20 Ricardo